From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 437F1C433E7 for ; Wed, 14 Oct 2020 20:21:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B13882222C for ; Wed, 14 Oct 2020 20:21:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y6RpjaIR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B13882222C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1IF3O/goZ0bhIyKVO0BNltL5+M1EOuiehsX+HuA7xz8=; b=Y6RpjaIRNNHsKugU6WLPuBZfM DCntOv5fcM+LPS2TSeDGAwxnFme2MdFypgr/n4pBLP8+DBiaehHpwLIRPK53VuG1g5P6tClsiRJf5 lpMrBPMobzcKROf6o+j/yBECpUKYYRd18aCY/My8hDbHRRuS0sjgTFBBB7vKMZvN5Hu4QqlGBYdTu 6nyDw6CD0er5PbWfTqmD1y41Jdp/t2iTaExH12gMcZtqPRnIGNhTox6z/C52PZy0X1biNS2DqF0qW PdILu2WTDj3tTsDoy8V/9LjWn0dGuNrx1xBPdxP1A6JdJWvA8DU6gS9qFZSS6E4hCdWCnwDZndxQm d/3gqkznQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSnFw-0007tD-W9; Wed, 14 Oct 2020 20:20:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSnFu-0007sP-2t for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 20:20:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A5E79D6E; Wed, 14 Oct 2020 13:20:09 -0700 (PDT) Received: from bogus (unknown [10.57.12.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 10A703F719; Wed, 14 Oct 2020 13:20:06 -0700 (PDT) Date: Wed, 14 Oct 2020 21:20:00 +0100 From: Sudeep Holla To: Florian Fainelli Subject: Re: [PATCH 01/11] firmware: arm_scmi: review protocol registration interface Message-ID: <20201014202000.3f57rx73d2vele47@bogus> References: <20201014150545.44807-1-cristian.marussi@arm.com> <20201014150545.44807-2-cristian.marussi@arm.com> <1b461304-2c25-3206-5799-b561ac6e0bd2@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1b461304-2c25-3206-5799-b561ac6e0bd2@gmail.com> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_162014_212251_85F4AE31 X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cristian Marussi , Sudeep Holla , linux-kernel@vger.kernel.org, thara.gopinath@linaro.org, lukasz.luba@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, souvik.chakravarty@arm.com, vincent.guittot@linaro.org, etienne.carriere@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 12:03:45PM -0700, Florian Fainelli wrote: > On 10/14/20 8:05 AM, Cristian Marussi wrote: > > Extend common protocol registration routines and provide some new generic > > protocols' init/deinit helpers that tracks protocols' users and automatically > > perform the proper initialization/de-initialization on demand. > > > > Convert all protocols to use new registration schema while modifying only Base > > protocol to use also the new initialization helpers. > > > > All other standard protocols' initialization is still umodified and bound to > > SCMI devices probing. > > > > Signed-off-by: Cristian Marussi > > --- > [...] > > > + struct scmi_protocol_instance *protocols[SCMI_MAX_PROTO]; > > Humm that would be 2048 bytes on a 64-bit platform and 1024 bytes on a > 32-bit platform, this is not so bad, but it is a bit wasteful given that > 6-7 standard protocols are typically found, and most often no > proprietary protocols are registered. Not necessarily to be addressed > right now. > Thanks for looking at these patches so quickly, much appreciated. I haven't looked at this series in detail yet. But this is something that caught my attention too when I glanced at these patches. I mentioned the same to Cristian. Indeed we can address that separately, we have even this for notification, we need to see if we can put all such info in a container structure and then use hashtable or idr. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel