linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: f.fainelli@gmail.com, vincent.guittot@linaro.org,
	sudeep.holla@arm.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com,
	Jonathan.Cameron@Huawei.com, souvik.chakravarty@arm.com,
	etienne.carriere@linaro.org, lukasz.luba@arm.com
Subject: Re: [PATCH 06/11] firmware: arm_scmi: add support for protocol modularization
Date: Wed, 21 Oct 2020 11:30:08 +0100	[thread overview]
Message-ID: <20201021103008.GC20482@e120937-lin> (raw)
In-Reply-To: <c52f9598-eb33-767c-8181-6e839c884313@linaro.org>

On Tue, Oct 20, 2020 at 10:47:28PM -0400, Thara Gopinath wrote:
> 
> 
> On 10/14/20 11:05 AM, Cristian Marussi wrote:
> > Modify protocol initialization callback adding a new parameter representing
> > a reference to the available xfer core operations and introduce a macro to
> > simply register with the core new protocols as loadable drivers.
> > Keep standard protocols as builtin.
> > 
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> > ---
> >   drivers/firmware/arm_scmi/base.c    | 56 ++++++++++--------
> >   drivers/firmware/arm_scmi/bus.c     | 14 ++++-
> >   drivers/firmware/arm_scmi/clock.c   | 56 +++++++++---------
> >   drivers/firmware/arm_scmi/common.h  | 42 +++++++++-----
> >   drivers/firmware/arm_scmi/driver.c  | 50 ++++++++++------
> >   drivers/firmware/arm_scmi/perf.c    | 88 +++++++++++++++--------------
> >   drivers/firmware/arm_scmi/power.c   | 46 ++++++++-------
> >   drivers/firmware/arm_scmi/reset.c   | 46 ++++++++-------
> >   drivers/firmware/arm_scmi/sensors.c | 52 +++++++++--------
> >   drivers/firmware/arm_scmi/system.c  | 16 ++++--
> >   include/linux/scmi_protocol.h       | 18 +++++-
> >   11 files changed, 288 insertions(+), 196 deletions(-)
> > 
> > diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c
> > index f40821eeb103..8d7214fd2187 100644
> > --- a/drivers/firmware/arm_scmi/base.c
> > +++ b/drivers/firmware/arm_scmi/base.c
> > @@ -15,6 +15,8 @@
> >   #define SCMI_BASE_NUM_SOURCES		1
> >   #define SCMI_BASE_MAX_CMD_ERR_COUNT	1024
> > +static const struct scmi_xfer_ops *ops;
> 
> Minor nit. I would consider renaming ops to something more
> meaningful like xfer_ops (or anything that makes sense). ops by
> itself leads to confusion with ops in scmo_protocol and  in
> scmi_protocol_events.
> 
> Same suggestion for all other declarations of ops in this patch.
> 
I agree, but I'm in fact reworking deeply the interface for protocols
initialization (following some idea from Florian) in order to pass down
a protocol object including the xfer_ops instead of a handle+ops like
now, so this hopefully will solve also this concern.

Thanks

Cristian
> -- 
> Warm Regards
> Thara

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-10-21 10:31 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 15:05 [PATCH 00/11] SCMI vendor protocols and modularization Cristian Marussi
2020-10-14 15:05 ` [PATCH 01/11] firmware: arm_scmi: review protocol registration interface Cristian Marussi
2020-10-14 19:03   ` Florian Fainelli
2020-10-14 20:20     ` Sudeep Holla
2020-10-15  8:42     ` Cristian Marussi
2020-10-15  9:41   ` Vincent Guittot
2020-10-15  9:58     ` Cristian Marussi
2020-10-21  2:46   ` Thara Gopinath
2020-10-21 10:08     ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 02/11] firmware: arm_scmi: hide protocols' private data Cristian Marussi
2020-10-14 19:19   ` Florian Fainelli
2020-10-15  8:52     ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 03/11] firmware: arm_scmi: introduce common protocol interface Cristian Marussi
2020-10-21  2:47   ` Thara Gopinath
2020-10-21 10:27     ` Cristian Marussi
2020-10-26 13:07       ` Thara Gopinath
2020-10-28 21:04         ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 04/11] firmware: arm_scmi: refactor events registration Cristian Marussi
2020-10-14 15:05 ` [PATCH 05/11] firmware: arm_scmi: make notify_priv really private Cristian Marussi
2020-10-14 15:05 ` [PATCH 06/11] firmware: arm_scmi: add support for protocol modularization Cristian Marussi
2020-10-21  2:47   ` Thara Gopinath
2020-10-21 10:30     ` Cristian Marussi [this message]
2020-10-14 15:05 ` [PATCH 07/11] [DEBUG] firmware: arm_scmi: add example custom protocol Cristian Marussi
2020-10-14 15:05 ` [PATCH 08/11] [DEBUG] arm64: dts: juno: add example custom protocol support Cristian Marussi
2020-10-14 15:05 ` [PATCH 09/11] [DEBUG] firmware: arm_scmi: add example SCMI driver for custom protocol Cristian Marussi
2020-10-14 15:55   ` Randy Dunlap
2020-10-14 16:44     ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 10/11] [DEBUG] firmware: arm_scmi: add custom_dummy SCMI devname Cristian Marussi
2020-10-21  2:49   ` Thara Gopinath
2020-10-21 11:35     ` Cristian Marussi
2020-10-26 12:37       ` Thara Gopinath
2020-10-28 21:28         ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 11/11] [DEBUG][HACK] firmware: arm_scmi: force implemented protocol 0x99 Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201021103008.GC20482@e120937-lin \
    --to=cristian.marussi@arm.com \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=etienne.carriere@linaro.org \
    --cc=f.fainelli@gmail.com \
    --cc=james.quinlan@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=souvik.chakravarty@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=thara.gopinath@linaro.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).