From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA143C388F9 for ; Fri, 23 Oct 2020 11:38:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56A8520EDD for ; Fri, 23 Oct 2020 11:38:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yJ+K/cDm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56A8520EDD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rACN5mNZV15wH053s39HSNiSuMpRMl1J3hYhZB6Fp9o=; b=yJ+K/cDm3lvnIgFwNOP6np2zx nduMArkOdxi8cE4Iwph3/kkKqaoQKzApsDqhfoQOkhRoWjYCkok3KQiFe7bxw+LNGYGoFhB/udr4k XSATO7OTT3uBFUF+JIsrlLRaa1D158OAeDlIvTw0F1XzePxIaid0WacOtTQ+jSKEoAiErPkIrdLnO upxNzPZY5JzaGP8KXyI2NdkkF1radqjcwi7tjQZ2eFUViSyTFZ/f0DcsjzSRCmFHiCK7EKMvx2ZN4 3SqpazFossHG141Ar/yI5T10D9Pr9Xuv+j/dSP776srnbx//WjM5xPf0wRNIn+NMBELu6YfqNlGJ0 Mwc08qzrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVvO6-0003D1-Ad; Fri, 23 Oct 2020 11:37:38 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVvO3-0003CJ-MJ for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2020 11:37:36 +0000 Received: by mail-ed1-f67.google.com with SMTP id l16so1222107eds.3 for ; Fri, 23 Oct 2020 04:37:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=q0GPhn5JJBs3wXewaUlciqVNVuKfom97w1uHr11IvCY=; b=oGj0YHRknNHQrRgYYAUPxaYtX8JFaZVU5x12ZUi2XzwRZn6qAous5j6sr5tj0b0Ro9 umOTjXyLbI2lryiTLzhoB4TtTEkomAGXAAyZsYw09dc0rjI8J0qfP6WgQOGHAT3d9s/l +HjbhS8KDrDyJcgRKhlTT7Er/RExWDT3inMule7sfqYFd4CeVCMrx2mfjLDgIeAzP3zc 1nHsyjzGfBN6am/MQ/AA/7GvnRQiEQLoie6OPSYeRh9+IsAvwGA60LMs2EdC84LtMyB2 axCb/9Djhqr1pXClIkLZx/5dusna9IJ8ik+KTKn2u8pD2KdBq1lSneStue8ALDPNqQP1 UnVw== X-Gm-Message-State: AOAM533hPKXR1r5gq+y2j4cs54Uri4oU5O5NjekYKFsDMwlHICZpEgwu qH48LYoNP18zHzVx+PAzK0gjfOdZP1A= X-Google-Smtp-Source: ABdhPJw9zngAw3CwF0fnguGqxY1LBxTD9/TdNghCNKTeVN5b6ziJtWm1/KvaF81UKjnAWX9pBQ3yEQ== X-Received: by 2002:a05:6402:1c04:: with SMTP id ck4mr1757401edb.274.1603453054564; Fri, 23 Oct 2020 04:37:34 -0700 (PDT) Received: from kozik-lap ([194.230.155.171]) by smtp.googlemail.com with ESMTPSA id p18sm185618edt.23.2020.10.23.04.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 04:37:33 -0700 (PDT) Date: Fri, 23 Oct 2020 13:37:28 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH 1/2] soc: samsung: exynos-pmu: instantiate clkout driver as MFD Message-ID: <20201023113728.GA61748@kozik-lap> References: <20201001165646.32279-1-krzk@kernel.org> <20201001165646.32279-2-krzk@kernel.org> <32d3faaf-1631-3ebe-6d73-fe565c39639d@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <32d3faaf-1631-3ebe-6d73-fe565c39639d@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201023_073735_755519_DFBCE8B3 X-CRM114-Status: GOOD ( 19.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, Tomasz Figa , Chanwoo Choi , Kukjin Kim , Sylwester Nawrocki , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 23, 2020 at 01:34:19PM +0200, Sylwester Nawrocki wrote: > Hi, > > On 10/1/20 18:56, Krzysztof Kozlowski wrote: > > The Exynos clock output (clkout) driver uses same register address space > > (Power Management Unit address space) as Exynos PMU driver and same set > > of compatibles. It was modeled as clock provider instantiated with > > CLK_OF_DECLARE_DRIVE(). > > > > This however brings ordering problems and lack of probe deferral, > > therefore clkout driver should be converted to a regular module and > > instantiated as a child of PMU driver to be able to use existing > > compatibles and address space. > > It might have been cleaner to have the CLKOUT device as a PMU subnode in DT, > then device instantiation would be already covered by devm_of_platform_populate(). > But it gets a bit complicated to make such a change in a backward compatible way. Yes, I agree, but the backward compatibility would be here a pain. Optionally the driver could check for new DTB and skip adding MFD children... but this is just simpler. > > I have tested both patches on Trats2, where CLKOUT provides master clock for > the audio codec. > > Reviewed-by: Sylwester Nawrocki > Tested-by: Sylwester Nawrocki Thanks! Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel