From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E00BC4363A for ; Fri, 23 Oct 2020 17:51:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFCB421582 for ; Fri, 23 Oct 2020 17:51:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zSbFhSRn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="h9H11cgb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFCB421582 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZsL/jS3WWXDNLDlliiTaACt5itg8ynX09xUkpIhnnLs=; b=zSbFhSRnUpYmB6d5vXcMjt2tU Phr09ZxED/NSuA+LxJQmeXb1uXx72+myHs4j3dtD3ZappZRmaovjlBECdprX/FOxnVbkn5nVtc9xe VCpJ2LTmHof4VaMYbEstTsBS3FsjEIygxTYv/Z8m+G4VmUQH3OHNkMgI4/FWvVeuQjLoSSVfM/yA7 cqCl3d2myYrZ4riRKScJrq9N65MIdFdTPLLKHGspYSQV4sqUl5dxInes5zYaVj0bY20YG4Ifd7Qg0 4bXUHkilij9rPBZl9V+0k6LjtNP8LGnz2r3hS0YvygpbofXqonPbkq+ei6b357hLsNNwlZhU4jaHQ P836mmLsQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kW1Bw-0002G6-R6; Fri, 23 Oct 2020 17:49:29 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kW1B1-0001lI-Hv for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2020 17:48:33 +0000 Received: by mail-pg1-x543.google.com with SMTP id b23so1825501pgb.3 for ; Fri, 23 Oct 2020 10:48:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uHs6b4ooy0rgFnXBjoHTZU/MFzwidZAAr9PXWq9UsVk=; b=h9H11cgbsiLIfnCVNg9C63PczJj6klub3nyQOP7k17qHXCkM3+IiRWUf+K8onV/M6f cq6hpYWY5tijhMZOqe4vpxWnGOmq8cRM3qeYtsvRKEgPmJNNtDrmOS532+baO+0nsP5H 4oTZzToITDWX/+cRTyYkk0o02ppC4ZW2srP3cde+HPF1A0gWOS7McnJYg5AziS2A8+k5 FA/pfx2HXxsJo1PFtx/M/61rAc4BlJZES29IbLZRpqOuPDxsS+IoEvzMCqD9jME5DLTE nrFqzJCCPwXyQB8C7frIf3mqYooXH89m8/kypUCqoZ0QyzM52bhO/vCOCMQcptgtC5Xq D7GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uHs6b4ooy0rgFnXBjoHTZU/MFzwidZAAr9PXWq9UsVk=; b=TBbPLW14AUDLf9esEbBpcpRUmjNaBFlLdCpsUlOSY+uZyDqOPkiFsyLyUSIYp9Y5gv l/xbwrffNjpMXyUto0zHgjcF4yiz0Fd/ETSekeb2yAlVw6kGlCZzn51XpMktBcWTWs37 nquz3v344wnSq7Eys6ULtMGQdsUEaqlaDjx+aym9TnisLhBzdARxrueBcdCNn0NjFSVy 9qFSKKmXC1yI41iIW9oQ6lhDf8OfQVOvrc5y5TXNXJqcgeWOLU7WOjOgDihHjciziKVh rsks5R3jDC4P2ald9t9RkRRuF5kEMYWXO259VGOz/ImBk854tsiPv9uvvyj8NGyhcg3E vHew== X-Gm-Message-State: AOAM531+/WO4VbnZc8/dZ6K7KaZqScjB+Oso9C13ZtpJ8qD4FFMpG0Tp m++iygOKKxYLk0E9LnUk2Fl/3g== X-Google-Smtp-Source: ABdhPJyvkbZhNi51MOK3wMCs4cSy44OvLHixOCI7o3MOo/m8861HBGG5Vdka871MDYa0ozQesghZuQ== X-Received: by 2002:a17:90a:450d:: with SMTP id u13mr3848288pjg.148.1603475309279; Fri, 23 Oct 2020 10:48:29 -0700 (PDT) Received: from google.com ([2620:15c:201:2:f693:9fff:fef4:1b6d]) by smtp.gmail.com with ESMTPSA id w6sm2555511pgw.28.2020.10.23.10.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 10:48:28 -0700 (PDT) Date: Fri, 23 Oct 2020 10:48:22 -0700 From: Sami Tolvanen To: Peter Zijlstra Subject: Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps Message-ID: <20201023174822.GA2696347@google.com> References: <20201015102216.GB2611@hirez.programming.kicks-ass.net> <20201015203942.f3kwcohcwwa6lagd@treble> <20201020185217.ilg6w5l7ujau2246@treble> <20201021085606.GZ2628@hirez.programming.kicks-ass.net> <20201021093213.GV2651@hirez.programming.kicks-ass.net> <20201021212747.ofk74lugt4hhjdzg@treble> <20201022072553.GN2628@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201022072553.GN2628@hirez.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201023_134831_766405_2BB06AAD X-CRM114-Status: GOOD ( 16.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Kees Cook , "Paul E. McKenney" , Jann Horn , linux-pci@vger.kernel.org, Greg Kroah-Hartman , Masahiro Yamada , the arch/x86 maintainers , Nick Desaulniers , kernel list , Steven Rostedt , linux-kbuild , clang-built-linux , Josh Poimboeuf , Kernel Hardening , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 22, 2020 at 09:25:53AM +0200, Peter Zijlstra wrote: > On Wed, Oct 21, 2020 at 04:27:47PM -0500, Josh Poimboeuf wrote: > > On Wed, Oct 21, 2020 at 11:32:13AM +0200, Peter Zijlstra wrote: > > > On Wed, Oct 21, 2020 at 10:56:06AM +0200, Peter Zijlstra wrote: > > > > > > > I do not see these in particular, although I do see a lot of: > > > > > > > > "sibling call from callable instruction with modified stack frame" > > > > > > defconfig-build/vmlinux.o: warning: objtool: msr_write()+0x10a: sibling call from callable instruction with modified stack frame > > > defconfig-build/vmlinux.o: warning: objtool: msr_write()+0x99: (branch) > > > defconfig-build/vmlinux.o: warning: objtool: msr_write()+0x3e: (branch) > > > defconfig-build/vmlinux.o: warning: objtool: msr_write()+0x0: <=== (sym) > > > > > > $ nm defconfig-build/vmlinux.o | grep msr_write > > > 0000000000043250 t msr_write > > > 00000000004289c0 T msr_write > > > 0000000000003056 t msr_write.cold > > > > > > Below 'fixes' it. So this is also caused by duplicate symbols. > > > > There's a new linker flag for renaming duplicates: > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=26391 > > > > But I guess that doesn't help us now. > > Well, depends a bit if clang can do it; we only need this for LTO builds > for now. LLD doesn't seem to support -z unique-symbol. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel