From: Johan Hovold <johan@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Felipe Balbi <balbi@kernel.org>,
Thomas Winischhofer <thomas@winischhofer.net>,
Mathias Nyman <mathias.nyman@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Johan Hovold <johan@kernel.org>,
linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Valentina Manea <valentina.manea.m@gmail.com>,
Duncan Sands <duncan.sands@free.fr>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
Alan Stern <stern@rowland.harvard.edu>,
linux-omap@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [patch V2 03/13] USB: serial: keyspan_pda: Consolidate room query
Date: Sun, 25 Oct 2020 18:05:45 +0100 [thread overview]
Message-ID: <20201025170545.GS26280@localhost> (raw)
In-Reply-To: <20201019101109.903651690@linutronix.de>
On Mon, Oct 19, 2020 at 12:06:32PM +0200, Thomas Gleixner wrote:
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Having two copies of the same code doesn't make the code more readable and
> allocating a buffer of 1 byte for a synchronous operation is a pointless
> exercise.
As Alan pointed out, this buffer is in fact required and not pointless
at all even if reallocating it may be suboptimal.
Note however that there are several further allocations done by
usb_control_msg() for each control request.
> Allocate a byte buffer at init which can be used instead. The buffer is
> only used in open() and tty->write(). Console writes are not calling into
> the query. open() obviously happens before write() and the writes are
> serialized by bit 0 of port->write_urbs_free which protects also the
> transaction itself.
As I mentioned in my comments to the previous patch, I've rewritten the
driver so that is no longer does this query in the write path. I kept
the buffer allocation for now though in case you want to rework this one
top.
Johan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-25 17:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 10:06 [patch V2 00/13] USB: Cleanup in_interupt/in_irq/in_atomic() usage Thomas Gleixner
2020-10-19 10:06 ` [patch V2 01/13] USB: sisusbvga: Make console support depend on BROKEN Thomas Gleixner
2020-10-19 10:06 ` [patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage Thomas Gleixner
2020-10-25 16:56 ` Johan Hovold
2020-10-26 12:47 ` Sebastian Andrzej Siewior
2020-10-27 8:16 ` Johan Hovold
2020-10-19 10:06 ` [patch V2 03/13] USB: serial: keyspan_pda: Consolidate room query Thomas Gleixner
2020-10-25 17:05 ` Johan Hovold [this message]
2020-10-19 10:06 ` [patch V2 04/13] USB: serial: digi_acceleport: Remove in_interrupt() usage Thomas Gleixner
2020-10-25 17:16 ` Johan Hovold
2020-10-26 14:03 ` [PATCH v3 04/13 ] " Sebastian Andrzej Siewior
2020-10-27 8:26 ` Johan Hovold
2020-10-19 10:06 ` [patch V2 05/13] usb: xhci: Remove in_interrupt() checks Thomas Gleixner
2020-10-19 10:06 ` [patch V2 06/13] usb: host: isp1362: Replace in_interrupt() usage Thomas Gleixner
2020-10-28 11:27 ` Greg Kroah-Hartman
2020-10-19 10:06 ` [patch V2 07/13] usbip: Remove in_interrupt() check Thomas Gleixner
2020-10-19 10:06 ` [patch V2 08/13] usb: hosts: Remove in_interrupt() from comments Thomas Gleixner
2020-10-19 16:28 ` Alan Stern
2020-10-19 10:06 ` [patch V2 09/13] USB: host: ehci-pmcmsp: Cleanup usb_hcd_msp_remove() Thomas Gleixner
2020-10-19 16:28 ` Alan Stern
2020-10-19 10:06 ` [patch V2 10/13] usb: gadget: pxa27x_udc: Replace in_interrupt() usage in comments Thomas Gleixner
2020-10-19 10:06 ` [patch V2 11/13] usb: gadget: udc: Remove in_interrupt()/in_irq() from comments Thomas Gleixner
2020-10-19 16:28 ` Alan Stern
2020-10-19 10:06 ` [patch V2 12/13] usb: core: Replace in_interrupt() in comments Thomas Gleixner
2020-10-19 16:28 ` Alan Stern
2020-10-19 10:06 ` [patch V2 13/13] usb: atm: Replace in_interrupt() usage in comment Thomas Gleixner
2020-10-19 10:28 ` Duncan Sands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201025170545.GS26280@localhost \
--to=johan@kernel.org \
--cc=a.darwish@linutronix.de \
--cc=balbi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=duncan.sands@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=thomas@winischhofer.net \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).