From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3A3C388F7 for ; Wed, 28 Oct 2020 22:09:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D03F246C5 for ; Wed, 28 Oct 2020 22:09:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3BRyJu8Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D03F246C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ji27BIZwDKFhbiOKgQZL3bKXv4O0VVkYeBQagwrZzO0=; b=3BRyJu8Yk0rF/ZTU9OA5xVyTW M1oC9Ops7VYAwSx3ZiHyhFc9zPMmoTRLvEfXgI+MEJ3pGg3kNOJuCc/95gtqhDQayUoCHD2UD3fIB rDXiOG975pahG/LwhjtyqpyGomsyaSDH5ZfWSxNdqKA2WFMHbiWCoKmM2yr4nXrhWNhBQ78pMEU1w 78vqQNQWS7a0ua7wcbvAept8kSB01kzQ/OyKs2/mWvKDgXkwZRxmSdHLRKrcUbLZ51P2L/eSR8JtV XWx3g4GUUpwr7ON+Mq6VSWo86AoMKsD4kM4SCGUd20z0fmEHz8CwYFYGvn/C8Czdok2r22oaccO55 hdq55HQ8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXtbZ-0004EL-7o; Wed, 28 Oct 2020 22:07:41 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXtbV-0004Dk-Sn for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 22:07:38 +0000 Received: by mail-ej1-f68.google.com with SMTP id j24so1032528ejc.11 for ; Wed, 28 Oct 2020 15:07:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bZlCZTDwAJNro79TS3InJDAfis8jNWbj3KB0SY/Cc4k=; b=TeiC6e2I0NqbZ4XpBV4glKxWJW87hnPJPpC9WmKgxYeY4D/WjpGqLf84J93JiAfFcR jQGDHvmjur5pNVE0gcEcvql75hgbyBYl7af5VUH4lNGaGWoLJsmUeGiu0L0/kzAYchA2 JzLG88vYlJ7OS4dYL+QdH3cS54EPqMmC5cdqd9OTIbQVvoJVSiXz4rSmPdupHz9lgaaU fsoGAnS75STYN/wvj+yfSEbkiU1RT3qL/A20ehti3Mzao2blEZ1BGv6nztkCX5yF9TEe +xcvbLbuJ/UAaJvpvon+AY7/sw08Inc+OI1VjHaPUtIJg3lSPVL1Wjcjyma9CIxeWaja ctgQ== X-Gm-Message-State: AOAM533CSmr6MDFm/POGaRRtiw7OzSV7byDpik30sqnBQcC/Wc+7bxb3 7OfIs2nVMFX6hreQ4PBMKlw= X-Google-Smtp-Source: ABdhPJyRmpfag6RIm2++FBM/0keuZbgnjwCIrwJuWHSQK3lNqf0rJbKI08iYVMOyjfncGqQDAZyWLA== X-Received: by 2002:a17:906:bc91:: with SMTP id lv17mr1181717ejb.249.1603922856842; Wed, 28 Oct 2020 15:07:36 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id i14sm435620ejp.2.2020.10.28.15.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 15:07:35 -0700 (PDT) Date: Wed, 28 Oct 2020 23:07:33 +0100 From: Krzysztof Kozlowski To: Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] clk: samsung: exynos-clkout: convert to module driver Message-ID: <20201028220733.GB271157@kozik-lap> References: <20201001165646.32279-1-krzk@kernel.org> <20201001165646.32279-3-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201001165646.32279-3-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_180737_978452_CE869086 X-CRM114-Status: GOOD ( 21.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 01, 2020 at 06:56:46PM +0200, Krzysztof Kozlowski wrote: > The Exynos clkout driver depends on board input clock (typically XXTI or > XUSBXTI), however on Exynos4 boards these clocks were modeled as part of > SoC clocks (Exynos4 clocks driver). Obviously this is not proper, but > correcting it would break DT backward compatibility. > > Both drivers - clkout and Exynos4 clocks - register the clock providers > with CLK_OF_DECLARE/OF_DECLARE_1 so their order is fragile (in the > Makefile clkout is behind Exynos4 clock). It will work only if the > Exynos4 clock driver comes up before clkout. > > A change in DTS adding input clock reference to Exynos4 clocks input > PLL, see reverted commit eaf2d2f6895d ("ARM: dts: exynos: add input > clock to CMU in Exynos4412 Odroid"), caused probe reorder: the clkout > appeared before Exynos4 clock provider. Since clkout depends on Exynos4 > clocks and does not support deferred probe, this did not work and caused > later failure of usb3503 USB hub probe which needs clkout: > > [ 5.007442] usb3503 0-0008: unable to request refclk (-517) > > The Exynos clkout driver is not a critical/core clock so there is > actually no problem in instantiating it later, as a regular module. > This removes specific probe ordering and adds support for probe > deferral. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/samsung/clk-exynos-clkout.c | 198 +++++++++++++++++------- > 1 file changed, 141 insertions(+), 57 deletions(-) Applied (with fixes pointed out by Sylwester). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel