From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F79C56202 for ; Wed, 18 Nov 2020 10:43:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A4DD22266 for ; Wed, 18 Nov 2020 10:43:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PYlBJxz2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A4DD22266 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n2U+6gNnBexGc014LvfnEp8r6xmruKvZ5TzbqQb3Edg=; b=PYlBJxz23A7hsw/3RnioyZhvI PDxvwt02Xq32uCSbVNOYPP/lBqHJbpe4JM2v+lTSW3mGQm8vWiezm5rcLEnzLixsttgXPouqhC+mx Fqt5lscdqUE5srwBKS8Rrkys6zjwWC7xEPz+oczvl8JaiRMnAdLPgN64ZKZdaX/FBjyHuZxHjI0C5 QZ9hPhzAukZrxAND3Cp/agQy4Txu+C1r3eGEEerBSxk1He2hWDdxWCtrnCTOgmibEF1C/QmRLNK/W 4J4jCYhBbJUXbc1dzZsYoHQc/y3kdA7ud1Zspx0/iEOVk+fTE2MDdxXydXY4AgDhTwgDueWixz73z t4JTzHPsg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfKv2-0004l5-KJ; Wed, 18 Nov 2020 10:42:32 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfKuz-0004kd-WA for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 10:42:30 +0000 Received: by mail-ej1-f65.google.com with SMTP id i19so2039003ejx.9 for ; Wed, 18 Nov 2020 02:42:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RSpyNr9ImM7m91CBLdyW5FUGxR8gG95LO/PYe+GLcPM=; b=GmLbPiklQvnPEgrnfkc+Go1ZMPDUqH2g/46AgX5f9Wv4otzs9TvNiWgRNGuFkaqC70 HAg4XGo8ZhwurWIpPakI3X2THDIURf80Z/ai2sZPimgleAWxoFV2EyAwmOIxZ/SGtMLd n2TofK5ZjlJ6abEVqBaTzn0YwN0oUlchz9aRy0AN24ZxTXrFFuKKQcydQjQ5n4NysRrl hQSIrBZr/Uc++4XvngJ+ZHLtOZqD/6jFBs2Bwvd5aeEFcYs1tYZUg1jSKMewkMlcQoZe l6CPCVeAC1kGjh6imBxPYoWUf6rTEe3c2nvWAcUAu1IU81mjghQORcAI+W++mq9M74gk TihA== X-Gm-Message-State: AOAM530ySAS6j0peBJrg1AliiSKjsd0v5qdg7Dw9gth6DQs3HfUHLFc/ uZq6B/BDHvB8kQkHg4Tz9Lo= X-Google-Smtp-Source: ABdhPJx7/ODY/gVEoRqL5kGJlrG8wd017WuRtscj4IzeoSwSxUVO6td2HgkiLYpTN9rcgeuRjg3bBw== X-Received: by 2002:a17:906:1408:: with SMTP id p8mr22992702ejc.548.1605696148906; Wed, 18 Nov 2020 02:42:28 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id f13sm12601074ejf.42.2020.11.18.02.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 02:42:28 -0800 (PST) Date: Wed, 18 Nov 2020 11:42:26 +0100 From: Krzysztof Kozlowski To: Alice Guo Subject: Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver Message-ID: <20201118104226.GA23766@kozik-lap> References: <20201113110409.13546-1-alice.guo@nxp.com> <20201113110409.13546-4-alice.guo@nxp.com> <20201114164128.GD14989@kozik-lap> <20201116161338.GB25108@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_054230_145286_E7EF7DD5 X-CRM114-Status: GOOD ( 17.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Peng Fan , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 18, 2020 at 10:28:47AM +0000, Alice Guo wrote: > > > If it is properly explained and there is no other way then yes, you could. Here, for > > old DTBs, I would prefer to use > > of_platform_device_create() and bind to "soc" node (child of root). > > This way you would always have device and exactly one entry point for the > > probe. > > > > static struct platform_driver imx8_soc_init_driver = { > .probe = imx8_soc_init_probe, > .driver = { > .name = "soc@0", > }, > }; > Can I use "soc@0" to match this driver? It will not use of_platform_device_create(). It will use of_find_property() to determine whether > and nvmem-cells can be used. If there is no nvmem-cells, it will use the old way, which supports old DTBS. There is no need to add new > compatible. No, the soc@0 is not a proper name for the driver. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel