On Wed, Nov 11, 2020 at 04:05:20PM +0800, Jiaxin Yu wrote: > This reverts commit 1afc60e00de3abbb6c559da409c5c1bb8c1d98ec. > > Signed-off-by: Jiaxin Yu > --- > https://mailman.alsa-project.org/pipermail/alsa-devel/2020-November/176873.html > These dependency are continuing to upstream, I will revert this patch first. > After the dependencies are merged, I will send 'mt8192-afe-pcm.yaml' again. This description of what the commit does should be part of the changelog, reverts are just normal patches and should have changelogs describing what they do just like other changes do. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.