From: Nishanth Menon <nm@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Device Tree Mailing List <devicetree@vger.kernel.org>,
Lokesh Vutla <lokeshvutla@ti.com>,
Andre Przywara <andre.przywara@arm.com>,
Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, Faiz Abbas <faiz_abbas@ti.com>,
Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
Date: Thu, 19 Nov 2020 07:28:29 -0600 [thread overview]
Message-ID: <20201119132829.sr435jf6s4275q4i@boxlike> (raw)
In-Reply-To: <18e41dba-a3dd-308a-605e-63b76ca638e5@ti.com>
Punting over to Rob and DT team's wisdom..
On 13:17-20201119, Grygorii Strashko wrote:
>
>
> On 18/11/2020 17:12, Nishanth Menon wrote:
> > On 13:38-20201118, Grygorii Strashko wrote:
> > > Hi Rob,
> > >
> > > On 17/11/2020 18:19, Sekhar Nori wrote:
> > > > With dtc 1.6.0, building TI device-tree files with W=2 results in warnings
> > > > like below for all interrupt controllers.
> > > >
> > > > /bus@100000/bus@30000000/interrupt-controller1: Missing #address-cells in interrupt provider
> > > >
> > > > Fix these by adding #address-cells = <0>; for all interrupt controllers in
> > > > TI device-tree files. Any other #address-cells value is really only needed
> > > > if interrupt-map property is being used (which is not the case for existing
> > > > TI device-tree files)
> > > >
> > > > Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> > > > ---
> > > > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 +++++
> > > > arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 ++
> > > > arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 +
> > > > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 3 +++
> > > > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 1 +
> > > > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 1 +
> > > > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 11 +++++++++++
> > > > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 3 +++
> > > > 8 files changed, 27 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > > > index aa8725db0187..55aaa1404d7d 100644
> > > > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > > > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > > > @@ -440,6 +440,7 @@
> > > > interrupt-controller;
> > > > interrupt-parent = <&gic500>;
> > > > #interrupt-cells = <1>;
> > > > + #address-cells = <0>;
> > > Does it really required or mandatory to have #address-cells = <0>; defined for interrupt-controller DT nodes which
> > > do not have child nodes and no "interrupt-map"?
> >
> > Just to help clarify (I could be mistaken as well): is'nt the
> > interrupt map for user interrupt map nodes that refer to this
> > interrupt controller node to state they dont need a parent address
> > specifier - so are we claiming none of the users will have an
> > interrupt-map (now and never in the future as well) - we we might want
> > to explain why we think that is the case, and if we are expecting dtc
> > to deduce that (if so how?)?
> >
>
> The main reason I commented - is hope to get some clarification from DT maintainers.
> 90% of interrupt-controller nodes do not have #address-cells and I never seen in in GPIO nodes
> (most often is present in PCI and GIC nodes).
> and nobody seems fixing it. So, if we are going to move this direction it's reasonable to get clarification to be sure.
>
> And there is no "never" here - #address-cells always can be added if really required.
OK - as a GPIO node, but as an interrupt-controller node, I was
looking at [1] and wondering if that was the precedence.
Yes, will be good to get direction from the DT maintainers on this
topic.
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/open-pic.txt
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-19 13:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 16:19 [PATCH v2 0/4] arm64: dts: ti: J7200 GPIO support and warning fixes Sekhar Nori
2020-11-17 16:19 ` [PATCH v2 1/4] arm64: dts: ti: k3: squelch warning about lack of #interrupt-cells Sekhar Nori
2020-11-17 16:19 ` [PATCH v2 2/4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller Sekhar Nori
2020-11-18 11:38 ` Grygorii Strashko
2020-11-18 15:12 ` Nishanth Menon
2020-11-19 11:17 ` Grygorii Strashko
2020-11-19 13:28 ` Nishanth Menon [this message]
2020-11-23 4:15 ` Sekhar Nori
2020-11-24 1:21 ` Nishanth Menon
2020-11-24 4:16 ` Sekhar Nori
2020-11-27 14:23 ` Nishanth Menon
2021-01-08 14:05 ` Lokesh Vutla
2021-01-26 0:01 ` Rob Herring
2021-01-26 16:38 ` Andre Przywara
2021-03-11 22:01 ` Nishanth Menon
2020-11-17 16:19 ` [PATCH v2 3/4] arm64: dts: ti: k3-j7200: Add gpio nodes Sekhar Nori
2020-11-17 16:19 ` [PATCH v2 4/4] arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio modules Sekhar Nori
2020-11-19 11:20 ` [PATCH v2 0/4] arm64: dts: ti: J7200 GPIO support and warning fixes Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119132829.sr435jf6s4275q4i@boxlike \
--to=nm@ti.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).