From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DC7C56201 for ; Thu, 19 Nov 2020 15:30:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C0DF24698 for ; Thu, 19 Nov 2020 15:30:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K1y4UxS8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fR5aalcE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C0DF24698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ae5jI+/epsNhymnPyX/+StZ9HWlr0Blqm2507cUJS7I=; b=K1y4UxS879O1dOkfqFy7dTaErO NdDyiwFiNXQ+R5uAEVew4vCaXxS56Gl/y6Sth0K/kDb+65zO/2ktetsaro2PmB7ExJzvmRsEfVKgs HG/JxdHmaeIOvcE7SjxvDHEc1HLdYkv18V5Kxi+sOoJN4nP+cL/TEZjyJl/6fX5Ox8kmYShTlSGtQ mrkdc+9hQp/mSaJ9qURYelVHb+mosfxcXDIpj4WowOeHC4pY+bWsL1t/mtS6siJaBg5ZEhpC7ubtZ 0sDtFAFj5ZhNLhAtUpbgEIynaiwSVadecjAcjr2fBRZk0nZp4fDmWUlgDwmTmLONTuhb4S/6IuqwD wfdBnBcA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kflsp-00069u-Iy; Thu, 19 Nov 2020 15:30:04 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfloo-0004Qw-3R for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 15:26:18 +0000 Received: by mail-pf1-x444.google.com with SMTP id 131so4801642pfb.9 for ; Thu, 19 Nov 2020 07:25:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=c1el8lOaBG1H8A2PDl1EJfoVhIMJxa/97iv9OMwi/xg=; b=fR5aalcEDPdTroJHt5vbfCXRDUzx7+jHQ+kYCjt5Te3ne3xiuZRTMEOFsm2P89C84O omXKi0xeDipru9gLi3T8fon5JUWoNEEJeHdMEOLpiMDLwMAGNq8J94YXrjDdsZQVN9T/ h7Z1r8MXjGGUztw56KgL9M2vPGAfZNU/HJJBzNBm5+Qf1Ye0ZwMmLM0F0dsxPCl03ty8 sBhKtvG9/9y5MT2mDuWt0NlUAZtniZdTijbKy/PFpCWQRU531CmeIZ62ZUeX3DPnYgsc 07VbDQFrnaRxsNm9EoRH1tzZoo0ZnhGZO/luM5QDXlMcFU4EQ6bervHSucI6jK8hgJwH ImBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=c1el8lOaBG1H8A2PDl1EJfoVhIMJxa/97iv9OMwi/xg=; b=BeqhKNp/6U6kVqG3U6iq5JLS+qAoNsbszqA7stbdXKjGe65ifnTo/XsBUw3s8P+LT2 boH/E3DJh1IJl5Odx+9s6Qhceh8Vo2/IKXb2VRyqXLwl2iZ4nqKedgsI/8q4VDZMlbTt ktIRx01vGpE9A/XE6OfMbcqP9v/en23DPrREenBTO7NXvRd05gMTGz5Fsr9+rF/1fhzW YK88uWVipFBNmw4gi/YZ625yegLH1g4Q6mvL6IqlUBCzGTZaikriDhM0txK7zjkN3OYY 9JgDgvyddx/ntbXIL292HYqw0SYisu4OaAjrYRZa5kn1Wve7ndQiwo2UZU2OPs+fxLkq Cg6w== X-Gm-Message-State: AOAM532LbVEFZjCD9syMS4CnlCEEGavgzPS1OxUUvRJJk1orlxpc7ZaV qmMYf6q5dWrcjl+ZMdFAKMMCag== X-Google-Smtp-Source: ABdhPJw1TACkNQvNY9Ip1txqkNK/XfgN9SiQgea9i7dkSONwKzAwcKk1aoKbyMvXbBh43rQO5gZYWQ== X-Received: by 2002:aa7:8e87:0:b029:18b:cfd8:261c with SMTP id a7-20020aa78e870000b029018bcfd8261cmr9524494pfr.61.1605799550731; Thu, 19 Nov 2020 07:25:50 -0800 (PST) Received: from localhost ([45.137.216.7]) by smtp.gmail.com with ESMTPSA id e22sm6993410pjh.45.2020.11.19.07.25.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Nov 2020 07:25:50 -0800 (PST) From: Leo Yan To: Arnaldo Carvalho de Melo , Andre Przywara , Dave Martin , James Clark , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Al Grant , Wei Li , John Garry , Will Deacon , Mathieu Poirier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v9 14/16] perf arm-spe: Add more sub classes for operation packet Date: Thu, 19 Nov 2020 23:24:39 +0800 Message-Id: <20201119152441.6972-15-leo.yan@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201119152441.6972-1-leo.yan@linaro.org> References: <20201119152441.6972-1-leo.yan@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_102554_212419_C86AC2EB X-CRM114-Status: GOOD ( 16.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Yan MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org For the operation type packet payload with load/store class, it misses to support these sub classes: - A load/store targeting the general-purpose registers; - A load/store targeting unspecified registers; - The ARMv8.4 nested virtualisation extension can redirect system register accesses to a memory page controlled by the hypervisor. The SPE profiling feature in newer implementations can tag those memory accesses accordingly. Add the bit pattern describing load/store sub classes, so that the perf tool can decode it properly. Inspired by Andre Przywara, refined the commit log and code for more clear description. Co-developed-by: Andre Przywara Signed-off-by: Leo Yan Reviewed-by: Andre Przywara --- .../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c index 1d1354a0eef4..84d661aab54f 100644 --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c @@ -343,9 +343,23 @@ static int arm_spe_pkt_desc_op_type(const struct arm_spe_pkt *packet, arm_spe_pkt_out_string(&err, &buf, &buf_len, " EXCL"); if (payload & SPE_OP_PKT_AR) arm_spe_pkt_out_string(&err, &buf, &buf_len, " AR"); - } else if (SPE_OP_PKT_LDST_SUBCLASS_GET(payload) == - SPE_OP_PKT_LDST_SUBCLASS_SIMD_FP) { + } + + switch (SPE_OP_PKT_LDST_SUBCLASS_GET(payload)) { + case SPE_OP_PKT_LDST_SUBCLASS_SIMD_FP: arm_spe_pkt_out_string(&err, &buf, &buf_len, " SIMD-FP"); + break; + case SPE_OP_PKT_LDST_SUBCLASS_GP_REG: + arm_spe_pkt_out_string(&err, &buf, &buf_len, " GP-REG"); + break; + case SPE_OP_PKT_LDST_SUBCLASS_UNSPEC_REG: + arm_spe_pkt_out_string(&err, &buf, &buf_len, " UNSPEC-REG"); + break; + case SPE_OP_PKT_LDST_SUBCLASS_NV_SYSREG: + arm_spe_pkt_out_string(&err, &buf, &buf_len, " NV-SYSREG"); + break; + default: + break; } break; case SPE_OP_PKT_HDR_CLASS_BR_ERET: -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel