From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 028EDC56201 for ; Fri, 20 Nov 2020 18:30:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60EB924137 for ; Fri, 20 Nov 2020 18:30:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rn5BD6LU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bweU88sR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60EB924137 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+0Mr/1Tb8un/1Ey/D5/KnPQ9y5l+lDAM2Vy1IDATJZs=; b=Rn5BD6LUEgLrv3rXFV/uN1GDg 52iREpZlNphCd+ZkHTzdb7h2n45vxDh4vFU/zzuGTBsRQX4M9NJSefUkvo9m1wNJJzC/2no4pGMZr kelNwxjDSNB/dixUyuzM8QF9Q9aj4/ZYVqm891e4ktgGxb/EuqStv9M23DfcSQWnOIO6ahz1jClsq 0kq3F087q40zSsjFKpbxQtjuxD3lf4nNHC+KhUxYc983fRfEtaeYykbrNmsIu5firo+N9cchqXvb3 EVF0Di9RsfaJizXuerE6PR5ih6xt0krFcChnnw4G0vXxDMV+v2xo8byHHadAU7oxrT9eM+bvOLN3L itopBn6DQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgBAm-0001TG-0K; Fri, 20 Nov 2020 18:30:16 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgBAh-0001SB-U0 for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 18:30:13 +0000 Received: by mail-wr1-x441.google.com with SMTP id r17so11052708wrw.1 for ; Fri, 20 Nov 2020 10:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mPy/DPnzyZVR3Eu14UUOGC4ulr/TKIUgB8++zcFhoUo=; b=bweU88sR2cEcppOz+Hv+wBWZh2bk2PAJEvw1EnjeRSkaedTEEG92RDJ06DQs19NO8/ 6mxzsQNAwxcykltKQJoHS867uosEJ1FcX/Q21HAejHR9tbfnVY4iV/A1bMnhWVni9DyQ b+/glW6R0o2fyZT7Wh/YL+//jiLuNyGUU0FeU2j+68o9/69aC9im3cxBsRJ1GTAXgHw8 5pBWKeWtpN3TAZeHSyAVPn1kX6/1mgdopN7pfTbtvjFNFhM57D0UzTomB2+w0WsD7pXd HiOvRK+oX873EcDljXl4GBCktEbdaiVs03fpTqXrk91iTWS1GPr1ZGCvRmunXTzrs+Fn 0/cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=mPy/DPnzyZVR3Eu14UUOGC4ulr/TKIUgB8++zcFhoUo=; b=G7ot/z2GUnjFy/IclXl/7v/FOD7LcatzsmrMei+/3abHjUGmq8cHarcypaYzv4a0B3 vTUthCy5ZY2Ge1gCeRCiu7mqeWzbSc507MJZ5tbR67YtQSNKnPXvUkXcOTa/znnoTzKU TYdBdOGSWJi89uBplLzZX7PUls8OuUZtvU1orfDWMT1mNHnPJ3GfLSrcWFApPptSf4ZA ew7EWRFOuA/Ep6KUdiA1pgtTJGgBiKkv/Vfx/SaI7kZ0qJ7Hqlwtt0Tz23jk4bJAzRrB gv+wR3CLtFxrvVefJHC5XDPv16Ns+FToOOucV9sP2piAlHq85uyFunnx2c1vaERBfF+K 79zA== X-Gm-Message-State: AOAM530d/grVVujNmFwfKjE/ugFlj7w0SNE2AThesC+x541VnqOpcynH 8dgCnyzvvFEKhZ9b3F+FBgQ= X-Google-Smtp-Source: ABdhPJxtYw19EOhh8JbZ6iCu5arYHsY9ah90+IVT1WELOs9dC4N45TDNCjs+kQuBArMQRQN0tkR+Ug== X-Received: by 2002:a05:6000:347:: with SMTP id e7mr17060337wre.35.1605897010715; Fri, 20 Nov 2020 10:30:10 -0800 (PST) Received: from eldamar (80-218-24-251.dclient.hispeed.ch. [80.218.24.251]) by smtp.gmail.com with ESMTPSA id n10sm6331537wrx.9.2020.11.20.10.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 10:30:09 -0800 (PST) Date: Fri, 20 Nov 2020 19:30:08 +0100 From: Salvatore Bonaccorso To: Andrey Zhizhikin Subject: Re: [PATCH] Revert "perf cs-etm: Move definition of 'traceid_list' global variable from header file" Message-ID: <20201120183008.GA518373@eldamar.lan> References: <20201120073909.357536-1-carnil@debian.org> <20201120133400.GA405401@eldamar.lan> <20201120155317.GA502412@eldamar.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_133012_084982_740FAF2D X-CRM114-Status: GOOD ( 36.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki Poulouse , Alexander Shishkin , Greg Kroah-Hartman , stable@vger.kernel.org, Tor Jeremiassen , Arnaldo Carvalho de Melo , Peter Zijlstra , Guenter Roeck , Leo Yan , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrey, On Fri, Nov 20, 2020 at 05:31:59PM +0100, Andrey Zhizhikin wrote: > Hello Salvatore, > > On Fri, Nov 20, 2020 at 4:53 PM Salvatore Bonaccorso wrote: > > > > Hi Andrey, > > > > On Fri, Nov 20, 2020 at 03:29:39PM +0100, Andrey Zhizhikin wrote: > > > Hello Salvatore, > > > > > > On Fri, Nov 20, 2020 at 2:34 PM Salvatore Bonaccorso wrote: > > > > > > > > Hi Andrey, > > > > > > > > On Fri, Nov 20, 2020 at 10:54:22AM +0100, Andrey Zhizhikin wrote: > > > > > On Fri, Nov 20, 2020 at 8:39 AM Salvatore Bonaccorso wrote: > > > > > > > > > > > > This reverts commit 168200b6d6ea0cb5765943ec5da5b8149701f36a upstream. > > > > > > (but only from 4.19.y) > > > > > > > > > > This revert would fail the build of 4.19.y with gcc10, I believe the > > > > > original commit was introduced to address exactly this case. If this > > > > > is intended behavior that 4.19.y is not compiled with newer gcc > > > > > versions - then this revert is OK. > > > > > > > > TTBOMK, this would not regress the build for newer gcc (specifically > > > > gcc10) as 4.19.158 is failing perf tool builds there as well (without > > > > the above commit reverted). Just as an example v4.19.y does not have > > > > cff20b3151cc ("perf tests bp_account: Make global variable static") > > > > which is there in v5.6-rc6 to fix build failures with 10.0.1. > > > > > > > > But it did regress builds with older gcc's as for instance used in > > > > Debian buster (gcc 8.3.0) since 4.19.152. > > > > > > > > Do I possibly miss something? If there is a solution to make it build > > > > with newer GCCs and *not* regress previously working GCC versions then > > > > this is surely the best outcome though. > > > > > > I guess (and from what I understand in Leo's reply), porting of > > > 95c6fe970a01 ("perf cs-etm: Change tuple from traceID-CPU# to > > > traceID-metadata") should solve the issue for both older and newer gcc > > > versions. > > > > > > The breakage is now in > > > [tools/perf/util/cs-etm-decoder/cs-etm-decoder.c] file (which uses > > > traceid_list inside). This is solved with the above commit, which > > > concealed traceid_list internally inside [tools/perf/util/cs-etm.c] > > > file and exposed to [tools/perf/util/cs-etm-decoder/cs-etm-decoder.c] > > > via cs_etm__get_cpu() call. > > > > > > Can you try out to port that commit to see if that would solve your > > > regression? > > > > So something like the following will compile as well with the older > > gcc version. > > > > I realize: I mainline the order of the commits was: > > > > 95c6fe970a01 ("perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata") > > 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global variable from header f > > ile") > > > > But to v4.19.y only 168200b6d6ea was backported, and while that was > > done I now realize the comment was also changed including the change > > fom 95c6fe970a01. > > > > Thus the proposed backported patch would drop the change in > > tools/perf/util/cs-etm.c to the comment as this was already done. > > Thecnically currently the comment would be wrong, because it reads: > > > > /* RB tree for quick conversion between traceID and metadata pointers */ > > > > but backport of 95c6fe970a01 is not included. > > > > Would the right thing to do thus be: > > > > - Revert b801d568c7d8 "perf cs-etm: Move definition of 'traceid_list' global variable from header file" > > - Backport 95c6fe970a01 ("perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata") > > - Backport 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global variable from header file") > > Yes, I believe this would be the correct course of action here; this > should cover the regression you've encountered and should ensure that > perf builds on both the "old" and "new" gcc versions. Although perf tools in v4.19.y won't compile with recent GCCs. Greg did already queued up the first part of it, so the revert. I think we can pick the later two commits again up after the v4.19.159 release? Regards, Salvatore _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel