From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87044C56202 for ; Wed, 25 Nov 2020 14:19:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15753206F9 for ; Wed, 25 Nov 2020 14:19:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xFOm+4yO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GXKJWyQQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15753206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bh++omI+vPN+pFZp/CZOvWtj4yoEm0fQVfgxUjF1TfE=; b=xFOm+4yO2tTxLN7YZgXjpmIjM +hsIRgxYnRpyLnGBfNYrgiwWX6EQgbpUWdCAFS2dUxm45JcCcvvweSlC1+T5rDCFUJ2z1IbMpDTrc HMhV8d7Cnw12Z80nuPwRe5VcSp2aRucOXi5Ca8wbaJRK3zfj6+L0GcX8oz7Bkwk56Rw3fhStK6bIP zI8KPj0BvEt9zIVxc497hPgE/8IFSDPpEwQdnTYuYYpoKsEqQgMY6As1ghYrYlgpXLp0oI7F6uihH MPAExliCjCC4MToCDXhA8zoFp0ALInp3Du8xvsyOXFBFY1Q5A09EGhhcbPV/vHYmqBOcSRhNiNVrU Mq5NeyMYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khvcU-0003U7-Nr; Wed, 25 Nov 2020 14:18:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khvcS-0003TF-6E for linux-arm-kernel@lists.infradead.org; Wed, 25 Nov 2020 14:18:05 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11D2B206D9; Wed, 25 Nov 2020 14:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606313883; bh=vfuMr1GX34MA8Nxr+S5nYqXXfoBNK8HjoqQ+R6uEnQQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GXKJWyQQOsMgEyfyWgOmFs34DrkGhYCRSk+D9xBH/UVUFeGyDDhhdYdkTz4khVJs3 fRUpXKRU6thCD4jfUJiZ09uubOFzX3pPOXgN7QQFafmPtdU0BDZaJFclmSWUZVYqmA cRP0YT48Gz3fOHXDh4DHnN9gVOJL3Tuj0ut/0dEc= Date: Wed, 25 Nov 2020 14:17:56 +0000 From: Will Deacon To: Leo Yan Subject: Re: [PATCH v9 00/16] perf arm-spe: Refactor decoding & dumping flow Message-ID: <20201125141755.GB16159@willie-the-truck> References: <20201119152441.6972-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201119152441.6972-1-leo.yan@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201125_091804_603500_E44CAC17 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Al Grant , Mathieu Poirier , Peter Zijlstra , Andre Przywara , John Garry , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Alexander Shishkin , Ingo Molnar , James Clark , Namhyung Kim , Jiri Olsa , Dave Martin , linux-arm-kernel@lists.infradead.org, Wei Li Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 11:24:25PM +0800, Leo Yan wrote: > This is patch set v9 for refactoring Arm SPE trace decoding and dumping. > > According to comments and suggestions from patch set v8, it squashs the > two patches into single one: "perf arm-spe: Refactor printing string to > buffer" and "perf arm-spe: Consolidate arm_spe_pkt_desc()'s return > value". > > In the patch 01/16, it renames the function arm_spe_pkt_snprintf() to > arm_spe_pkt_out_string(), since the function is not the same semantics > with snprintf(), the renaming can avoid confusion. > > This patch set is cleanly applied on the top of perf/core branch > with commit 29396cd573da ("perf expr: Force encapsulation on > expr_id_data"). > > This patch set has been tested on Hisilicon D06 platform with commands > "perf report -D" and "perf script", compared the decoding results > between with this patch set and without this patch set, "diff" tool > shows the result as expected. > > I also manually built the patches for arm/arm64/x86_64 and verfied > every single patch can build successfully. I'm unable to test this, so I'm please that you can! Anyway, it all looks fine from a quick look: Acked-by: Will Deacon so I think Arnaldo can pick this up when he's ready. Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel