linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Salvatore Bonaccorso <carnil@debian.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Andrey Zhizhikin <andrey.z@gmail.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulouse <suzuki.poulose@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	coresight ml <coresight@lists.linaro.org>,
	stable@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Robert Walker <robert.walker@arm.com>,
	Jiri Olsa <jolsa@redhat.com>,
	linux-arm-kernel@lists.infradead.org,
	Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH 1/2] perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata
Date: Thu, 26 Nov 2020 05:52:52 +0100	[thread overview]
Message-ID: <20201126045252.GB20726@lorien.valinor.li> (raw)
In-Reply-To: <20201126013522.GB31690@leoy-ThinkPad-X240s>

Hi Leo,

On Thu, Nov 26, 2020 at 09:35:22AM +0800, Leo Yan wrote:
> On Wed, Nov 25, 2020 at 09:23:23PM +0100, Salvatore Bonaccorso wrote:
> > On Wed, Nov 25, 2020 at 09:12:14PM +0100, Salvatore Bonaccorso wrote:
> > > From: Leo Yan <leo.yan@linaro.org>
> > > 
> > > commit 95c6fe970a0160cb770c5dce9f80311b42d030c0 upstream.
> 
> [...]
> 
> > That's a fallout on my end. Should have said: This is for 4.19
> > specifically to be queued.
> > 
> > Background: in
> > https://lore.kernel.org/stable/20201014135627.GA3698844@kroah.com/
> > 168200b6d6ea0cb5765943ec5da5b8149701f36a was queued up for v4.19.y but
> > the prerequeisite commit was not included and so resulted in build
> > failures with gcc 8.3.0.
> > 
> > The commit was later on reverted but in this thread it was asked to
> > actually make it possible to compile the file as well with more recent
> > gcc versions.
> > 
> > Those two patches to be applied in 4.19.y only pick up a backport of
> > the rerequisite commit 95c6fe970a0160cb770c5dce9f80311b42d030c0 (PATCH
> > 1) followed up by the cherry-pick of
> > 168200b6d6ea0cb5765943ec5da5b8149701f36a again.
> 
> Since the patch 01 is minor tweaked due to context difference, I
> manually compared it with original patch and looks good to me.
> 
> Thank you for the back porting,

Welcome, given I'm unfamiliar with the codebasis for perf the explicit
acknowledgement nothing looks wrong was appreciated.

Regards,
Salvatore

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-26  4:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20  7:39 [PATCH] Revert "perf cs-etm: Move definition of 'traceid_list' global variable from header file" Salvatore Bonaccorso
2020-11-20  8:34 ` Greg Kroah-Hartman
2020-11-20  8:46 ` Patch "Revert "perf cs-etm: Move definition of 'traceid_list' global variable from header file"" has been added to the 4.19-stable tree gregkh
2020-11-20  9:54 ` [PATCH] Revert "perf cs-etm: Move definition of 'traceid_list' global variable from header file" Andrey Zhizhikin
2020-11-20 11:19   ` Leo Yan
2020-11-20 12:15     ` Andrey Zhizhikin
2020-11-20 13:34   ` Salvatore Bonaccorso
2020-11-20 14:29     ` Andrey Zhizhikin
2020-11-20 15:53       ` Salvatore Bonaccorso
2020-11-20 16:31         ` Andrey Zhizhikin
2020-11-20 18:30           ` Salvatore Bonaccorso
2020-11-20 19:29             ` Andrey Zhizhikin
2020-11-22 13:43         ` Leo Yan
2020-11-25 20:12           ` [PATCH 1/2] perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata Salvatore Bonaccorso
2020-11-25 20:12             ` [PATCH 2/2] perf cs-etm: Move definition of 'traceid_list' global variable from header file Salvatore Bonaccorso
2020-11-25 20:23             ` [PATCH 1/2] perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata Salvatore Bonaccorso
2020-11-26  1:35               ` Leo Yan
2020-11-26  4:52                 ` Salvatore Bonaccorso [this message]
     [not found] <20201227092745.447945-1-carnil@debian.org>
2020-12-27  9:27 ` Salvatore Bonaccorso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201126045252.GB20726@lorien.valinor.li \
    --to=carnil@debian.org \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andrey.z@gmail.com \
    --cc=coresight@lists.linaro.org \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=namhyung@kernel.org \
    --cc=robert.walker@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).