From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B53EBC56202 for ; Thu, 26 Nov 2020 11:51:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3085920678 for ; Thu, 26 Nov 2020 11:51:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ErthCqCE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pQty6a3t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3085920678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gxo3WK2cTug6TtA7yBCHwfRs753jM6I9m3bHsAhhXG4=; b=ErthCqCEmcxT0pf+Chq9h7/cq CL498pP7w8BbNN7QVccylOOF4xNOk2/0LbNfD28kUgBIlYCrvcOtZKERkGFQgzo04wQxqtheXbE+Q kCPFdu9hpIBIGdRBiFM3moEgoSv0azsUub9YH4CUkTzHJIKf8z/LOHKzWP+E5PQKv0M9Ce/EXEkdq V8n/PrdpQ8BdJLcLQy4LnY9iAicsymz+KcflVBs+gjsMIwgOaYCLAyAOzI+mav+2TAsz2/I3F4HtQ BGZLT16+5gNFTYeiJROhi46Ahj65SYas1244DTaLM6UUeeuhHJbr3X1GtQUIKLZZYQTlLrKfFJmiX cOtN7VLhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiFmT-0003FN-QH; Thu, 26 Nov 2020 11:49:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiFmN-0003EJ-Ma; Thu, 26 Nov 2020 11:49:40 +0000 Received: from localhost (cpc102334-sgyl38-2-0-cust884.18-2.cable.virginm.net [92.233.91.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 115FB20678; Thu, 26 Nov 2020 11:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606391377; bh=9e4yaA6CcohD3sgKshLtFCqZxBH1iZur10IvEDoTtrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pQty6a3tWyYqJjQviHpFGeRLxcjHF+P3k3KQ3qQlFgdR4tYRM8pK0rIU2CAvfZ/1K TjDnABJYCL2kXRaGxoZqnUxfEwluBH8Y+HQPPEPAyWr+oHFeRNeb9HUV59zGkoR2ju 81uKAzFMy08X5lLFzz5Uo1vuwtvm9Isrj0S2tdNU= Date: Thu, 26 Nov 2020 11:49:12 +0000 From: Mark Brown To: Jim Quinlan Subject: Re: [PATCH v1 2/6] PCI: brcmstb: Add control of EP voltage regulator(s) Message-ID: <20201126114912.GA8506@sirena.org.uk> References: <20201125192424.14440-1-james.quinlan@broadcom.com> <20201125192424.14440-3-james.quinlan@broadcom.com> MIME-Version: 1.0 In-Reply-To: <20201125192424.14440-3-james.quinlan@broadcom.com> X-Cookie: Serving suggestion. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_064939_936269_D2FAEA36 X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Liam Girdwood , open list , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , Nicolas Saenz Julienne Content-Type: multipart/mixed; boundary="===============5982838691748147044==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5982838691748147044== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6" Content-Disposition: inline --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 25, 2020 at 02:24:19PM -0500, Jim Quinlan wrote: > + for (i = 0; i < PCIE_REGULATORS_MAX; i++) { > + ep_reg = devm_regulator_get_optional(dev, ep_regulator_names[i]); > + if (IS_ERR(ep_reg)) { Does PCI allow supplies to be physically absent? If not then the driver shouldn't be using regulator_get_optional() and much of the code here can be deleted. > +static void brcm_set_regulators(struct brcm_pcie *pcie, bool on) > +{ This is open coding the regulator bulk APIs. --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+/ljcACgkQJNaLcl1U h9BIAAf/QqjxCH8S51N4QuGM0DaR1GewyFK4OXnt3/H++qbgzoNsOF8XLIKc/tqg tYD1zmUpQYD44YaQ9HKIdsXUZ8LYfxL1OFgzKhi3Af6OWsG5Fp2A5VxoeWNTFAJQ QtlbGx0eBXRurktsqrwTPTbpygjTdYTOLbmF1Mn4jKvAk8JeU6/i6UG9ozlCd0VK qIrPLyLNkzx74vaZZUGBM5nZoiR2g9MgaQo3vSXIHJsms5yITf2eU1B43hGOU0+o HDwViSGHWGrCXBV55A2XbPWy3FzucuOiF36EeItx8Z/H6s5UVAixsUgqlibkYFeY LV6yhHjuY7o9jDuZj2WUVSL8ZdUHJw== =ub0o -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6-- --===============5982838691748147044== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5982838691748147044==--