linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
	kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: linux-next 20201126 - build error on arm allmodconfig
Date: Thu, 26 Nov 2020 14:14:29 +0000	[thread overview]
Message-ID: <20201126141429.GL1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <24105.1606397102@turing-police>

On Thu, Nov 26, 2020 at 08:25:02AM -0500, Valdis Klētnieks wrote:
> Seems something is giving it indigestion regarding asmlinkage...
> 
>   CC      arch/arm/mm/kasan_init.o
> In file included from ./include/linux/kasan.h:15,
>                  from arch/arm/mm/kasan_init.c:11:
> ./arch/arm/include/asm/kasan.h:26:11: error: expected ';' before 'void'
>  asmlinkage void kasan_early_init(void);
>            ^~~~~
>            ;
> make[2]: *** [scripts/Makefile.build:283: arch/arm/mm/kasan_init.o] Error 1
> make[1]: *** [scripts/Makefile.build:500: arch/arm/mm] Error 2
> make: *** [Makefile:1803: arch/arm] Error 2
> 
> Git bisect points at:
> 
> commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> Author: Andrey Konovalov <andreyknvl@google.com>
> Date:   Tue Nov 24 16:45:08 2020 +1100
> 
>     kasan: shadow declarations only for software modes
> 
> Looks like it's this chunk:
> 
> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index 59538e795df4..26f2ab92e7ca 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -11,7 +11,6 @@ struct task_struct;
> 
>  #ifdef CONFIG_KASAN
> 
> -#include <linux/pgtable.h>
>  #include <asm/kasan.h>
> 
> Testing shows putting that #include back in makes it compile correctly,
> but it's not obvious why putting that back makes 'asmlinkage' recognized.
> 
> "You are in a twisty little maze of #includes, all different"... :)

The real answer is for asm/kasan.h to include linux/linkage.h

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-26 14:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 13:25 Valdis Klētnieks
2020-11-26 14:14 ` Russell King - ARM Linux admin [this message]
2020-11-26 14:18   ` Valdis Klētnieks
2020-11-26 14:22   ` Valdis Klētnieks
2020-11-26 14:32     ` Russell King - ARM Linux admin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201126141429.GL1551@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=aryabinin@virtuozzo.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=valdis.kletnieks@vt.edu \
    --subject='Re: linux-next 20201126 - build error on arm allmodconfig' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).