* [PATCH] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS
@ 2020-12-03 23:18 Arnd Bergmann
2020-12-04 1:57 ` santosh.shilimkar
2020-12-08 16:11 ` Arnd Bergmann
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-03 23:18 UTC (permalink / raw)
To: soc, Santosh Shilimkar; +Cc: linux-arm-kernel, Arnd Bergmann, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
These definitions are evidently left over from the days when
sparsemem settings were platform specific. This was no longer
the case when the platform got merged.
There was no warning in the past, but now the asm/sparsemem.h
header ends up being included indirectly, causing this warning:
In file included from /git/arm-soc/arch/arm/mach-keystone/keystone.c:24:
arch/arm/mach-keystone/memory.h:10:9: warning: 'SECTION_SIZE_BITS' macro redefined [-Wmacro-redefined]
#define SECTION_SIZE_BITS 34
^
arch/arm/include/asm/sparsemem.h:23:9: note: previous definition is here
#define SECTION_SIZE_BITS 28
^
Clearly the definitions never had any effect here, so remove them.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-keystone/memory.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/mach-keystone/memory.h b/arch/arm/mach-keystone/memory.h
index 9147565d0581..1b9ed1271e05 100644
--- a/arch/arm/mach-keystone/memory.h
+++ b/arch/arm/mach-keystone/memory.h
@@ -6,9 +6,6 @@
#ifndef __MEMORY_H
#define __MEMORY_H
-#define MAX_PHYSMEM_BITS 36
-#define SECTION_SIZE_BITS 34
-
#define KEYSTONE_LOW_PHYS_START 0x80000000ULL
#define KEYSTONE_LOW_PHYS_SIZE 0x80000000ULL /* 2G */
#define KEYSTONE_LOW_PHYS_END (KEYSTONE_LOW_PHYS_START + \
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS
2020-12-03 23:18 [PATCH] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS Arnd Bergmann
@ 2020-12-04 1:57 ` santosh.shilimkar
2020-12-08 16:11 ` Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: santosh.shilimkar @ 2020-12-04 1:57 UTC (permalink / raw)
To: Arnd Bergmann, soc, Santosh Shilimkar
Cc: linux-arm-kernel, Arnd Bergmann, linux-kernel
On 12/3/20 3:18 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> These definitions are evidently left over from the days when
> sparsemem settings were platform specific. This was no longer
> the case when the platform got merged.
>
> There was no warning in the past, but now the asm/sparsemem.h
> header ends up being included indirectly, causing this warning:
>
> In file included from /git/arm-soc/arch/arm/mach-keystone/keystone.c:24:
> arch/arm/mach-keystone/memory.h:10:9: warning: 'SECTION_SIZE_BITS' macro redefined [-Wmacro-redefined]
> #define SECTION_SIZE_BITS 34
> ^
> arch/arm/include/asm/sparsemem.h:23:9: note: previous definition is here
> #define SECTION_SIZE_BITS 28
> ^
>
> Clearly the definitions never had any effect here, so remove them.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS
2020-12-03 23:18 [PATCH] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS Arnd Bergmann
2020-12-04 1:57 ` santosh.shilimkar
@ 2020-12-08 16:11 ` Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-08 16:11 UTC (permalink / raw)
To: Santosh Shilimkar, Arnd Bergmann, soc
Cc: linux-arm-kernel, Arnd Bergmann, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
On Fri, 4 Dec 2020 00:18:40 +0100, Arnd Bergmann wrote:
> These definitions are evidently left over from the days when
> sparsemem settings were platform specific. This was no longer
> the case when the platform got merged.
>
> There was no warning in the past, but now the asm/sparsemem.h
> header ends up being included indirectly, causing this warning:
>
> [...]
Applied to arm/fixes, thanks!
[1/1] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS
commit: 9280f726097b436c8c907825131cd346d7eb0c0f
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-08 16:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 23:18 [PATCH] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS Arnd Bergmann
2020-12-04 1:57 ` santosh.shilimkar
2020-12-08 16:11 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).