From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Pankaj Dubey <pankaj.dubey@samsung.com>,
stable@vger.kernel.org, Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v2 2/4] soc: samsung: exynos-asv: handle reading revision register error
Date: Mon, 7 Dec 2020 20:05:15 +0100 [thread overview]
Message-ID: <20201207190517.262051-3-krzk@kernel.org> (raw)
In-Reply-To: <20201207190517.262051-1-krzk@kernel.org>
If regmap_read() fails, the product_id local variable will contain
random value from the stack. Do not try to parse such value and fail
the ASV driver probe.
Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/soc/samsung/exynos-asv.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c
index f653e3533f0f..5daeadc36382 100644
--- a/drivers/soc/samsung/exynos-asv.c
+++ b/drivers/soc/samsung/exynos-asv.c
@@ -129,7 +129,13 @@ static int exynos_asv_probe(struct platform_device *pdev)
return PTR_ERR(asv->chipid_regmap);
}
- regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id);
+ ret = regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID,
+ &product_id);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "Cannot read revision from ChipID: %d\n",
+ ret);
+ return -ENODEV;
+ }
switch (product_id & EXYNOS_MASK) {
case 0xE5422000:
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-07 19:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 19:05 [PATCH v2 0/4] soc: samsung: exynos-chipid and asv improvements Krzysztof Kozlowski
2020-12-07 19:05 ` [PATCH v2 1/4] soc: samsung: exynos-asv: don't defer early on not-supported SoCs Krzysztof Kozlowski
2020-12-08 5:56 ` Pankaj Dubey
2021-01-03 16:10 ` Krzysztof Kozlowski
2020-12-07 19:05 ` Krzysztof Kozlowski [this message]
2020-12-08 6:14 ` [PATCH v2 2/4] soc: samsung: exynos-asv: handle reading revision register error Pankaj Dubey
2021-01-03 16:11 ` Krzysztof Kozlowski
2020-12-07 19:05 ` [PATCH v2 3/4] soc: samsung: exynos-chipid: order list of SoCs by name Krzysztof Kozlowski
2020-12-08 6:15 ` Pankaj Dubey
2020-12-07 19:05 ` [PATCH v2 4/4] soc: samsung: exynos-chipid: convert to driver and merge exynos-asv Krzysztof Kozlowski
2020-12-08 7:01 ` Pankaj Dubey
2020-12-08 8:47 ` 'Krzysztof Kozlowski'
2021-01-03 16:10 ` (subset) [PATCH v2 0/4] soc: samsung: exynos-chipid and asv improvements Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207190517.262051-3-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=snawrocki@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).