From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 944BEC433FE for ; Tue, 8 Dec 2020 08:49:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5601A23A60 for ; Tue, 8 Dec 2020 08:49:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5601A23A60 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2MaIQ/6H7uc6DQrkYsALU5EVC79G6Bi/aCZCepFSURw=; b=H1dDr8eHrwYAv9MYgjfJ9FQ/I Bygvz1PKB52Iuw2U9m8gMZ+hjHyFuPGfg0QdH2xDl5yyzcQQSQX4sjCMkP4y2EWtEQfXSfBAR7cjB K6wn36alxzubn9r1urBcbYYRMX7sKHM+BgsRLa7ofMGjo+ZSD0LUDU9ghhp/vhM8OqSfqKk9231su pKBOrh/YZBOHr3GwyRqowDGZ/68671IZ8/4oDIWgT4asTpF4/vhl9hfRp69gUUK3Fnr5onXBue/Uz 7Abpa/8ROF7KeJSMbVTjsZt9WaVdHhwwpgi6+EX5c/eJwIR6X6BkzKtbDdYqJlDtjVAJfvVXau6jC 9a2SjFjbg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmYf5-0000Dv-17; Tue, 08 Dec 2020 08:47:55 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmYf2-0000DE-Si for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 08:47:53 +0000 Received: by mail-wr1-f67.google.com with SMTP id u12so15441707wrt.0 for ; Tue, 08 Dec 2020 00:47:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BrKBGmXKIXaqQceh5B/pGrdX0KS0UAwbEoaskmukc98=; b=hhhHgxUc5nLgp3ooFyLHVxmG3rh0dfVHJg5EaRV8cTBET3njqVlv/pbX4CuMTMAHqO 1WxxeJne1f8ABcVZKOJu29/zrg0CIQrkPCT8KwFv+MTHIlBqbD1B36P52VnKXTR89Kfn ynYc/fRP6MCoHz0vZ7rFmlfmGwtJsVBvp368GzZEV+5287u8JnXO7ufLC6j4UAhRFKd8 sBlLSUAgMzTdUODZcogBZjozgO1cqg9Dz6arf1Um0fvapl+/TN7vGNiN+61/QGOJBcMQ qtw09RIE90uyonPB9pGysBMLLUgouwnxOcrCaZyrgNvNOqTpoka3MQujXC53EdawNGt3 hmmA== X-Gm-Message-State: AOAM533HR7B5TFDBGDeUvZlwHMMnSr5ynck20C/Qi5CU6bYFkdUmCpW1 umm8ZYXLcxmrnjcAJjA3UYc= X-Google-Smtp-Source: ABdhPJyWAMROP+PK0mBF0qHHxOHNLgfpd53EYC6W7uJnzsNAJQpQgVl4cP5/RA0/PWZoHpWsIU92oQ== X-Received: by 2002:a5d:400a:: with SMTP id n10mr24060883wrp.362.1607417271681; Tue, 08 Dec 2020 00:47:51 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id h15sm13812204wru.4.2020.12.08.00.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 00:47:50 -0800 (PST) Date: Tue, 8 Dec 2020 09:47:49 +0100 From: 'Krzysztof Kozlowski' To: Pankaj Dubey Subject: Re: [PATCH v2 4/4] soc: samsung: exynos-chipid: convert to driver and merge exynos-asv Message-ID: <20201208084718.GA6767@kozik-lap> References: <20201207190517.262051-1-krzk@kernel.org> <20201207190517.262051-5-krzk@kernel.org> <001101d6cd2f$f1e4a9a0$d5adfce0$@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <001101d6cd2f$f1e4a9a0$d5adfce0$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_034752_957152_D839AFAE X-CRM114-Status: GOOD ( 23.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, 'Arnd Bergmann' , 'Bartlomiej Zolnierkiewicz' , 'Sylwester Nawrocki' , linux-kernel@vger.kernel.org, 'Chanwoo Choi' , 'Alim Akhtar' , linux-arm-kernel@lists.infradead.org, 'Marek Szyprowski' Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 08, 2020 at 12:31:23PM +0530, Pankaj Dubey wrote: > > > > -----Original Message----- > > From: Krzysztof Kozlowski > > Sent: Tuesday, December 8, 2020 12:35 AM > > To: Krzysztof Kozlowski ; linux-arm- > > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > > kernel@vger.kernel.org > > Cc: Sylwester Nawrocki ; Marek Szyprowski > > ; Bartlomiej Zolnierkiewicz > > ; Arnd Bergmann ; Chanwoo > > Choi ; Alim Akhtar ; > > Pankaj Dubey > > Subject: [PATCH v2 4/4] soc: samsung: exynos-chipid: convert to driver and > > merge exynos-asv > > > > The Exynos Chip ID driver on Exynos SoCs has so far only informational > > purpose - to expose the SoC device in sysfs. No other drivers depend on > it > > so there is really no benefit of initializing it early. > > > > One of the intention behind initializing Exynos Chip ID driver in early > stage was to simplify code in arch/arm/mach-exynos specifically calls such > as soc_is_exynosXXXX. > But there were lot of resistance from community to add any such calls (or > exported function) from mach-exynos files to the driver file. Whereas some > other SoC code is using the same, e.g. tegra_get_chip_id being called from > mach-tegra files to drivers/soc/tegra/. Unfortunately we could not accept > similar solution for Exynos SoC and hence could not get rid of > soc_is_exynosxXXX and similar macros from various file in mach-exynos and > eventually converting those files into a full-fledged driver files. > > Any opinion how can we achieve this if we convert Exynos Chip ID driver to a > regular driver? a. Some parts of mach code can be moved to drivers and then use OF calls. b. The ones which cannot be moved, could use soc_device_match() assuming they are called after the soc-bus is operational - so after core_initcalls. c. The ones which are called early or without cache coherency (soc_device_match() uses krefs()), cannot be converted. This chip ID conversion indeed kills case (b) above... which I am not sure is worth bothering. Which parts of code could be moved like this? Not mentioning that none of this work have happened since few years... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel