From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40CC8C433E0 for ; Mon, 21 Dec 2020 18:47:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E710422D49 for ; Mon, 21 Dec 2020 18:47:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E710422D49 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jram+MujGllCSHF11jhUK07tIKM2z7qcZ5WGVqTOh3U=; b=n1KHcnE6CCn+GNA9cZHAXZPPq Tuex1YYLuDw8+YiZnYA4tBtey7QlFj4EifrqRLJy5CDfYs0R6Sf3QkYKnEzkXxaEUViNk1HxOohk8 4hJ4Fme86PqhawhNyb7a49QaYcFnJ45M7YNCzfaHwzjiojIKOjq5GSqxe6GMvJm9sD55Nv63eCO20 zkEUBxLre9g4pCyaIRaS4VajbFGqtWsg5qCUJ2iKCi/6NchTSZWO66Hq4IwBe+EphMSQc0GZDd5uC 6DlV5gzPxqbbldHBy8xbBqvIgZ3fVw6txqVm4F+DGa45CGr49NuaJDP0nEbCNq1EwrMq3INGwf99x yA8CiW1VQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQBo-00072P-CR; Mon, 21 Dec 2020 18:45:48 +0000 Received: from mail-oi1-f173.google.com ([209.85.167.173]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQBm-00071t-3Z for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 18:45:46 +0000 Received: by mail-oi1-f173.google.com with SMTP id w124so12258880oia.6 for ; Mon, 21 Dec 2020 10:45:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=C9YKK11A4vCGj5j/fzBjsXO3fgizirMdIUh+8Fg05fI=; b=d2ux/w/avVCN4dEJvnZjvQQt93cQfoRoxsXT6Oo2vHVR5Cgb3cEgK98nTyojkXyYTm sxJYoFRN0KhIASUv7eKOO89pb0eC+mmHbdCURZSH2P7YuxubcblMFhOnxlP9dnB27+zL ipnLUFFhgNetwQByLPXJjFitTU3O6Y93++6wPYuwaO+hoze0MuR4xG2vaQPjNUL6Fjxj Ez9WSZUVuf38png8gCdeewCa/Uu8rxWNzOS3F98jZMjilM6xW/mFkC94tYYKwrbtICQ7 BOJk/jwSLN44J5FWbenEenUCD7Gj/oVwLClRfcCEOvD0ORmF3D5OyYsQqvdhEmy5rDK0 gQSQ== X-Gm-Message-State: AOAM531DBR8BXbFYH4zYKvz+S1b1CAdcOCrl4B1CLPxhoS+MYDEnWg86 Fno/oqNdNvFwK7JolqJV9w== X-Google-Smtp-Source: ABdhPJwrQo7oPkw60HM1iX43AnG0rd1ZwQBteBiGRAjzgAnn+m2o5dKSjOcluwF2SZZoZnF1ypSzkA== X-Received: by 2002:aca:ea42:: with SMTP id i63mr7148216oih.163.1608576345226; Mon, 21 Dec 2020 10:45:45 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id x31sm3946058otb.4.2020.12.21.10.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 10:45:44 -0800 (PST) Received: (nullmailer pid 342072 invoked by uid 1000); Mon, 21 Dec 2020 18:45:42 -0000 Date: Mon, 21 Dec 2020 11:45:42 -0700 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [RFC 13/18] mfd: max77686: Do not enforce (incorrect) interrupt trigger type Message-ID: <20201221184542.GA342038@robh.at.kernel.org> References: <20201210212534.216197-1-krzk@kernel.org> <20201210212534.216197-13-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201210212534.216197-13-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_134546_174204_0DAB1D82 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Liam Girdwood , Michael Turquette , Angus Ainslie , linux-kernel@vger.kernel.org, Iskren Chernev , Lee Jones , linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Chanwoo Choi , Andy Gross , devicetree@vger.kernel.org, Matheus Castello , linux-arm-msm@vger.kernel.org, Hans de Goede , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Stephen Boyd , linux-pm@vger.kernel.org, Sebastian Reichel , Mark Brown , Sebastian Krzyszkowiak Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Dec 2020 22:25:29 +0100, Krzysztof Kozlowski wrote: > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Maxim 77686 datasheet describes the interrupt line as active low > with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > The interrupt line is shared between PMIC and RTC driver, so using level > sensitive interrupt is here especially important to avoid races. With > an edge configuration in case if first PMIC signals interrupt followed > shortly after by the RTC, the interrupt might not be yet cleared/acked > thus the second one would not be noticed. > > Signed-off-by: Krzysztof Kozlowski > > --- > > This patch should wait till DTS changes are merged, as it relies on > proper Devicetree. > --- > Documentation/devicetree/bindings/clock/maxim,max77686.txt | 4 ++-- > Documentation/devicetree/bindings/mfd/max77686.txt | 2 +- > Documentation/devicetree/bindings/regulator/max77686.txt | 2 +- > drivers/mfd/max77686.c | 3 +-- > 4 files changed, 5 insertions(+), 6 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel