From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9783DC433DB for ; Mon, 21 Dec 2020 18:47:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5185222D49 for ; Mon, 21 Dec 2020 18:47:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5185222D49 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g7ooVv9yqYYbaetkBql1zWL6uGo2tnsnM7AptST2Z/U=; b=veHERqY632ZSzc+IioHK3aoyH n19IdbEuXxEP5Fg2P5UZ+gfaJ6KYIdmwYUP6D7cOQmkGi6uqYSR9Rtqi4/kQZmD62Q2lfuU3fYj/7 kJF1giBJK9cHopcAiqq7ocqVh3g+Bv+7c6nXMzWzPbOGo9yFCyWC49u71Iu3pGLvIAR+U0gOkyT0c 1kmumS/I36tBvN9W/e0w9tW1lwMCzpDHdtDn0GwOZEYyHd7jpij8WI9cbfJkoY31OOTqbtMrsmZy+ OKcNO12/fhYSWcDhg9RxYyiqj/+7uvY91gG0shhvE8lo2+6BLJRYj/J5IA4B0bpquhKZh/7qO+rlI iDBJPrP+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQCJ-00077k-9c; Mon, 21 Dec 2020 18:46:19 +0000 Received: from mail-ot1-f54.google.com ([209.85.210.54]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQCG-00076u-Ji for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 18:46:17 +0000 Received: by mail-ot1-f54.google.com with SMTP id n42so3774109ota.12 for ; Mon, 21 Dec 2020 10:46:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LaO8M0BQW8Ol84jvAC5SvqGxfW76On/n2SEzgRenXkA=; b=m1efVOarKMpvKcRy2YLoMI2g0qcoPLeB019MUhxYHr1C5VZ33Jt49f4Bsz6GiKXgu7 pxqU2/5ypNhHtt4QfYpVbYDWbnb2CBNjy/rNX5Mxa3HBpUES0hwJrcgxfgGbxne+Gvzr 7CuUkVzH/AEitnO7pV2xuBXUo/+wz9QBDKzHwfaEtYCmp0jkMpA1hHo21vuIYc9ulY3N 3J77pCgRH5lTsJpKVckIIx+9ryYeMR4F6nfjN9IOLTxsVh8pUdievmmy7nC40z46Jayb LAkVU/vx3bKwMdOQJWTtj82+tu2S1wO72XfCuASWra9nevXelwXCSyRFWVjZCFqJEAGi h4vg== X-Gm-Message-State: AOAM532RyVVqrCXsp4bGGDC5ZCdCmJK1XO2zstJE6V5a/6hM4/jivg17 Z1NSkcfhe12dTLm/t2Wgqg== X-Google-Smtp-Source: ABdhPJwBJoFXtzbcelVumUza445XagA6T8nK1JW5vIV8hPvpK/hSG3/068uI21rsv342ZPIwm7xnSw== X-Received: by 2002:a9d:7411:: with SMTP id n17mr12863728otk.262.1608576375645; Mon, 21 Dec 2020 10:46:15 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id z9sm3954201ote.13.2020.12.21.10.46.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 10:46:14 -0800 (PST) Received: (nullmailer pid 342965 invoked by uid 1000); Mon, 21 Dec 2020 18:46:12 -0000 Date: Mon, 21 Dec 2020 11:46:12 -0700 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [RFC 15/18] mfd: max77693: Do not enforce (incorrect) interrupt trigger type Message-ID: <20201221184612.GA342913@robh.at.kernel.org> References: <20201210212534.216197-1-krzk@kernel.org> <20201210212534.216197-15-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201210212534.216197-15-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_134616_675128_F70F0733 X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Michael Turquette , Angus Ainslie , Bjorn Andersson , Iskren Chernev , Lee Jones , linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Chanwoo Choi , Andy Gross , devicetree@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-arm-msm@vger.kernel.org, Hans de Goede , Mark Brown , Matheus Castello , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Stephen Boyd , Liam Girdwood , linux-kernel@vger.kernel.org, Rob Herring , Sebastian Reichel , Sebastian Krzyszkowiak Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Dec 2020 22:25:31 +0100, Krzysztof Kozlowski wrote: > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Maxim 77693 datasheet describes the interrupt line as active low > with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > The interrupt line is shared between PMIC and RTC driver, so using level > sensitive interrupt is here especially important to avoid races. With > an edge configuration in case if first PMIC signals interrupt followed > shortly after by the RTC, the interrupt might not be yet cleared/acked > thus the second one would not be noticed. > > Signed-off-by: Krzysztof Kozlowski > > --- > > This patch should wait till DTS changes are merged, as it relies on > proper Devicetree. > --- > Documentation/devicetree/bindings/mfd/max77693.txt | 2 +- > drivers/mfd/max77693.c | 12 ++++-------- > 2 files changed, 5 insertions(+), 9 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel