From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1834C433E0 for ; Mon, 21 Dec 2020 19:38:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D3E122B43 for ; Mon, 21 Dec 2020 19:38:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D3E122B43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6v0bOznFgjq/lT1QItVNwmVQVRAjgZEwt9mm269CqBw=; b=IiDf5VR2uPhQ4nMHnaRnmisdg /hRAB/ve+wshIID6MbO0PyVa48nVuvewiVuFenqPYxWsyIQP/cUuF40EVXEv4pf8oOwgUMzJZjSEC RbJ4qwRejhkdE9xQ78va2rv1NOKJOHu4F8EsQa/pKrNVL1f+2buFdVpw+xTv8KYJSx1R2M1Gu51Ly tmcvyM38EDYqHDCMStny57igZO8VmmRdx1dlz0oFesoJCplDU6np06PDCiqoAXoFloJ8CEt9dM0hF 2UO10BIOjyeOtZzIE4+NbtxMYOGEBz/T753PV6kRZbyNf+F97Jq4D/d5Zjogw02ZpnH474e1eh155 supIZnjiQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQzh-0003it-2O; Mon, 21 Dec 2020 19:37:21 +0000 Received: from mail-oi1-f177.google.com ([209.85.167.177]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQzd-0003iH-NV for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 19:37:18 +0000 Received: by mail-oi1-f177.google.com with SMTP id s75so12418246oih.1 for ; Mon, 21 Dec 2020 11:37:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q18NZxhvIxRINjWva11fV4XGSXxm/kjXgjBXhmlaf7Q=; b=cBw/lYP3hOc7SSAlu873fvsL3ww1WwOJFl7kWcrA/zJy/EmHvQU3quEG4msD26XGlj SxtUeSaegGyB+0g93Ie+be2FGMGf4Vh/ma5pmErFHzY3EEDbGwS6/g5wvAb1W5en+2Y7 cJ7Dp1RndnveSEGqO+TraEkNOKz2u5OsAnJsnjeE5otEIwVolZS2Gptw/wxR5ezpx/c0 BspLnef/YEEHeVTh+o2YLKAtAPUdbM+6gL79wlaf8kAIGBwOn1NxLjB70ametqhjNpTe z+jB3SzgRzQu6u3J0sNQZLYeGF3HVlxu/BiGtf2eTGkaLVBzsbAdeJmXKwOXDYD+OknB 55Ag== X-Gm-Message-State: AOAM532P/+JlodEAbwqKaHhgJGPaEQgRF/cM+wIeR1GrlIH9Rp1h5vbg 97sRvUaZ/yHTlSWrZ0OgaQ== X-Google-Smtp-Source: ABdhPJwT/ITKR0tXg/1ddqMlf21lgfBAiRqRwlsfzNzLb+nCGUKxM9b0nx1d9t1knadgyrBINu3zMA== X-Received: by 2002:aca:4c90:: with SMTP id z138mr12042714oia.142.1608579436938; Mon, 21 Dec 2020 11:37:16 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id s26sm4001068otd.8.2020.12.21.11.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 11:37:16 -0800 (PST) Received: (nullmailer pid 422266 invoked by uid 1000); Mon, 21 Dec 2020 19:37:14 -0000 Date: Mon, 21 Dec 2020 12:37:14 -0700 From: Rob Herring To: Alexandre Belloni Subject: Re: [PATCH 2/3] dt-bindings: atmel-sysreg: add microchip,sama7g5-shdwc Message-ID: <20201221193714.GA420008@robh.at.kernel.org> References: <1608123453-1423-1-git-send-email-claudiu.beznea@microchip.com> <1608123453-1423-3-git-send-email-claudiu.beznea@microchip.com> <20201216134100.GG2814589@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201216134100.GG2814589@piout.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_143717_780495_89F3DB59 X-CRM114-Status: GOOD ( 21.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, sre@kernel.org, ludovic.desroches@microchip.com, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 16, 2020 at 02:41:00PM +0100, Alexandre Belloni wrote: > On 16/12/2020 14:57:32+0200, Claudiu Beznea wrote: > > Add compatible for Microchip SAMA7G5's shutdown controller. > > > > Signed-off-by: Claudiu Beznea > > --- > > Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > I'm pretty sure the first comment you'll get is to convert this file to > yaml ;) I certainly wouldn't object, but just for a new compatible not requiring that (yet). > > diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt > > index 62cd4e89817c..7990358ac06e 100644 > > --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt > > +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt > > @@ -91,7 +91,8 @@ SHDWC SAMA5D2-Compatible Shutdown Controller > > 1) shdwc node > > > > required properties: > > -- compatible: should be "atmel,sama5d2-shdwc" or "microchip,sam9x60-shdwc". > > +- compatible: should be "atmel,sama5d2-shdwc", "microchip,sam9x60-shdwc" or > > + "microchip,sama7g5-shdwc" > > - reg: should contain registers location and length > > - clocks: phandle to input clock. > > - #address-cells: should be one. The cell is the wake-up input index. > > @@ -103,7 +104,7 @@ optional properties: > > microseconds. It's usually a board-related property. > > - atmel,wakeup-rtc-timer: boolean to enable Real-Time Clock wake-up. > > > > -optional microchip,sam9x60-shdwc properties: > > +optional microchip,sam9x60-shdwc or microchip,sama7g5-shdwc properties: > > - atmel,wakeup-rtt-timer: boolean to enable Real-time Timer Wake-up. > > > > The node contains child nodes for each wake-up input that the platform uses. > > -- > > 2.7.4 > > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel