From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D29C433E0 for ; Tue, 22 Dec 2020 19:15:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D5D723130 for ; Tue, 22 Dec 2020 19:15:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D5D723130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bewilderbeest.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=24I8CzqMDr8uF62Wdy1IW+H1ixbpGRnNXwqKXh7BdGc=; b=obU1pt9OHVxiNiNnYH2JjHR7g mtQwH/A1Eq6cTNt6JWGv0QNVNwhVryIkkMo5FknkuFxz59+FZUulu5IEn0BhQx+tMYpyPWHBuA2B3 58G68IsbrCnHJPnBD4A4MT2upvX5VliYPY6BdjXGVPVVDd3Ts/LxpMiXKc7OG5pOFoPCSD4wBM07z FpQ8g7qVkG3Hi+InmnfzpuNwhFavbPDPTS+2/WxKKyTjoDAYWW+wIRz3bBwNS9z0eIF3SRhLUblt7 83afOvVEIz/Cxz3JXrg6o6BKV2dTSkaoJ0iC/SJGwCwmSpc1x9jGcimWYpxuL+mJWmY+Vr6ee/AGL 82/cXb/xw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krn7N-0007Xw-0P; Tue, 22 Dec 2020 19:14:45 +0000 Received: from thorn.bewilderbeest.net ([2605:2700:0:5::4713:9cab]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krn7K-0007Wd-Gc for linux-arm-kernel@lists.infradead.org; Tue, 22 Dec 2020 19:14:43 +0000 Received: from hatter.bewilderbeest.net (unknown [IPv6:2600:6c44:7f:ba20:1c66:ab2d:5a3:5a9e]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id AF267806F7; Tue, 22 Dec 2020 11:14:39 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 thorn.bewilderbeest.net AF267806F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1608664480; bh=M5Opg5R/38DkRwnOgdlxD0B9jj1MfxC+605df+mJ9y0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ew1GhxxcyeI5UqiQoh9P4V+yGGrE9TOA+ZB/fGc/VpWZ8Fglsm6z44PYyx49FCHI2 WXoowMLbDeHdvfw51KVjVk7K9SHI9NtoycPMYFqI+ccZWF1DIFAHQQ4PKeiuTDPmIG ukjUraBzf9y7PL1ny35Vb/vYoZPCa6BbJJ+JFG9I= Date: Tue, 22 Dec 2020 13:14:33 -0600 From: Zev Weiss To: Joel Stanley Subject: Re: [PATCH 2/3] aspeed-video: clear spurious interrupt bits unconditionally Message-ID: <20201222191433.3dgnfwyrod4tnvaf@hatter.bewilderbeest.net> References: <20201215024542.18888-1-zev@bewilderbeest.net> <20201215024542.18888-3-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_141442_780577_D407FB9C X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jae Hyun Yoo , linux-aspeed , Andrew Jeffery , OpenBMC Maillist , Eddie James , Linux Kernel Mailing List , Mauro Carvalho Chehab , Linux ARM , linux-media@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 21, 2020 at 10:47:37PM CST, Joel Stanley wrote: >On Tue, 15 Dec 2020 at 02:46, Zev Weiss wrote: >> >> Instead of testing and conditionally clearing them one by one, we can >> instead just unconditionally clear them all at once. >> >> Signed-off-by: Zev Weiss > >I had a poke at the assembly and it looks like GCC is clearing the >bits unconditionally anyway, so removing the tests provides no change. > >Combining them is a good further optimization. > >Reviewed-by: Joel Stanley > >A question unrelated to this patch: Do you know why the driver doesn't >clear the status bits in the interrupt handler? I would expect it to >write the value of sts back to the register to ack the pending >interrupt. > No, I don't, and I was sort of wondering the same thing actually -- I'm not deeply familiar with this hardware or driver though, so I was a bit hesitant to start messing with things. (Though maybe doing so would address the "stickiness" aspect when it does manifest.) Perhaps Eddie or Jae can shed some light here? Zev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel