From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3BDDC433DB for ; Tue, 29 Dec 2020 15:44:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E63F20825 for ; Tue, 29 Dec 2020 15:44:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E63F20825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Py/ZsskCAeggyheMu9e0ExScscsQW/sRSsbWT5h7ink=; b=pxKKp3k+myk6nlEWIyiRdw6aq iFs/9J+KgdHWhAyfmvQYJp6kvV9Jblz/Osx+CjvbKSLpTU4AS6GWNkd3JrqKtG8xML6+GB/QRC/zc X0qChRssuzjrC13OxdkGf/b6CdSVzx3M8XJ3N8LfNWq2/noyD6dWR8asussUD0+TQfk8RjXbLY5nv soPzcIlDfGf1IGZ5mxSYuHz7/EHEPyAkyKN6qeA94IO5fMHK5EAnk8+rkTz7Pkv1qB8hyROnCSr8Y kiYpH9RgEGzbqPVn1WInRe+s7+AVMSgxHKuUXLNgbfA/QRPOkC/0dkbUcrKDXVfzwmO+xL3EG1jtp jx73oiPrw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kuH9c-0000rR-9R; Tue, 29 Dec 2020 15:43:20 +0000 Received: from mail-wr1-f51.google.com ([209.85.221.51]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kuH9a-0000q2-1R for linux-arm-kernel@lists.infradead.org; Tue, 29 Dec 2020 15:43:18 +0000 Received: by mail-wr1-f51.google.com with SMTP id a12so14974922wrv.8 for ; Tue, 29 Dec 2020 07:43:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kHLH9BKjnkBNG0P79WleVTRBo+h2LPhEpaoEfJZBQX0=; b=a+HmMgbayrnHpoGgzyeneYUIw6MBTxsmKxYDawSr0FastPfe9A7RjZ+6iNHGrJ3CHu NzxEeCDB7F2vnT6ZYS/BmR7x+3CLy1A+R3mDk08bQ13RNBm/viBcUnzKPWxY/I3Sqc3f 82PUcJAc0QWXKyD0aQk11y7R4lfnWy/L6Sx4BAZGVRY4DOrALI7Dm4QKt9femNgYS4tl Xa+mxnSOS5VkL+vb7ciyD83TuD1FPX4+wiuzUxnAY2QmEZN2QE3CoehKsUL8XAFhb71j T1g7tzSw1vMLME2Sdzz44cmnE4Dnfijja8qy+2JukCBroQ3+Ax/+dHOsZh8kNOGKrK7O JU0w== X-Gm-Message-State: AOAM530oYU86FeYOmZdssfMTn+mNTPKOQ9GvNK6eGSQXEQ+RaCZdAK+F FldwQknCeMu5fVcRgDsvOJY= X-Google-Smtp-Source: ABdhPJweM3e8AyF0aMzlpIqprrmb9hNyDdmwFBlBcfGIFYXxNSXRerv5RsLaIqFHnlbwj+F37pb3hg== X-Received: by 2002:adf:a2ca:: with SMTP id t10mr29441011wra.370.1609256594329; Tue, 29 Dec 2020 07:43:14 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id u205sm4101750wme.42.2020.12.29.07.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Dec 2020 07:43:13 -0800 (PST) Date: Tue, 29 Dec 2020 16:43:11 +0100 From: Krzysztof Kozlowski To: Chanwoo Choi , Bartlomiej Zolnierkiewicz , Michael Turquette , Stephen Boyd , Rob Herring , Lee Jones , Sebastian Reichel , Liam Girdwood , Mark Brown , Andy Gross , Bjorn Andersson , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH 03/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on Midas family Message-ID: <20201229154311.GA13025@kozik-lap> References: <20201210212534.216197-1-krzk@kernel.org> <20201210212534.216197-3-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201210212534.216197-3-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201229_104318_186405_A7246D53 X-CRM114-Status: GOOD ( 20.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angus Ainslie , Hans de Goede , Sebastian Krzyszkowiak , Iskren Chernev , Matheus Castello Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 10, 2020 at 10:25:19PM +0100, Krzysztof Kozlowski wrote: > The Maxim fuel gauge datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU. The falling edge > interrupt will mostly work but it's not correct. > > Fixes: e8614292cd41 ("ARM: dts: Add Maxim 77693 fuel gauge node for exynos4412-trats2") > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos4412-midas.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi Marek, I remember you were reporting that on Trats2 you see fuel gauge interrupt storm with this patchset. Is it correct? Shall I wait with applying this? Best regards, Krzysztof > diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi > index 111c32bae02c..b8b75dc81aa1 100644 > --- a/arch/arm/boot/dts/exynos4412-midas.dtsi > +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi > @@ -221,7 +221,7 @@ i2c_max77693_fuel: i2c-gpio-3 { > fuel-gauge@36 { > compatible = "maxim,max17047"; > interrupt-parent = <&gpx2>; > - interrupts = <3 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > pinctrl-names = "default"; > pinctrl-0 = <&max77693_fuel_irq>; > reg = <0x36>; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel