From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1939AC433DB for ; Mon, 4 Jan 2021 18:39:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE6AA2076D for ; Mon, 4 Jan 2021 18:39:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE6AA2076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/Bds8iwBPGpPndo1khKroUD45v4KcVY4O8sTUJwLATE=; b=eVNb9cPME3bIxUEMdjQQlpUzx BJwkigs1eNxvNXAmHYlfoXg4PYPBkqiJhzgPNVKTOc01wWrwL9YWj+kOMNFgPY7Mr4tgcKMhh2R3G 30hs0TBg1gBvwTE3fYeOgqM26VEsxTdtpk4KdJgR3XjRszZ7guk7XRgaa4JCEmai01+BnQG9K56kA coSucYbsDzIefhm+Es7rFRxr8cJ/LTB37N1p6JMl+hbp8OyRB+bLD9ekvJqpDNc2NRxmlV0Q0NWPm dzJzLesO4NMsjEADw1VUICi2pHYUvdaHW4aStEvYXLTcMtKAE3QDsesYdaUgflJXBab4xnm2NuPaU 2esD1ueDw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwUkN-00014m-U3; Mon, 04 Jan 2021 18:38:27 +0000 Received: from mail-wm1-f48.google.com ([209.85.128.48]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwUkL-00013c-76 for linux-arm-kernel@lists.infradead.org; Mon, 04 Jan 2021 18:38:26 +0000 Received: by mail-wm1-f48.google.com with SMTP id 190so186720wmz.0 for ; Mon, 04 Jan 2021 10:38:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=C4a7e9iYEX7onVSgyKRCPpx3nNaq3txIA6JWld1n9j0=; b=bUIerqbDVMH1MzFcfq7joQZQ771v6zco2OUi0keNurhbX18XmZIn4hXRlfHZNrtTGI zYByV8sxyviqwXhc3fTm9lfxPD/pgodXWxUlot4F+y5pVTyN8pd3w6eAShDKnUnRfHLl vcopKUuWHgREiBMZfdGsBin5R1ena3NpeJalYr8Znji2kKlt7X8EzFn8cJonocnAG8aA cCO+9RhqAGh0ZBXKAGfQj2eb56a6eNUu67pnzwMKzIt//duaUW5EPRKrHMacnl1Ul3+T it87BQFyvNLOEUF2HwHcCzidDIX5ZgaXCLYQnrzgttv7AAKBRuJM87E4WvyWQIWiT3F0 JjDg== X-Gm-Message-State: AOAM530XWLzOYiJihfN7Pfoowt9Nh0OGB1+xbnGO8O+3VgUnW3LcwWnl ufiwXTEDHwZYF3KXrX3OXz8= X-Google-Smtp-Source: ABdhPJxuVINeQEEmLpcBzfvhhDMMJibveqWeEQXqTuW3zW0q5F/SVBHRglAB6rgQYS/uGqGQA2u20Q== X-Received: by 2002:a1c:2b46:: with SMTP id r67mr201271wmr.162.1609785503622; Mon, 04 Jan 2021 10:38:23 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id b83sm274815wmd.48.2021.01.04.10.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jan 2021 10:38:22 -0800 (PST) Date: Mon, 4 Jan 2021 19:38:21 +0100 From: Krzysztof Kozlowski To: Mark Brown Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Message-ID: <20210104183821.GA29033@kozik-lap> References: <20201230205139.1812366-1-timon.baetz@protonmail.com> <20201230205139.1812366-2-timon.baetz@protonmail.com> <20210104135156.GB5645@sirena.org.uk> <20210104181825.GB27043@kozik-lap> <20210104182734.GH5645@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210104182734.GH5645@sirena.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210104_133825_301178_DA4FA689 X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Rob Herring , Timon Baetz , Chanwoo Choi , MyungJoo Ham , ~postmarketos/upstreaming@lists.sr.ht, Sebastian Reichel , Lee Jones , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 04, 2021 at 06:27:34PM +0000, Mark Brown wrote: > On Mon, Jan 04, 2021 at 07:18:25PM +0100, Krzysztof Kozlowski wrote: > > On Mon, Jan 04, 2021 at 01:51:56PM +0000, Mark Brown wrote: > > > > > +- charger: Node for configuring the charger driver. > > > > + Required properties: > > > > + - compatible: "maxim,max8997-battery" > > > > > + Optional properties: > > > > + - extcon: extcon specifier for charging events > > > > + - charger-supply: regulator node for charging current > > > > > +- muic: Node used only by extcon consumers. > > > > + Required properties: > > > > + - compatible: "maxim,max8997-muic" > > > > Why do these need to appear in the DT binding? We know these features > > > are there simply from knowing this is a max8997. > > > If you refer to children nodes, then we do not know these entirely > > because the features could be disabled (pins not connected). In such > > case these subnodes can be disabled and MFD framework will not > > instantiate children devices. > > We can indicate the presence of features without adding new compatible > strings, that's just encoding the way Linux currently divides things up > into the bindings. For example having an extcon property seems like it > should be enough to figure out if we're using extcon. It won't be enough because MFD will create device for extcon and bind the driver. The same for the charger. We have a board where max8997 is used only as PMIC (providing regulators) without battery and USB connectivity. Another point, is that this reflects the real hardware. The same as we model entire SoC as multiple children of soc node (with their own properties), here we represent smaller chip which also has sub-components. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel