From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEAC5C433DB for ; Wed, 6 Jan 2021 15:35:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 836062311E for ; Wed, 6 Jan 2021 15:35:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 836062311E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BiyVadEBJojTr+PMPnCCIkMNxsOzrp/dViH0nOkGZSc=; b=GCHBDYeesnl8QTsXVI/z3RxNB Jg12oFRFRzTtv8VgaTrsUNIcrCVD7ikaOP60mm79Z0iB45H250EJYZdh9ms6wiNkrqIOhZyO5pIEs cnO2WscbMlyvxTmjFHVxS5iChH+g8gn8H6ZO+3lOYyJF8dxrbAJppQP+g2MP5Bliozzo3U4cM/Ssz hw9jzTQ3M+gMKAoglzL0OOjIvzVU8gTwQn5nfLRmh7v2hsUKQR7HWJQ4FxU5D8BUOB8WORl7QaIlQ w/s4b5DLpwvZEK6ph3eTATpDL5/mZ8sprkzsw3qf27QV8kzyNnvevj5w1Qw9BqOsoDR3BthsEE35s Rf0HnJQ6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxAnC-000171-7s; Wed, 06 Jan 2021 15:32:10 +0000 Received: from mail-io1-f46.google.com ([209.85.166.46]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxAn9-00016W-GF for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 15:32:08 +0000 Received: by mail-io1-f46.google.com with SMTP id r9so3097489ioo.7 for ; Wed, 06 Jan 2021 07:32:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t80RrQIP9pcWO65dqznFuyn9d1RG+MW1J0H6Xs08o5Q=; b=QOJnT3MG8OET2lDy7e0Gv4KOiE79oB9G9rs38eAxo0NIGcGKLnBZG0hzA2K8fPlb1J XZP5DLsVYhoOBXK04Lzj1oYfixb8WtUeY+RMwvIBlUNQkgAjlVBj3JIwY3MnlDBqi3LB coW0Mi/D48+tATQOYoA+W/x2jZvpsKQ/gI6UtQ1ZT3bYV3DTFLOw1CCc8vy2KL8qU8hw snRwip3PaHJYwUz5OK0u0YDCsJ2QxQGSqTUax/YfBtnHX2FEdkohPT+9zIANj0+vXv7y 98gCbJv3Eh+xn7Tuz5veIoKMNSdiJKS9M1o4BgNtFkW9Sc0t9XQ8OKZJP7S59XRxRAti XC/g== X-Gm-Message-State: AOAM5337CCCyejjXRNFf4IY2vNTWQx3ILyOkJ+Ztc7MynRVOur6Egbpf 8cr5QpP7YiSvrFIArZr8qg== X-Google-Smtp-Source: ABdhPJyz6kf7fccUgN42Q21kf9oT8emUqUG0qvmMQDGTyBYyMTKFCZbUVC4pPwY/vKQfpxrz6D+Cnw== X-Received: by 2002:a02:b709:: with SMTP id g9mr4250778jam.90.1609947126638; Wed, 06 Jan 2021 07:32:06 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id n10sm2371751ila.69.2021.01.06.07.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jan 2021 07:32:05 -0800 (PST) Received: (nullmailer pid 2267272 invoked by uid 1000); Wed, 06 Jan 2021 15:32:02 -0000 Date: Wed, 6 Jan 2021 08:32:02 -0700 From: Rob Herring To: "Chia-Wei, Wang" Subject: Re: [PATCH 5/6] soc: aspeed: Add eSPI driver Message-ID: <20210106153202.GA2258036@robh.at.kernel.org> References: <20210106055939.19386-1-chiawei_wang@aspeedtech.com> <20210106055939.19386-6-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210106055939.19386-6-chiawei_wang@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_103207_581893_2233E267 X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, BMC-SW@aspeedtech.com, andrew@aj.id.au, maz@kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, joel@jms.id.au, p.zabel@pengutronix.de, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 06, 2021 at 01:59:38PM +0800, Chia-Wei, Wang wrote: > The Aspeed eSPI controller is slave device to communicate with > the master through the Enhanced Serial Peripheral Interface (eSPI). > All of the four eSPI channels, namely peripheral, virtual wire, > out-of-band, and flash are supported. > > Signed-off-by: Chia-Wei, Wang > --- > drivers/soc/aspeed/Kconfig | 49 ++ > drivers/soc/aspeed/Makefile | 5 + > drivers/soc/aspeed/aspeed-espi-ctrl.c | 197 ++++++ > drivers/soc/aspeed/aspeed-espi-flash.c | 490 ++++++++++++++ > drivers/soc/aspeed/aspeed-espi-oob.c | 706 ++++++++++++++++++++ > drivers/soc/aspeed/aspeed-espi-peripheral.c | 613 +++++++++++++++++ > drivers/soc/aspeed/aspeed-espi-vw.c | 211 ++++++ > include/uapi/linux/aspeed-espi.h | 160 +++++ > 8 files changed, 2431 insertions(+) > create mode 100644 drivers/soc/aspeed/aspeed-espi-ctrl.c > create mode 100644 drivers/soc/aspeed/aspeed-espi-flash.c > create mode 100644 drivers/soc/aspeed/aspeed-espi-oob.c > create mode 100644 drivers/soc/aspeed/aspeed-espi-peripheral.c > create mode 100644 drivers/soc/aspeed/aspeed-espi-vw.c drivers/spi/ is the correct location for a SPI controller. > create mode 100644 include/uapi/linux/aspeed-espi.h This userspace interface is not going to be accepted upstream. I'd suggest you look at similar SPI flash capable SPI controller drivers upstream and model your driver after them. This looks like it needs major reworking. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel