From: Bjorn Helgaas <helgaas@kernel.org>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: roy.zang@nxp.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, minghuan.Lian@nxp.com,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, mingkai.hu@nxp.com
Subject: Re: [PATCH -next] pci/controller/dwc: convert comma to semicolon
Date: Wed, 6 Jan 2021 13:07:22 -0600 [thread overview]
Message-ID: <20210106190722.GA1327553@bjorn-Precision-5520> (raw)
In-Reply-To: <20201216131944.14990-1-zhengyongjun3@huawei.com>
On Wed, Dec 16, 2020 at 09:19:44PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
Looks like a good fix, but read this about the changelog title:
https://lore.kernel.org/r/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index 84206f265e54..917ba8d254fc 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -178,7 +178,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
> pci->dev = dev;
> pci->ops = pcie->drvdata->dw_pcie_ops;
>
> - ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4),
> + ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4);
>
> pcie->pci = pci;
> pcie->ls_epc = ls_epc;
> --
> 2.22.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-06 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 13:19 [PATCH -next] pci/controller/dwc: convert comma to semicolon Zheng Yongjun
2021-01-06 19:07 ` Bjorn Helgaas [this message]
2021-01-15 11:36 ` Lorenzo Pieralisi
2021-03-07 18:36 ` Krzysztof Wilczyński
2021-03-22 12:43 ` Lorenzo Pieralisi
2021-03-22 13:40 ` Roy Zang
2021-03-22 14:44 ` Lorenzo Pieralisi
2021-03-22 15:25 ` Roy Zang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106190722.GA1327553@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=roy.zang@nxp.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).