From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20E08C433E0 for ; Fri, 8 Jan 2021 00:57:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC799236F9 for ; Fri, 8 Jan 2021 00:57:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC799236F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S+2rzJB0q8JMYMy0/qAXPAI3wN2UuuVvw4Hki+2kOL0=; b=00GB6HRrZgTCaDX2fxgYoaqGs gJgpoF9dn6IDsiNBzI9lADFjp7k7L5pkXimHNPhfT3csFBabE3sAmv9Q35z9hy383vYmK39BVZncD lkMVpLAJf2G2lXhfm9RZtpeBZkB31A6EiCibZ0aMRPPk0Blt5IOMH+5G/sJuC5/Tvbzq0/3oaJVe0 YHY7gk3nadzTMXkyYzHlPZks1M5qwr0s9dqfuxD4qqysd67YQErrkv5OQE2xlIbJKrO96mO0fL+YV /oT7ieQ6GTdRY+2M6b2tOJlzCxybGb5otQkD2QTa7+qwprfuRJ2x6xV7A5kbu7Arehu5pfbIbdwrk bdYxvrwCA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxg41-0005Uk-Dt; Fri, 08 Jan 2021 00:55:37 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxg3y-0005U6-Id for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2021 00:55:36 +0000 Received: by mail-pf1-x432.google.com with SMTP id t22so5171760pfl.3 for ; Thu, 07 Jan 2021 16:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Mzp+TKeYFNUCiao7ntDagpd86LmNj82kXWV1cqQ1gNI=; b=JeJ1X0pCi75b4g3kj1TGG6/QZXo7nahPOMSU99vr/5fWNWQzc8j8qvv5Abn/cPgiMe 29wPh9yxax0MhLxicw0fS9B4dACTTtrPJURsBfa8BFNFgE8VxoZglovipeft/ILmyiS9 ntuNx5mysRoXl6Lb/CHC4FHcTrsBzs8KgARelCj2SIqGaWInEj6XUjIftItKoO9k9zmm IOH24gnezg8of17ZuvACN2z9DghDEULLUHTCdOWS+2dENlTITRPRIDF+tLkEeGzARXVG IreZ/WS0k5u8Vz89TMPxcfX+C332ScQR2AwQBmlUqPRnRqNI5FKxr5g07njeH+pT04Al wU8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Mzp+TKeYFNUCiao7ntDagpd86LmNj82kXWV1cqQ1gNI=; b=Be1btQTjwDe7jxmjpw6kU3kyrHbPRfqDe2yGhwnAkcgl6iXuyMjfOEsbWD+wwSq2tW +8NfcyReVYyGb/2EuSFACgAQi/lw7mAyKBbAszycXixwqEgwAWuepmBH+G6zr4rexnMR JX0RJy7YQQQUgPJovO538vyeAlDPoMJjz7a7nxzm5372Mp/bDKWPyc9bq3k5KmGbSVNq yqX8YBrUFIIZzwgzy5EjJV4JUfqKNZjWD0Ul6EhXwTI0G9Hv14AXePLKN4kjMX/aD6aB l5QENkWOc1KcgHpE+xMHAzflM2Vy7oeB0RcOLyHLt/UgSVUae4JDEzSO8uHOG1HbGrSF jlMA== X-Gm-Message-State: AOAM530UWdj7FCxokQz+3n8uOY7EfE/C06IDyTSMDUfLIpi7cBdTQYgy VotnW9v3IsEpX+t3JMIRLgnsTw== X-Google-Smtp-Source: ABdhPJzrM7Mp9eqqFecmQeZMe9QR7J6u4/eKLpiMSe8b2309T4WQ1gv3hByU9Msd3unojKGQQrZNLg== X-Received: by 2002:a63:1322:: with SMTP id i34mr4417255pgl.282.1610067332432; Thu, 07 Jan 2021 16:55:32 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id x15sm6524892pfn.118.2021.01.07.16.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 16:55:31 -0800 (PST) Date: Thu, 7 Jan 2021 17:55:30 -0700 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v6 23/26] coresight: etm4x: Add support for sysreg only devices Message-ID: <20210108005530.GG43045@xps15> References: <20210107123859.674252-1-suzuki.poulose@arm.com> <20210107123859.674252-24-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210107123859.674252-24-suzuki.poulose@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_195534_962310_642EB808 X-CRM114-Status: GOOD ( 29.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: anshuman.khandual@arm.com, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 07, 2021 at 12:38:56PM +0000, Suzuki K Poulose wrote: > Add support for devices with system instruction access only. > They don't have a memory mapped interface and thus are not > AMBA devices. System register access is not permitted to > TRCPDCR and thus skip access to them. > > Cc: Mike Leach > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > Changes since v5: > - Rebased to accommodate check_arch_features(). > Added comments to explain why we don't pass PID for system > register based devices. > Changes since v4 > - Add "remove" callback for platform_driver. > - Dropped Reviewed-by tag from Mathieu due to the above > > Changes since v3 > - Improve comment over "TRCPDCR" usage with sysreg > - Rename etm_xx => etm4_xx > - Update the compatible to "arm,coresight-etm4x-sysreg" > --- > .../coresight/coresight-etm4x-core.c | 68 +++++++++++++++++-- > 1 file changed, 63 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > index f4fbb65b4cc1..34a6cdff75e7 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1736,9 +1737,6 @@ static int etm4_probe(struct device *dev, void __iomem *base, u32 etm_pid) > return -ENOMEM; > } > > - if (fwnode_property_present(dev_fwnode(dev), "qcom,skip-power-up")) > - drvdata->skip_power_up = true; > - > drvdata->base = base; > > spin_lock_init(&drvdata->spinlock); > @@ -1762,6 +1760,11 @@ static int etm4_probe(struct device *dev, void __iomem *base, u32 etm_pid) > if (!drvdata->arch) > return -EINVAL; > > + /* TRCPDCR is not accessible with system instructions. */ > + if (!desc.access.io_mem || > + fwnode_property_present(dev_fwnode(dev), "qcom,skip-power-up")) > + drvdata->skip_power_up = true; > + > etm4_init_trace_id(drvdata); > etm4_set_default(&drvdata->config); > > @@ -1820,6 +1823,25 @@ static int etm4_probe_amba(struct amba_device *adev, const struct amba_id *id) > return ret; > } > > +static int etm4_probe_platform_dev(struct platform_device *pdev) > +{ > + int ret; > + > + pm_runtime_get_noresume(&pdev->dev); > + pm_runtime_set_active(&pdev->dev); > + pm_runtime_enable(&pdev->dev); > + > + /* > + * System register based devices could match the > + * HW by reading appropriate registers on the HW > + * and thus we could skip the PID. > + */ > + ret = etm4_probe(&pdev->dev, NULL, 0); > + > + pm_runtime_put(&pdev->dev); > + return ret; > +} > + > static struct amba_cs_uci_id uci_id_etm4[] = { > { > /* ETMv4 UCI data */ > @@ -1869,6 +1891,17 @@ static int __exit etm4_remove_amba(struct amba_device *adev) > return 0; > } > > +static int __exit etm4_remove_platform_dev(struct platform_device *pdev) > +{ > + int ret = 0; > + struct etmv4_drvdata *drvdata = dev_get_drvdata(&pdev->dev); > + > + if (drvdata) > + ret = etm4_remove_dev(drvdata); > + pm_runtime_disable(&pdev->dev); > + return ret; > +} > + > static const struct amba_id etm4_ids[] = { > CS_AMBA_ID(0x000bb95d), /* Cortex-A53 */ > CS_AMBA_ID(0x000bb95e), /* Cortex-A57 */ > @@ -1901,6 +1934,21 @@ static struct amba_driver etm4x_amba_driver = { > .id_table = etm4_ids, > }; > > +static const struct of_device_id etm4_sysreg_match[] = { > + { .compatible = "arm,coresight-etm4x-sysreg" }, > + {} > +}; > + > +static struct platform_driver etm4_platform_driver = { > + .probe = etm4_probe_platform_dev, > + .remove = etm4_remove_platform_dev, > + .driver = { > + .name = "coresight-etm4x", > + .of_match_table = etm4_sysreg_match, > + .suppress_bind_attrs = true, > + }, > +}; > + > static int __init etm4x_init(void) > { > int ret; > @@ -1913,16 +1961,26 @@ static int __init etm4x_init(void) > > ret = amba_driver_register(&etm4x_amba_driver); > if (ret) { > - pr_err("Error registering etm4x driver\n"); > - etm4_pm_clear(); > + pr_err("Error registering etm4x AMBA driver\n"); > + goto clear_pm; > } > > + ret = platform_driver_register(&etm4_platform_driver); > + if (!ret) > + return 0; > + > + pr_err("Error registering etm4x platform driver\n"); > + amba_driver_unregister(&etm4x_amba_driver); > + > +clear_pm: > + etm4_pm_clear(); > return ret; > } > > static void __exit etm4x_exit(void) > { > amba_driver_unregister(&etm4x_amba_driver); > + platform_driver_unregister(&etm4_platform_driver); Good catch. Reviewed-by: Mathieu Poirier > etm4_pm_clear(); > } > > -- > 2.24.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel