From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F17B9C433DB for ; Fri, 8 Jan 2021 01:11:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C1D623447 for ; Fri, 8 Jan 2021 01:11:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C1D623447 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZAIeU28nvmBOjjQ7DHVDEMnlg9x/deAUC9UqGn4R8Y4=; b=gPnlZ6nZ6tEfE4be27y4n3RQv lN5LYPUXYNMLBKAPMt16qL7VQ5OIc6NQOuDyV7oilTccE6Ws6YQ1e9PPfMtCr0JOwXCmgXolFRCXh cTloekm5Vb2z6hnCFc/91HSywjF8IoWw4Rq+8YGkQFS96d7UbDIXg2KB5CBC03Ahb2mKvn+8Fv1FM kKX899LSeHvDbOurvGDii4NOGJRdSkD5cuiIiB7WRmy1ldHg4PnSmKE8asevALPw94KXwmBwvulLK q9yUNzkvfq4ZxGsMbJyf79wcjlukL5x+M0DZLAimz1hrtzwXBjobceYhmAEEsUYgqU9+iGkcVviVq OTNjIO5gQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxgHD-00074X-3V; Fri, 08 Jan 2021 01:09:15 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxgHA-00073s-Mz for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2021 01:09:13 +0000 Received: by mail-pg1-x536.google.com with SMTP id n7so6575606pgg.2 for ; Thu, 07 Jan 2021 17:09:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3s0tWg/+h/coov5XuJdVQbTVm+GIFoyKRvTW1DF+MZw=; b=x5BSjhOE9fipibgX/YJ/Ako8BNNnt4Tgp5PggyjdqA+/nxteXeQgVfcJljZxB13OxS MLV1+Xar8eATjoIZrDi7pQWBpxszUIfBjTBnHjXMo7RJM4kNhnTxx2PbPx4SH2Ifpdgh fgB9VjisfP7jN9v9CxUFHRC3cZQwMPR0p771qXpW/8ULwiAujzXN1o/B0aGGcz//ZOLQ PQNsiNotKzb6zFpHxFzGs3Dls9KiS3JCrhnOaIrU8GyRet1sQBfKEMvYYR1JV2GSs6aC ydRADMev57SRAT72L7R2ZiAx28KOiOomqSwlgC6viGltWudkI8cyF/hKbuFm2hMEsUqU vUPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3s0tWg/+h/coov5XuJdVQbTVm+GIFoyKRvTW1DF+MZw=; b=JItqCTAWDVTPAzmJi4jYYo6xHZFLuUN/aaGL6SaGCBiPMN3BNgABAtOtasYUUXrJXA PtEDP8H/8eXBFba8/Kx9fwpqoKGqIkwM6NKWXm1NSwa4mAvUrpzOFAOpS9SAZDG1zmC5 skeDPL1CctwD2hOosYNYyxcxPB+ByuWcr9IDI218c0H/o5/dZmgjX4eYT1SLHXaa38wC IbqHTfaqQAf6it9CEYB76wgvRQtSUqdkHGz86/uVyf7dOpxW0oL9v2ehHNMtUFCqWTTB u1lh2H5D4rNeF66A0qWjSHkuXo16HlnfsDWtH0T/kYoCcGrNk7Juj5pAJceRLlIC5WqF SWyg== X-Gm-Message-State: AOAM531IlwAvB9i7M5DLHtR0MNCanN1mrgneZAYzydIxnKr/xPFPvP3a UXWgBXo5n1tAM/bQANp3IxC2xQ== X-Google-Smtp-Source: ABdhPJx9l1LI1qijTbIvGNYHEax93tOpbjII9h7tN0GnQYCkRPM5vGUi30ivQWcwZmzb5UlZgTVV2w== X-Received: by 2002:aa7:82cc:0:b029:19e:1328:d039 with SMTP id f12-20020aa782cc0000b029019e1328d039mr4618622pfn.70.1610068149882; Thu, 07 Jan 2021 17:09:09 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id x127sm6467502pfb.74.2021.01.07.17.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 17:09:08 -0800 (PST) Date: Thu, 7 Jan 2021 18:09:07 -0700 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v6 00/26] coresight: etm4x: Support for system instructions Message-ID: <20210108010907.GJ43045@xps15> References: <20210107123859.674252-1-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210107123859.674252-1-suzuki.poulose@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_200912_776128_FD7DFA4B X-CRM114-Status: GOOD ( 38.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: anshuman.khandual@arm.com, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suzuki, On Thu, Jan 07, 2021 at 12:38:33PM +0000, Suzuki K Poulose wrote: > CoreSight ETMv4.4 obsoletes memory mapped access to ETM and > mandates the system instructions for registers. > This also implies that they may not be on the amba bus. > Right now all the CoreSight components are accessed via memory > map. Also, we have some common routines in coresight generic > code driver (e.g, CS_LOCK, claim/disclaim), which assume the > mmio. In order to preserve the generic algorithms at a single > place and to allow dynamic switch for ETMs, this series introduces > an abstraction layer for accessing a coresight device. It is > designed such that the mmio access are fast tracked (i.e, without > an indirect function call). > > This will also help us to get rid of the driver+attribute specific > sysfs show/store routines and replace them with a single routine > to access a given register offset (which can be embedded in the > dev_ext_attribute). This is not currently implemented in the series, > but can be achieved. > > Further we switch the generic routines to work with the abstraction. > With this in place, we refactor the etm4x code a bit to allow for > supporting the system instructions with very little new code. > > We use TRCDEVARCH for the detection of the ETM component, which > is a standard register as per CoreSight architecture, rather than > the etm specific id register TRCIDR1. This is for making sure > that we are able to detect the ETM via system instructions accurately, > when the the trace unit could be anything (etm or a custom trace unit). > To keep the backward compatibility for any existing broken > impelementation which may not implement TRCDEVARCH, we fall back to TRCIDR1. > Also this covers us for the changes in the future architecture [0]. > > Also, v8.4 self-hosted tracing extensions (coupled with ETMv4.4) adds > new filtering registers for trace by exception level. So on a v8.4 > system, with Trace Filtering support, without the appropriate > programming of the Trace filter registers (TRFCR_ELx), tracing > will not be enabled. This series also includes the TraceFiltering > support to cover the ETM-v4.4 support. > > The series has been mildly tested on a model for system instructions. > I would really appreciate any testing on real hardware. I have queued your work in my local tree. I will have a final pass before pushing to coresight-next tomorrow or on Monday. Thanks, Mathieu > > Applies on coresight/next. A tree is available here [1]. > > [0] https://developer.arm.com/docs/ddi0601/g/aarch64-system-registers/trcidr1 > [1] https://gitlab.arm.com/linux-arm/linux-skp coresight/etm/sysreg-v6 > > Changes since v5: > - Rebased on to coresight/next. > - Moved trcdevarch to mgmt/ in sysfs and updated the sysfs ABI > document (Mike Leach) > - New patch : Moved the etm4_check_arch_features to run on the CPU, since > the PID of the ETM has to be read on the CPU and is unavailable > otherwise. > > Changes since v4: > - Fix typo in commit description for the patches 02 & 15 > - Refactor the AMBA device "remove" call back for use with > paltform_driver. (patch 21). Thus remove Review tag by Mathieu, > even though the changes are minimal. > - Added "remove" callback for platform_driver in patch 22, removed > Review tag by Mathieu > - Add 'U' suffix for constants in Patch 24 (Catalin) > - Fixed field extraction in Patch 25 > > Changes since v3: > - Device tree compatible changed to etm4x > - Use etm4x_** instead of generalizing etm_ in etm4x driver. > - Added v8.4 self hosted trace support patches, reworked > from Jonathan's series. > - Dropped queued patches. > - Expose TRCDEVARCH via trcidr, as this will be needed for > the userspace tools to determine the trace major/minor > arch versions. > - Remove csa argument to read()/write() (Mathieu) > - Fix secure exception mask calculation (Mathieu) > - Fix various coding style comments (Mathieu) > (See individual patches for change log) > > Changes since V2: > - Several fixes to the ETM register accesses. Access a register > when it is present. > - Add support for TRCIDR3.NUMPROCS for v4.2+ > - Drop OS lock detection. Use software lock only in case of mmio. > - Fix issues with the Exception level masks (Mike Leach) > - Fall back to using TRCIDR1 when TRCDEVARCH is not "present" > - Use a generic notion of ETM architecture (rather than using > the encoding as in registers) > - Fixed some checkpatch issues. > - Changed the dts compatible string to "arm,coresight-etm-sysreg" > (Mike Leach) > > Changes since V1: > - Flip the switch for iomem from no_iomem to io_mem in csdev_access. > - Split patches for claim/disclaim and CS_LOCK/UNLOCK conversions. > - Move device access initialisation for etm4x to the target CPU > - Cleanup secure exception level mask handling. > - Switch to use TRCDEVARCH for ETM component discovery. This > is for making > - Check the availability of OS/Software Locks before using them. > > Known issues: > Checkpatch failure for "coresight: etm4x: Add sysreg access helpers" : > > ERROR: Macros with complex values should be enclosed in parentheses > #121: FILE: drivers/hwtracing/coresight/coresight-etm4x.h:153: > +#define CASE_READ(res, x) \ > + case (x): { (res) = read_etm4x_sysreg_const_offset((x)); break; } > > I don't know a way to fix the warning without loosing the code > readability, which I believe is crucial for such a construct. > > > > Jonathan Zhou (2): > arm64: Add TRFCR_ELx definitions > coresight: Add support for v8.4 SelfHosted tracing > > Suzuki K Poulose (24): > coresight: etm4x: Handle access to TRCSSPCICRn > coresight: etm4x: Skip accessing TRCPDCR in save/restore > coresight: Introduce device access abstraction > coresight: tpiu: Prepare for using coresight device access abstraction > coresight: Convert coresight_timeout to use access abstraction > coresight: Convert claim/disclaim operations to use access wrappers > coresight: etm4x: Always read the registers on the host CPU > coresight: etm4x: Convert all register accesses > coresight: etm4x: Add commentary on the registers > coresight: etm4x: Add sysreg access helpers > coresight: etm4x: Define DEVARCH register fields > coresight: etm4x: Check for Software Lock > coresight: etm4x: Cleanup secure exception level masks > coresight: etm4x: Clean up exception level masks > coresight: etm4x: Handle ETM architecture version > coresight: etm4x: Detect access early on the target CPU > coresight: etm4x: Use TRCDEVARCH for component discovery > coresight: etm4x: Expose trcdevarch via sysfs > coresight: etm4x: Add necessary synchronization for sysreg access > coresight: etm4x: Detect system instructions support > coresight: etm4x: Refactor probing routine > coresight: etm4x: Run arch feature detection on the CPU > coresight: etm4x: Add support for sysreg only devices > dts: bindings: coresight: ETM system register access only units > > .../testing/sysfs-bus-coresight-devices-etm4x | 8 + > .../devicetree/bindings/arm/coresight.txt | 5 +- > arch/arm64/include/asm/sysreg.h | 11 + > drivers/hwtracing/coresight/coresight-catu.c | 12 +- > drivers/hwtracing/coresight/coresight-core.c | 122 ++- > .../hwtracing/coresight/coresight-cti-core.c | 18 +- > drivers/hwtracing/coresight/coresight-etb10.c | 10 +- > .../coresight/coresight-etm3x-core.c | 9 +- > .../coresight/coresight-etm4x-core.c | 805 ++++++++++++------ > .../coresight/coresight-etm4x-sysfs.c | 46 +- > drivers/hwtracing/coresight/coresight-etm4x.h | 498 ++++++++++- > .../hwtracing/coresight/coresight-funnel.c | 7 +- > .../coresight/coresight-replicator.c | 13 +- > drivers/hwtracing/coresight/coresight-stm.c | 4 +- > .../hwtracing/coresight/coresight-tmc-core.c | 16 +- > .../hwtracing/coresight/coresight-tmc-etf.c | 10 +- > .../hwtracing/coresight/coresight-tmc-etr.c | 4 +- > drivers/hwtracing/coresight/coresight-tpiu.c | 31 +- > include/linux/coresight.h | 225 ++++- > 19 files changed, 1423 insertions(+), 431 deletions(-) > > -- > 2.24.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel