From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4E2EC433E0 for ; Mon, 11 Jan 2021 14:29:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FA4322473 for ; Mon, 11 Jan 2021 14:29:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FA4322473 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X1qVni+oJuqtk3A6X1EwqnRlqrUlIBqJmYsyroK+1cM=; b=dm1J12xjKIU0vPAi1LpouPkvK rouo61ot3j2L/rZLD8MtrN4ebIfTp7RrqkPRJ0yy71aYCjMwZxpVS8dWCYPdyj5ZM1JORWd3z/8fg hETpGb8b+k5VIyHRPgavZ6NJSmGEcIbxP5X1QFIQCpBWckyOWKppzJBNGQn61sdLRrc6NFetKjzkv A0/qZt0SFUbwB5ijhMnFISwy1I1prSVYm2+2hL/TaKPwVGCjhbdv/iwQ8MkPk5Jnbt3cuKs35rMid sSgLeuCFdsZvWtE2SKfiIhwwJrUxFcEKYaZ4uC6hZCITAMU1WWdlb0/d78QRV/lZ6zfMF0An+IfIt 0A49YhTZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyyB3-0005m3-U6; Mon, 11 Jan 2021 14:28:14 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyy8Q-0004C0-9J for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 14:25:32 +0000 Received: by mail-lf1-x129.google.com with SMTP id m12so37961392lfo.7 for ; Mon, 11 Jan 2021 06:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=smCy1Yjkgz+gZDtvnre1/QglxuwwJh77VQyDG7f7TRE=; b=ZUuH8XyUNwUDj/ax6jtLuay1zUfAHTmdAj5OEzyXghQZcVky5ep8DZqIxsMBY2n40g c06X17Dy/0BohuoUCgTPEfnF1EKIHFZ+Uin5pZQVE8W7Zie1OKBDts7Fw6CAJ8oUkF0+ r/h5M78XOTQOyOFRvsAhMPXJIxAmIhjxGdlOX9Hi3+nX64JjFSDQLgrhZZq82sDae6ST Awd6jayAfyX09bC+vlJFcEgIfQybESEifE9Tuf2F/hjEouxgD3ozygW24IF04Z8y8ynU N9j5pf85cu+j4nquHHa/0nuHULcDcB/q8AmB2mg3d0OdxGBUSWwN2TzUtKlGvU/bY+eL /P7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=smCy1Yjkgz+gZDtvnre1/QglxuwwJh77VQyDG7f7TRE=; b=J2oDDf4bDxDatSmcvrF8IspX0XIy5XR6Y+kis8GU/6mjnu/+SDIRWlr2/5Va+Cbtwd cjYYzvCszrw34OW1G0zi4YosuE7m5EeFtCrN3pPknKqnMQyPwjL0Aw1uIMt3vdk6GFTm b6Y/CVlOvrU3pJ5Uli3hjqmnIarDbFhZB3Z1unuTnV3/SqXiLDFm+AdwMr08AciZVqZv +hl4IF8sFbxIvKXzitF+FAyNUbvgEXYXdVJBchGIrjX8cvsVcQfIZUFAZhGI9qLPVQHw PPnnO9mQHaRq1fbwp81FjucGvtjU4M5IaVuk2ER7uwdE8VsnJbzVkR4UW4saVyxSJGup Ub2g== X-Gm-Message-State: AOAM53158Yh37DToUd3ceXQLoTawL/t6C+suN8uKT7BY2Ev5Iaq6iOXf RsTVrVpejB/zl3FVPxrbKhUFOA== X-Google-Smtp-Source: ABdhPJyUEIHi1OeJLqcYRsOQdNKTnpdC0urVnyRPLnSVMvyEGUufCwFJNYt2YI+Kmx+uW4swx/YObw== X-Received: by 2002:a19:f601:: with SMTP id x1mr7048733lfe.256.1610375129044; Mon, 11 Jan 2021 06:25:29 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id b7sm3440379ljf.76.2021.01.11.06.25.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 06:25:28 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id B18BE102238; Mon, 11 Jan 2021 17:25:33 +0300 (+03) Date: Mon, 11 Jan 2021 17:25:33 +0300 From: "Kirill A. Shutemov" To: Will Deacon Subject: Re: [PATCH v2 2/3] mm: Allow architectures to request 'old' entries when prefaulting Message-ID: <20210111142533.oulduqd76mkpdkst@box> References: <20210108171517.5290-1-will@kernel.org> <20210108171517.5290-3-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210108171517.5290-3-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_092530_452193_CB728142 X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Jan Kara , Minchan Kim , Catalin Marinas , Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vinayak Menon , "Kirill A . Shutemov" , Andrew Morton , Linus Torvalds , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 08, 2021 at 05:15:16PM +0000, Will Deacon wrote: > diff --git a/mm/filemap.c b/mm/filemap.c > index c1f2dc89b8a7..0fb9d1714797 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -3051,14 +3051,18 @@ vm_fault_t filemap_map_pages(struct vm_fault *vmf, > if (!pte_none(*vmf->pte)) > goto unlock; > > + /* We're about to handle the fault */ > + if (vmf->address == address) { > + vmf->flags &= ~FAULT_FLAG_PREFAULT; > + ret = VM_FAULT_NOPAGE; > + } else { > + vmf->flags |= FAULT_FLAG_PREFAULT; > + } > + Do we need to restore the oririnal status of the bit once we are done? -- Kirill A. Shutemov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel