From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D2DAC433DB for ; Mon, 11 Jan 2021 14:48:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CE8B2255F for ; Mon, 11 Jan 2021 14:48:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CE8B2255F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SkcGbf4hTQ9WXrVrM5K93XxfbU68ES+qFGekJke0Fs8=; b=LoEeGeHykY5vXbNNGIstkKSQt WoLC8uHar3gZlF9UB5X0ZDMceJssswmwhhs6QPY8xuvU+9pH5hE9hMx4AWW6WoqHKS1k8Hfskzgko O4SleahR2cg0ZGbOYkrMZFcMXNoF2NoZOPKbz8IXWSby7rMyRT2MvUlKy4mQMK53XGTzjZCyjK9Tv lfA4QsBppebVkN4Rc51Jy0QqWKHSvkDVpLz5FSoZwOw24E7DFKmUP++8jE1VfPcvwwFnYT3U8pyUP /ywyalkO3fzD78Ks+C+aGKqclT9tBqS9IDVo9CzD2Xu5FUtuAkGQ+ufxIpG4OKXj9JkmWnrMPiPch PpQstv2cw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyyTS-0003cc-OL; Mon, 11 Jan 2021 14:47:14 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyyTO-0003ap-RM for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 14:47:11 +0000 Received: by mail-lf1-x12c.google.com with SMTP id a12so38092748lfl.6 for ; Mon, 11 Jan 2021 06:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zxHRMpq7QR1wTdVkqAqtbQPLo3QS4yb+Ze8e4uPBmNg=; b=0PsvqXhwBjpII2h1bnDibLJ2U5fUycGLnHN4ZjykVglnBTVIW3IqkafYB2IF2LFDW7 EALTfYs0RX65gcyD+YxzVmEdo9cve5qgjlu27kJtEv+sFSql9WNbWuWgZFeI30wNNM1n ccN3u/D611TaDas+WamL8PLuzYl7sQW7hSilaEzn5/Z1CI6RpkLYBP/qxddDQN0Aitqy xX/WMlG03MwLCRTbY7cmYN1aW7WNA6DwxBjpMqGewl9ppY7prGAQNQqU3i7H8YZv3uui Ai788U1Pedc9u9MagNyM4mKPvgqpesGB/q6wiYLSBADStJcYwgLm5t8Mr4e8cg9jI4Ew N0vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zxHRMpq7QR1wTdVkqAqtbQPLo3QS4yb+Ze8e4uPBmNg=; b=OV06jSJjHA9Ax5RTYV4znXO+gj0W0ciMECGdYsMQ0c+GyRZ2pJI30fwAYe4bcfWq0h Y7XG7x7ceSOO/9jmXJYQ6mQprV8nh0cpeFKmi7WYkLIGfdibnJf8vkw10vlGzlg6m7u9 lI4Zoyk0Jg/ehlSHZnpAhJ3NknQNoATSPuNsLWqzuqYVRLhkdSi8Aj11wtj8rgvN9AVx SNCd0kedWEdzqiG5xHWhpJp8HslF+feu/8lFOFQm1Eip8+jhJ17Qs7+c+eVk4Uq56Mfh /eXRv97JwPROASlosNEbYboJfZeKy4DoB9KiGqrGrLj1hA2oJso1UiDONm7OSosQOnzA Tqnw== X-Gm-Message-State: AOAM533e6CMlJvPby02lAL8g1rWQHvSRdvkXOAbUH86Q6LRVl0+kUxzA mL9BPwgDe6CYMvMM0mnuFl+BBg== X-Google-Smtp-Source: ABdhPJxYY14f3Jmu7iJJBny100aDrdzfO1NYkQ81PZGiOkzjDhqDGjIefnqaZIh7bpsBBA02i2rMvQ== X-Received: by 2002:ac2:58e8:: with SMTP id v8mr6725858lfo.630.1610376428654; Mon, 11 Jan 2021 06:47:08 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id w6sm1168lfn.222.2021.01.11.06.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 06:47:08 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 47434102238; Mon, 11 Jan 2021 17:47:13 +0300 (+03) Date: Mon, 11 Jan 2021 17:47:13 +0300 From: "Kirill A. Shutemov" To: Will Deacon Subject: Re: [PATCH v2 2/3] mm: Allow architectures to request 'old' entries when prefaulting Message-ID: <20210111144713.3akhv75xzk7u6rgu@box> References: <20210108171517.5290-1-will@kernel.org> <20210108171517.5290-3-will@kernel.org> <20210111142533.oulduqd76mkpdkst@box> <20210111143742.GD7642@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210111143742.GD7642@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_094710_953973_EA9BEA4F X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Jan Kara , Minchan Kim , Catalin Marinas , Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vinayak Menon , "Kirill A . Shutemov" , Andrew Morton , Linus Torvalds , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 11, 2021 at 02:37:42PM +0000, Will Deacon wrote: > On Mon, Jan 11, 2021 at 05:25:33PM +0300, Kirill A. Shutemov wrote: > > On Fri, Jan 08, 2021 at 05:15:16PM +0000, Will Deacon wrote: > > > diff --git a/mm/filemap.c b/mm/filemap.c > > > index c1f2dc89b8a7..0fb9d1714797 100644 > > > --- a/mm/filemap.c > > > +++ b/mm/filemap.c > > > @@ -3051,14 +3051,18 @@ vm_fault_t filemap_map_pages(struct vm_fault *vmf, > > > if (!pte_none(*vmf->pte)) > > > goto unlock; > > > > > > + /* We're about to handle the fault */ > > > + if (vmf->address == address) { > > > + vmf->flags &= ~FAULT_FLAG_PREFAULT; > > > + ret = VM_FAULT_NOPAGE; > > > + } else { > > > + vmf->flags |= FAULT_FLAG_PREFAULT; > > > + } > > > + > > > > Do we need to restore the oririnal status of the bit once we are done? > > I can certainly add that, although it doesn't look like we do that for > vmf->pte, so it's hard to tell what the rules are here. It certainly feels > odd to restore some fields but not others, as it looks like vmf->address > will be out-of-whack with vmf->pte when filemap_map_pages() returns. Am I > missing something? Unlike vmf->flags or vmf->address, vmf->pte is not going to be reused. finish_fault() will overwrite it. Yeah, it's messy. -- Kirill A. Shutemov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel