From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DA5AC433E0 for ; Fri, 15 Jan 2021 19:15:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F586221E2 for ; Fri, 15 Jan 2021 19:15:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F586221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y2MmEvuoRN4cMe6uC2p7YVeuv/0OsYdhtcCGGVM9QuQ=; b=FsS9eYv49tZ0JEhFaWmAmKCxY qKAq3rr89xS1cbHB3fuPO7jxBalrppQvk3wCVlb8s5+N0yzut2Y1vXK+v/VYW4vSy3W4N2LQ0JIos Cnb5iAluLjbeOvgwX+FocYqt+4+JafWz97B1+c505JPuUz1OgD+ep55d1yDQQkQqWHHmdjhGBiwuy OQ1rf3GIREXLA7+NfjBUmEMyl9XFPIVKKpipYwn7SCvBLnytpQUqY1JR/w1DaXrPR7mVfv5LWlAfE OTcfC+heKtGOOcPHaJvWXfDiTmE/zQp8p9wdGW0ISJLRIxekiqGnM0+vv73/Xaqq3wexW1Ikh463B RH4Ul1DuQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0UXy-0007t1-8e; Fri, 15 Jan 2021 19:14:10 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0UXw-0007sr-7y for linux-arm-kernel@merlin.infradead.org; Fri, 15 Jan 2021 19:14:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IVedqcv3WoVPYMDZbzhBkpMqbWr911GgiHAcmYH11LA=; b=BsbzfUSgq4nJPi+olccG/KkXDz XaPCEBWVdyy57RxnVW7shSR/2DPhf3PWF2XkzYnvkO3DvS4hWwhixv+r+ex5NE0RlxupByoRFf8i4 cvpUrI0+NkjT6woPWk894gDJj/2QM1QMvb8hsnFuifAFWX3c2KoB03lqP4HhYyhIjzzDeN5BEDgWa i6GHWJ3aQpQ24aSatIQ+JMnI/suQNGXV4X5G1qrAFUBfc7xknAQ9wW1s6Z4UmbFQxgPXUvlTBcbcP t+njtUhoAkVv1NII1bUgOhCrqpHlBXoLf977ub4vNCxdbE1ns3WWb2sBFZiXrZL9BCuWRfiYCN5Xw h3rtDkow==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1l0UX8-009KfG-0b; Fri, 15 Jan 2021 19:13:54 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 3A54B40522; Fri, 15 Jan 2021 16:13:51 -0300 (-03) Date: Fri, 15 Jan 2021 16:13:51 -0300 From: Arnaldo Carvalho de Melo To: Mathieu Poirier Subject: Re: [PATCH] perf tools: Update OpenCSD to v1.0.0 Message-ID: <20210115191351.GF457607@kernel.org> References: <20210108142752.27872-1-james.clark@arm.com> <20210111165604.GA144935@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210111165604.GA144935@xps15> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Al Grant , Suzuki K Poulose , Peter Zijlstra , Jiri Olsa , coresight@lists.linaro.org, John Garry , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Alexander Shishkin , Ingo Molnar , James Clark , Leo Yan , Namhyung Kim , Will Deacon , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, Jan 11, 2021 at 09:56:04AM -0700, Mathieu Poirier escreveu: > On Fri, Jan 08, 2021 at 04:27:52PM +0200, James Clark wrote: > > Replace the OCSD_INSTR switch statement with an if to > > fix compilation error about unhandled values and avoid > > this issue again in the future. > > > > Add new OCSD_GEN_TRC_ELEM_SYNC_MARKER and > > OCSD_GEN_TRC_ELEM_MEMTRANS enum values to fix unhandled > > value compilation error. Currently they are ignored. > > > > Increase the minimum version number to v1.0.0 now > > that new enum values are used that are only present > > in this version. > > > > Signed-off-by: James Clark > > Cc: John Garry > > Cc: Will Deacon > > Cc: Mathieu Poirier > > Cc: Leo Yan > > Cc: Suzuki K Poulose > > Cc: Mike Leach > > Cc: Al Grant > > Cc: Peter Zijlstra > > Cc: Ingo Molnar > > Cc: Arnaldo Carvalho de Melo > > Cc: Mark Rutland > > Cc: Alexander Shishkin > > Cc: Jiri Olsa > > Cc: Namhyung Kim > > --- > > tools/build/feature/test-libopencsd.c | 4 ++-- > > tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 15 ++++----------- > > 2 files changed, 6 insertions(+), 13 deletions(-) > > > > diff --git a/tools/build/feature/test-libopencsd.c b/tools/build/feature/test-libopencsd.c > > index 1547bc2c0950..52c790b0317b 100644 > > --- a/tools/build/feature/test-libopencsd.c > > +++ b/tools/build/feature/test-libopencsd.c > > @@ -4,9 +4,9 @@ > > /* > > * Check OpenCSD library version is sufficient to provide required features > > */ > > -#define OCSD_MIN_VER ((0 << 16) | (14 << 8) | (0)) > > +#define OCSD_MIN_VER ((1 << 16) | (0 << 8) | (0)) > > #if !defined(OCSD_VER_NUM) || (OCSD_VER_NUM < OCSD_MIN_VER) > > -#error "OpenCSD >= 0.14.0 is required" > > +#error "OpenCSD >= 1.0.0 is required" > > #endif > > > > int main(void) > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > index cd007cc9c283..3f4bc4050477 100644 > > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > @@ -419,19 +419,10 @@ cs_etm_decoder__buffer_range(struct cs_etm_queue *etmq, > > packet->last_instr_subtype = elem->last_i_subtype; > > packet->last_instr_cond = elem->last_instr_cond; > > > > - switch (elem->last_i_type) { > > - case OCSD_INSTR_BR: > > - case OCSD_INSTR_BR_INDIRECT: > > + if (elem->last_i_type == OCSD_INSTR_BR || elem->last_i_type == OCSD_INSTR_BR_INDIRECT) > > packet->last_instr_taken_branch = elem->last_instr_exec; > > - break; > > - case OCSD_INSTR_ISB: > > - case OCSD_INSTR_DSB_DMB: > > - case OCSD_INSTR_WFI_WFE: > > - case OCSD_INSTR_OTHER: > > - default: > > + else > > packet->last_instr_taken_branch = false; > > - break; > > - } > > > > packet->last_instr_size = elem->last_instr_sz; > > > > @@ -572,6 +563,8 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( > > case OCSD_GEN_TRC_ELEM_EVENT: > > case OCSD_GEN_TRC_ELEM_SWTRACE: > > case OCSD_GEN_TRC_ELEM_CUSTOM: > > + case OCSD_GEN_TRC_ELEM_SYNC_MARKER: > > + case OCSD_GEN_TRC_ELEM_MEMTRANS: > > default: > > break; > > Reviewed-by: Mathieu Poirier > > Arnaldo please consider. Thanks, applied. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel