From: Maxime Ripard <maxime@cerno.tech>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Alistair Francis <alistair@alistair23.me>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Chen-Yu Tsai <wens@csie.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/19] dt-bindings: bluetooth: realtek: Switch to unevaluatedProperties
Date: Mon, 18 Jan 2021 11:15:01 +0100 [thread overview]
Message-ID: <20210118101501.mmlgsiyj5rulrpgk@gilmour> (raw)
In-Reply-To: <20210115013714.GA3798333@robh.at.kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1959 bytes --]
Hi Rob,
On Thu, Jan 14, 2021 at 07:37:14PM -0600, Rob Herring wrote:
> On Thu, Jan 14, 2021 at 12:35:24PM +0100, Maxime Ripard wrote:
> > additionalProperties prevent any property not explicitly defined in the
> > binding to be used. Yet, some serial properties like max-speed are valid
> > and validated through the serial/serial.yaml binding.
> >
> > Let's change additionalProperties to unevaluatedProperties to avoid
> > spurious warnings.
> >
> > Cc: Alistair Francis <alistair@alistair23.me>
> > Cc: Vasily Khoruzhick <anarsoul@gmail.com>
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> > Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> > index 4f485df69ac3..f4d4969d87f4 100644
> > --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> > @@ -37,7 +37,7 @@ properties:
> > required:
> > - compatible
> >
> > -additionalProperties: false
> > +unevaluatedProperties: false
>
> This would still fail because the serial schema is applied to the parent
> and this schema is applied to the child node. It's a common problem for
> how we've done bus schemas. We'd need to split them into 2 schemas and
> reference the child schema here. I'd rather not do that here because
> then we'd apply the schema twice assuming we keep bus schemas also
> applying the child schemas (which is good at least until we have schemas
> for *all* possible child devices).
I couldn't find what requires additionalProperties in the meta-schemas,
could you point me to what enforces it?
> We've handled this in other cases by just doing 'max-speed: true' here.
I will do that then, thanks!
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-18 10:17 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 11:35 [PATCH 01/19] dt-bindings: sunxi: Fix the pinecube compatible Maxime Ripard
2021-01-14 11:35 ` [PATCH 02/19] dt-bindings: iio: adc: Add AXP803 compatible Maxime Ripard
2021-01-14 20:10 ` Jernej Škrabec
2021-01-17 12:41 ` Jonathan Cameron
2021-01-14 11:35 ` [PATCH 03/19] dt-bindings: rtc: sun6i-a31-rtc: Loosen the requirements on the clocks Maxime Ripard
2021-01-14 20:11 ` Jernej Škrabec
2021-01-19 21:43 ` Alexandre Belloni
2021-01-14 11:35 ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro, gm7123 compatible Maxime Ripard
2021-01-14 20:14 ` Jernej Škrabec
2021-01-15 7:16 ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible Laurent Pinchart
2021-01-18 10:03 ` Maxime Ripard
2021-01-18 10:22 ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro, gm7123 compatible Chen-Yu Tsai
2021-01-18 10:39 ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible Laurent Pinchart
2021-01-18 10:38 ` Laurent Pinchart
2021-01-25 21:21 ` [PATCH 04/19] dt-bindings: bridge: simple: Add corpro, gm7123 compatible Rob Herring
2021-01-14 11:35 ` [PATCH 05/19] dt-bindings: bluetooth: realtek: Switch to unevaluatedProperties Maxime Ripard
2021-01-14 20:14 ` Jernej Škrabec
2021-01-14 22:54 ` Rob Herring
2021-01-15 1:37 ` Rob Herring
2021-01-18 10:15 ` Maxime Ripard [this message]
2021-01-22 14:40 ` Rob Herring
2021-01-14 11:35 ` [PATCH 06/19] ARM: dts: sunxi: Fix the LED node names Maxime Ripard
2021-01-14 20:33 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 07/19] ARM: dts: sunxi: Add missing backlight supply Maxime Ripard
2021-01-14 20:25 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 08/19] ARM: dts: sunxi: Fix CPU thermal zone node name Maxime Ripard
2021-01-14 20:34 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 09/19] ARM: dts: sunxi: Remove thermal zones without trip points Maxime Ripard
2021-01-14 20:36 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 10/19] ARM: dts: sun6i: primo81: Remove useless io-channel-cells Maxime Ripard
2021-01-14 20:37 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 11/19] ARM: dts: sun8i: nanopi-r1: Fix GPIO regulator state array Maxime Ripard
2021-01-14 20:38 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 12/19] ARM: dts: sun8i-s3: impetus: Fix the USB PHY ID detect GPIO properties Maxime Ripard
2021-01-14 20:39 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 13/19] ARM: dts: sun8i-s3: pinecube: Fix Display Engine DTC warnings Maxime Ripard
2021-01-14 20:40 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 14/19] ARM: dts: sun8i-a83t: Remove empty CSI port Maxime Ripard
2021-01-14 20:40 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 15/19] ARM: dts: sun8i-a33: sina33: Add missing panel power supply Maxime Ripard
2021-01-14 20:41 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 16/19] arm64: dts: allwinner: h6: Use - instead of @ for DT OPP entries Maxime Ripard
2021-01-14 20:42 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 17/19] arm64: dts: allwinner: pinephone: Remove useless light sensor supplies Maxime Ripard
2021-01-14 20:44 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 18/19] arm64: dts: allwinner: pinetab: Fix the panel compatible Maxime Ripard
2021-01-14 20:46 ` Jernej Škrabec
2021-01-14 11:35 ` [PATCH 19/19] arm64: dts: allwinner: pine-h64: Fix typos in BT GPIOs Maxime Ripard
2021-01-14 20:49 ` Jernej Škrabec
2021-01-14 20:07 ` [PATCH 01/19] dt-bindings: sunxi: Fix the pinecube compatible Jernej Škrabec
2021-01-15 2:41 ` Chen-Yu Tsai
2021-01-15 9:31 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118101501.mmlgsiyj5rulrpgk@gilmour \
--to=maxime@cerno.tech \
--cc=alistair@alistair23.me \
--cc=anarsoul@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).