From: Rob Herring <robh@kernel.org>
To: peng.fan@nxp.com
Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
linux-mmc@vger.kernel.org, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 1/4] dt-bindings: mmc: fsl-imx-esdhc: add pinctrl bindings
Date: Fri, 22 Jan 2021 10:38:11 -0600 [thread overview]
Message-ID: <20210122163811.GA926374@robh.at.kernel.org> (raw)
In-Reply-To: <1611198593-16287-2-git-send-email-peng.fan@nxp.com>
On Thu, Jan 21, 2021 at 11:09:50AM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add pinctrl bindings for fsl-imx-esdhc yaml
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../bindings/mmc/fsl-imx-esdhc.yaml | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index 802c9df23752..f91e97cd7d4e 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -103,6 +103,31 @@ properties:
> Only eMMC HS400 mode need to take care of this property.
> default: 0
>
> + pinctrl-0:
> + minItems: 1
> + maxItems: 2
> +
> + pinctrl-1:
> + minItems: 1
> + maxItems: 2
> +
> + pinctrl-2:
> + minItems: 1
> + maxItems: 2
> +
> + pinctrl-3:
> + minItems: 1
> + maxItems: 2
You can drop these. They are automatically added and there's not
anything additional to describe here that's useful.
> +
> + pinctrl-names:
> + minItems: 1
> + maxItems: 4
> + items:
> + - const: default
> + - const: state_100mhz
> + - const: state_200mhz
> + - const: sleep
This should stay since you are defining the names.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-22 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 3:09 [PATCH V2 0/4] imx esdhc dt/driver update peng.fan
2021-01-21 3:09 ` [PATCH V2 1/4] dt-bindings: mmc: fsl-imx-esdhc: add pinctrl bindings peng.fan
2021-01-22 16:38 ` Rob Herring [this message]
2021-01-21 3:09 ` [PATCH V2 2/4] dt-bindings: mmc: fsl-imx-esdhc: add clock bindings peng.fan
2021-01-21 16:01 ` Rob Herring
2021-01-22 0:55 ` Peng Fan
2021-01-22 14:33 ` Rob Herring
2021-01-21 3:09 ` [PATCH V2 3/4] arm64: dts: imx8qxp: correct usdhc clock-names sequence peng.fan
2021-01-21 3:09 ` [PATCH V2 4/4] mmc: sdhci-esdhc-imx: validate pinctrl before use it peng.fan
2021-02-07 13:10 ` [PATCH V2 0/4] imx esdhc dt/driver update Peng Fan
2021-02-08 12:05 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122163811.GA926374@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).