From: Lecopzer Chen <lecopzer.chen@mediatek.com>
To: <will@kernel.org>
Cc: lecopzer.chen@mediatek.com, catalin.marinas@arm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
tyhicks@linux.microsoft.com, glider@google.com,
vincenzo.frascino@arm.com, ardb@kernel.org,
yj.chiang@mediatek.com, kasan-dev@googlegroups.com,
dvyukov@google.com, aryabinin@virtuozzo.com, linux@roeck-us.net,
andreyknvl@google.com, lecopzer@gmail.com, broonie@kernel.org,
linux-mediatek@lists.infradead.org, dan.j.williams@intel.com,
linux-arm-kernel@lists.infradead.org, gustavoars@kernel.org,
akpm@linux-foundation.org, robin.murphy@arm.com, rppt@kernel.org
Subject: Re: [PATCH v2 4/4] arm64: kaslr: support randomized module area with KASAN_VMALLOC
Date: Thu, 28 Jan 2021 16:53:26 +0800 [thread overview]
Message-ID: <20210128085326.22553-1-lecopzer.chen@mediatek.com> (raw)
In-Reply-To: <20210127230413.GA1016@willie-the-truck>
> On Sat, Jan 09, 2021 at 06:32:52PM +0800, Lecopzer Chen wrote:
> > After KASAN_VMALLOC works in arm64, we can randomize module region
> > into vmalloc area now.
> >
> > Test:
> > VMALLOC area ffffffc010000000 fffffffdf0000000
> >
> > before the patch:
> > module_alloc_base/end ffffffc008b80000 ffffffc010000000
> > after the patch:
> > module_alloc_base/end ffffffdcf4bed000 ffffffc010000000
> >
> > And the function that insmod some modules is fine.
> >
> > Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> > Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> > ---
> > arch/arm64/kernel/kaslr.c | 18 ++++++++++--------
> > arch/arm64/kernel/module.c | 16 +++++++++-------
> > 2 files changed, 19 insertions(+), 15 deletions(-)
> >
> > diff --git a/arch/arm64/kernel/kaslr.c b/arch/arm64/kernel/kaslr.c
> > index 1c74c45b9494..a2858058e724 100644
> > --- a/arch/arm64/kernel/kaslr.c
> > +++ b/arch/arm64/kernel/kaslr.c
> > @@ -161,15 +161,17 @@ u64 __init kaslr_early_init(u64 dt_phys)
> > /* use the top 16 bits to randomize the linear region */
> > memstart_offset_seed = seed >> 48;
> >
> > - if (IS_ENABLED(CONFIG_KASAN_GENERIC) ||
> > - IS_ENABLED(CONFIG_KASAN_SW_TAGS))
> > + if (!IS_ENABLED(CONFIG_KASAN_VMALLOC) &&
> > + (IS_ENABLED(CONFIG_KASAN_GENERIC) ||
>
> CONFIG_KASAN_VMALLOC depends on CONFIG_KASAN_GENERIC so why is this
> necessary?
>
> Will
CONFIG_KASAN_VMALLOC=y means CONFIG_KASAN_GENERIC=y
but CONFIG_KASAN_GENERIC=y doesn't means CONFIG_KASAN_VMALLOC=y
So this if-condition allows only KASAN rather than
KASAN + KASAN_VMALLOC enabled.
Please correct me if I'm wrong.
thanks,
Lecopzer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-28 8:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 10:32 [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-09 10:32 ` [PATCH v2 1/4] arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-02-03 18:37 ` Ard Biesheuvel
2021-02-04 6:21 ` Lecopzer Chen
2021-02-04 12:45 ` Will Deacon
2021-02-04 14:46 ` Lecopzer Chen
2021-02-04 15:01 ` Will Deacon
2021-02-04 16:37 ` Lecopzer Chen
2021-02-05 17:18 ` Will Deacon
2021-02-05 17:30 ` Andrey Konovalov
2021-02-05 17:43 ` Will Deacon
2021-02-05 20:50 ` Andrey Konovalov
2021-02-05 18:10 ` Lecopzer Chen
2021-01-09 10:32 ` [PATCH v2 2/4] arm64: kasan: abstract _text and _end to KERNEL_START/END Lecopzer Chen
2021-02-04 12:46 ` Will Deacon
2021-02-04 14:51 ` Lecopzer Chen
2021-02-04 14:55 ` Will Deacon
2021-02-04 16:06 ` Lecopzer Chen
2021-02-05 17:02 ` Will Deacon
2021-01-09 10:32 ` [PATCH v2 3/4] arm64: Kconfig: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-09 10:32 ` [PATCH v2 4/4] arm64: kaslr: support randomized module area with KASAN_VMALLOC Lecopzer Chen
2021-01-27 23:04 ` Will Deacon
2021-01-28 8:53 ` Lecopzer Chen [this message]
2021-01-28 20:26 ` Will Deacon
2021-01-21 10:19 ` [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-21 17:44 ` Andrey Konovalov
2021-01-22 19:05 ` Will Deacon
2021-02-03 18:31 ` Ard Biesheuvel
2021-02-04 12:49 ` Will Deacon
2021-02-04 15:53 ` Lecopzer Chen
2021-02-04 17:57 ` Will Deacon
2021-02-04 18:41 ` Lecopzer Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128085326.22553-1-lecopzer.chen@mediatek.com \
--to=lecopzer.chen@mediatek.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=ardb@kernel.org \
--cc=aryabinin@virtuozzo.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=gustavoars@kernel.org \
--cc=kasan-dev@googlegroups.com \
--cc=lecopzer@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux@roeck-us.net \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=tyhicks@linux.microsoft.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).