From: Will Deacon <will@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] perf/arm-cmn: Fix PMU instance naming
Date: Thu, 28 Jan 2021 20:14:22 +0000 [thread overview]
Message-ID: <20210128201422.GB3016@willie-the-truck> (raw)
In-Reply-To: <649a2281233f193d59240b13ed91b57337c77b32.1611839564.git.robin.murphy@arm.com>
On Thu, Jan 28, 2021 at 01:12:43PM +0000, Robin Murphy wrote:
> Although it's neat to avoid the suffix for the typical case of a
> single PMU, it means systems with multiple CMN instances end up with
> inconsistent naming. I think it also breaks perf tool's "uncore alias"
> logic if the common instance prefix is also the full name of one.
>
> Avoid any surprises by not trying to be clever and simply numbering
> every instance, even when it might technically prove redundant.
>
> Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> Documentation/admin-guide/perf/arm-cmn.rst | 2 +-
> drivers/perf/arm-cmn.c | 13 ++++---------
> 2 files changed, 5 insertions(+), 10 deletions(-)
Hmm, so usually I'd push-back on changes like this because it's a
user-visible change, however in this case we're talking about a pretty
niche PMU and a relatively new driver so I think we should proceed. However,
if anybody complains then we'll need to support them in one way or another.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-28 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 13:12 [PATCH 1/2] perf/arm-cmn: Fix PMU instance naming Robin Murphy
2021-01-28 13:12 ` [PATCH 2/2] perf/arm-cmn: Move IRQs when migrating context Robin Murphy
2021-01-28 20:14 ` Will Deacon [this message]
2021-01-29 0:14 ` [PATCH 1/2] perf/arm-cmn: Fix PMU instance naming Robin Murphy
2021-01-28 21:07 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128201422.GB3016@willie-the-truck \
--to=will@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).