From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F047C433E9 for ; Wed, 3 Feb 2021 09:29:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5F5864F74 for ; Wed, 3 Feb 2021 09:29:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5F5864F74 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DWfWaAfoVV3U48wH7PwMiYvGJ3fGmLGgIlEVyDxL3kk=; b=QIPxECZgjlYJjx9BdvvVsubrE R366MPwCD4vf2Vh4bkoTtK5SltLKmzxz6Awpq4rgLEN3R1ogqEeRy5E274JBIY3oslLfg0pShB+N+ NqvbG/cCfO9yKOUPATC7bMuJqytbQSDQASoj/REYNU1n6NzC6K70x45mgwUBQ2nygoHf8ObgNMRM0 cLbjPgsbZrqszcIMPqdf3phXclmKBi+1pZgf6ljHrIHQeT6YfUGNFZR/CrBIpYlc4E07Rd2J2cliO GhnKnQUBa7QiETdbRk3eMVafZTDIVJzJkyjd3FcDGe6keodEbQiW+F4ecqZ3Vni4CHNY9noozNVGo 5W1GoNihA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7ES5-0004TB-2e; Wed, 03 Feb 2021 09:27:57 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7ES2-0004RL-Kk for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 09:27:55 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B8DC99EB; Wed, 3 Feb 2021 04:27:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 03 Feb 2021 04:27:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=VAoa5grz9ER7JEyWFa0fcNdHf38 qXZqtMA88GRCrXjQ=; b=rKRxtop/20i6t3PEJ74Cld1+XQ63ReDEhxZKubD/7g5 QibY83C4b+Ql2oIhCS7ushMTgRp7tgV0MX1FLISsNDaD2UyI49+gFj0LOH04Kr3A ejdqVu2RF0S4nYENEfhBqEr2xVKwl7RMsqUeTFXykWMaSW1pLh0k+ZmznRsE6UBx srfp0ExRk0G2Qjru2vNpMBYNpwe0jnfyvPmcwriywEYPeiJKzbb7wVakL9NtQeSD qmhBU5mU0HdanwGbqm5EqcXMofl42C/vV9F41t1Ax7D9IwwtaaElKEgzo6SWAocJ XtAT2sacyYPtVVtvQjRsIX0yGL/H9cS1cP0fPt6r2Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=VAoa5g rz9ER7JEyWFa0fcNdHf38qXZqtMA88GRCrXjQ=; b=S3tXiMIzexyRJJwRq/kxcZ U5vQvhBtVN7si49GrTA/kGkzOEAsF3XcD/slEG567C6CWsR2a9SEwPS7WRX83O1A nRxWIJ+foX4/bgZwpljCbH6FGIba6ECsGaNs2PivzonfC5AAPi+EzYvDccQGxnEO CzpCwjQQciJ7xwD+TruNz0Vs/3Q8rynn8WwZORMnFS4bKl8MBep8KWN5NCGmtoBL Kn3Ovj5RMkzj8N87HdA5OwRwwzz7phvYfJY9h8qi2VLtAWmVZp3Q/OsBLjk7a3oW q50wY3qWleMbwl0skmrFAEJ2v6qQDQWYhhBdPScSuudrqu28S1jbc5zlfTYkj1/g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgedvgddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeduvdduhfekkeehgffftefflefgffdtheffudffgeevteffheeuiedvvdejvdfg veenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 524781080066; Wed, 3 Feb 2021 04:27:46 -0500 (EST) Date: Wed, 3 Feb 2021 10:27:44 +0100 From: Maxime Ripard To: Lee Jones Subject: Re: [PATCH 12/21] clk: sunxi: clk-sun6i-ar100: Demote non-conformant kernel-doc header Message-ID: <20210203092744.yfedaauyynzn537h@gilmour> References: <20210126124540.3320214-1-lee.jones@linaro.org> <20210126124540.3320214-13-lee.jones@linaro.org> <20210126155430.llxijnwf5i4z3end@gilmour> <20210126165459.GG4903@dell> MIME-Version: 1.0 In-Reply-To: <20210126165459.GG4903@dell> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_042754_768339_C6CABDEF X-CRM114-Status: GOOD ( 32.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris BREZILLON , Jernej Skrabec , Emilio =?utf-8?B?TMOzcGV6?= , Michael Turquette , linux-kernel@vger.kernel.org, Stephen Boyd , Chen-Yu Tsai , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2283498567723446852==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2283498567723446852== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jajmciffwlsodka3" Content-Disposition: inline --jajmciffwlsodka3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 26, 2021 at 04:54:59PM +0000, Lee Jones wrote: > On Tue, 26 Jan 2021, Maxime Ripard wrote: >=20 > > On Tue, Jan 26, 2021 at 12:45:31PM +0000, Lee Jones wrote: > > > Fixes the following W=3D1 kernel build warning(s): > > >=20 > > > drivers/clk/sunxi/clk-sun6i-ar100.c:26: warning: Function parameter = or member 'req' not described in 'sun6i_get_ar100_factors' > > >=20 > > > Cc: "Emilio L=F3pez" > > > Cc: Michael Turquette > > > Cc: Stephen Boyd > > > Cc: Maxime Ripard > > > Cc: Chen-Yu Tsai > > > Cc: Jernej Skrabec > > > Cc: Boris BREZILLON > > > Cc: linux-clk@vger.kernel.org > > > Cc: linux-arm-kernel@lists.infradead.org > > > Signed-off-by: Lee Jones > > > --- > > > drivers/clk/sunxi/clk-sun6i-ar100.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/drivers/clk/sunxi/clk-sun6i-ar100.c b/drivers/clk/sunxi/= clk-sun6i-ar100.c > > > index e1b7d0929cf7f..54babc2b4b9ee 100644 > > > --- a/drivers/clk/sunxi/clk-sun6i-ar100.c > > > +++ b/drivers/clk/sunxi/clk-sun6i-ar100.c > > > @@ -16,7 +16,7 @@ > > > =20 > > > #include "clk-factors.h" > > > =20 > > > -/** > > > +/* > > > * sun6i_get_ar100_factors - Calculates factors p, m for AR100 > > > * > > > * AR100 rate is calculated as follows > >=20 > > This is the sixth patch doing the exact same thing over the files in > > that folder you sent. Please fix all the occurences at once >=20 > No. That would make the whole clean-up process 10x harder than it > already is >=20 > Before starting this endeavour there were 18,000+ warnings spread over > 100's of files and 10's of subsystems that needed addressing (only a > couple thousand left now thankfully). Some issues vastly different, > some duplicated (much too much copy/pasting going which made things > very frustrating at times). >=20 > Anyway, in order to work though them all gracefully and in a sensible > time-frame I had to come up with a workable plan. Each subsystem is > compiled separately and a script attempts to take out duplicate > warnings and takes me through the build-log one file at a time. Once > all of the warnings are fixed in a source-file, it moves on to the > next file. The method is clean and allows me to handle this > gargantuan task in bite-sized chunks. I mean, you have literally used the same commit log and the same changes over six different files in the same directory. Sure changes across different parts of the kernel can be painful, but it's really not what we're discussing here. > Going though and pairing up similar changes is unsustainable for a > task like this. It would add a lot of additional overhead and would > slow down the rate of acceptance since source files tend to have > different reviewers/maintainers - some working faster to review > patches than others, leading to excessive lag times waiting for that > one reviewer who takes weeks to review. Are you arguing that sending the same patch 6 times is easier and faster to review for the maintainer than the same changes in a single patch? > Having each file addressed in a separate patch also helps > revertability and bisectability. Not such a big problem with the > documentation patches, but still. There's nothing to revert or bisect, those changes aren't functional changes. > Admittedly doing it this way *can* look a bit odd in *some* patch-sets > when they hit the MLs - particularly clock it seems, where there > hasn't even been a vague attempt to document any of the parameters in > the kernel-doc headers - however the alternative would mean nothing > would get done! Yeah, and even though properly documenting the functions would have been the right way to fix those warnings, I didn't ask you to do that since I was expecting it to be daunting. Surely we can meet half-way Maxime --jajmciffwlsodka3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYBpskAAKCRDj7w1vZxhR xdZ6AP4rRA0/S6jS9NyjKe9T4p7VaHMetN9ppZuB/NUOoJlyFwD8D1n3Dc1DUcA0 VLJXXOfCEuGjWm9gmaygNm2hBNzP3AU= =XQlf -----END PGP SIGNATURE----- --jajmciffwlsodka3-- --===============2283498567723446852== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2283498567723446852==--