Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules.
@ 2021-02-03 11:34 Ivan Jelincic
  2021-02-03 11:34 ` [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options Ivan Jelincic
  2021-02-05 13:18 ` [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Grygorii Strashko
  0 siblings, 2 replies; 13+ messages in thread
From: Ivan Jelincic @ 2021-02-03 11:34 UTC (permalink / raw)
  To: linux-omap; +Cc: Tony Lindgren, Ivan Jelincic, linux-arm-kernel

Enable the majority of the Netfilter components as loadable modules
in the omap2plus_defconfig file.

Signed-off-by: Ivan Jelincic <parazyd@dyne.org>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: parazyd <parazyd@dyne.org>
---
 arch/arm/configs/omap2plus_defconfig | 149 +++++++++++++++++++++++++++
 1 file changed, 149 insertions(+)

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index f250bf1cc022..9847502d2c97 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -87,6 +87,155 @@ CONFIG_IP_PNP_DHCP=y
 CONFIG_IP_PNP_BOOTP=y
 CONFIG_IP_PNP_RARP=y
 CONFIG_NETFILTER=y
+CONFIG_NF_CONNTRACK=m
+CONFIG_NF_LOG_NETDEV=m
+CONFIG_NF_CONNTRACK_ZONES=y
+CONFIG_NF_CONNTRACK_EVENTS=y
+CONFIG_NF_CONNTRACK_TIMEOUT=y
+CONFIG_NF_CONNTRACK_TIMESTAMP=y
+CONFIG_NF_CT_NETLINK=m
+CONFIG_NF_CT_NETLINK_TIMEOUT=m
+CONFIG_NF_CT_NETLINK_HELPER=m
+CONFIG_NETFILTER_NETLINK_GLUE_CT=y
+CONFIG_NF_TABLES=m
+CONFIG_NF_TABLES_INET=y
+CONFIG_NF_TABLES_NETDEV=y
+CONFIG_NFT_NUMGEN=m
+CONFIG_NFT_CT=m
+CONFIG_NFT_COUNTER=m
+CONFIG_NFT_CONNLIMIT=m
+CONFIG_NFT_LOG=m
+CONFIG_NFT_LIMIT=m
+CONFIG_NFT_MASQ=m
+CONFIG_NFT_REDIR=m
+CONFIG_NFT_NAT=m
+CONFIG_NFT_TUNNEL=m
+CONFIG_NFT_OBJREF=m
+CONFIG_NFT_QUEUE=m
+CONFIG_NFT_QUOTA=m
+CONFIG_NFT_REJECT=m
+CONFIG_NFT_COMPAT=m
+CONFIG_NFT_HASH=m
+CONFIG_NFT_FIB_INET=m
+CONFIG_NFT_XFRM=m
+CONFIG_NFT_SOCKET=m
+CONFIG_NFT_OSF=m
+CONFIG_NFT_TPROXY=m
+CONFIG_NFT_SYNPROXY=m
+CONFIG_NFT_DUP_NETDEV=m
+CONFIG_NFT_FWD_NETDEV=m
+CONFIG_NFT_FIB_NETDEV=m
+CONFIG_NFT_REJECT_NETDEV=m
+CONFIG_NF_FLOW_TABLE_INET=m
+CONFIG_NF_FLOW_TABLE=m
+CONFIG_NETFILTER_XT_TARGET_AUDIT=m
+CONFIG_NETFILTER_XT_TARGET_CLASSIFY=m
+CONFIG_NETFILTER_XT_TARGET_CONNMARK=m
+CONFIG_NETFILTER_XT_TARGET_CT=m
+CONFIG_NETFILTER_XT_TARGET_DSCP=m
+CONFIG_NETFILTER_XT_TARGET_HMARK=m
+CONFIG_NETFILTER_XT_TARGET_IDLETIMER=m
+CONFIG_NETFILTER_XT_TARGET_LED=m
+CONFIG_NETFILTER_XT_TARGET_LOG=m
+CONFIG_NETFILTER_XT_TARGET_MARK=m
+CONFIG_NETFILTER_XT_TARGET_NFLOG=m
+CONFIG_NETFILTER_XT_TARGET_NFQUEUE=m
+CONFIG_NETFILTER_XT_TARGET_TEE=m
+CONFIG_NETFILTER_XT_TARGET_TPROXY=m
+CONFIG_NETFILTER_XT_TARGET_TRACE=m
+CONFIG_NETFILTER_XT_TARGET_TCPMSS=m
+CONFIG_NETFILTER_XT_TARGET_TCPOPTSTRIP=m
+CONFIG_NETFILTER_XT_MATCH_ADDRTYPE=m
+CONFIG_NETFILTER_XT_MATCH_BPF=m
+CONFIG_NETFILTER_XT_MATCH_CGROUP=m
+CONFIG_NETFILTER_XT_MATCH_CLUSTER=m
+CONFIG_NETFILTER_XT_MATCH_COMMENT=m
+CONFIG_NETFILTER_XT_MATCH_CONNBYTES=m
+CONFIG_NETFILTER_XT_MATCH_CONNLABEL=m
+CONFIG_NETFILTER_XT_MATCH_CONNLIMIT=m
+CONFIG_NETFILTER_XT_MATCH_CONNMARK=m
+CONFIG_NETFILTER_XT_MATCH_CONNTRACK=m
+CONFIG_NETFILTER_XT_MATCH_CPU=m
+CONFIG_NETFILTER_XT_MATCH_DCCP=m
+CONFIG_NETFILTER_XT_MATCH_DEVGROUP=m
+CONFIG_NETFILTER_XT_MATCH_DSCP=m
+CONFIG_NETFILTER_XT_MATCH_ESP=m
+CONFIG_NETFILTER_XT_MATCH_HASHLIMIT=m
+CONFIG_NETFILTER_XT_MATCH_HELPER=m
+CONFIG_NETFILTER_XT_MATCH_IPCOMP=m
+CONFIG_NETFILTER_XT_MATCH_IPRANGE=m
+CONFIG_NETFILTER_XT_MATCH_L2TP=m
+CONFIG_NETFILTER_XT_MATCH_LENGTH=m
+CONFIG_NETFILTER_XT_MATCH_LIMIT=m
+CONFIG_NETFILTER_XT_MATCH_MAC=m
+CONFIG_NETFILTER_XT_MATCH_MARK=m
+CONFIG_NETFILTER_XT_MATCH_MULTIPORT=m
+CONFIG_NETFILTER_XT_MATCH_NFACCT=m
+CONFIG_NETFILTER_XT_MATCH_OSF=m
+CONFIG_NETFILTER_XT_MATCH_OWNER=m
+CONFIG_NETFILTER_XT_MATCH_POLICY=m
+CONFIG_NETFILTER_XT_MATCH_PKTTYPE=m
+CONFIG_NETFILTER_XT_MATCH_QUOTA=m
+CONFIG_NETFILTER_XT_MATCH_RATEEST=m
+CONFIG_NETFILTER_XT_MATCH_REALM=m
+CONFIG_NETFILTER_XT_MATCH_RECENT=m
+CONFIG_NETFILTER_XT_MATCH_SCTP=m
+CONFIG_NETFILTER_XT_MATCH_SOCKET=m
+CONFIG_NETFILTER_XT_MATCH_STATE=m
+CONFIG_NETFILTER_XT_MATCH_STATISTIC=m
+CONFIG_NETFILTER_XT_MATCH_STRING=m
+CONFIG_NETFILTER_XT_MATCH_TCPMSS=m
+CONFIG_NETFILTER_XT_MATCH_TIME=m
+CONFIG_NETFILTER_XT_MATCH_U32=m
+CONFIG_NFT_DUP_IPV4=m
+CONFIG_NFT_FIB_IPV4=m
+CONFIG_NF_FLOW_TABLE_IPV4=m
+CONFIG_IP_NF_IPTABLES=m
+CONFIG_IP_NF_MATCH_AH=m
+CONFIG_IP_NF_MATCH_ECN=m
+CONFIG_IP_NF_MATCH_RPFILTER=m
+CONFIG_IP_NF_MATCH_TTL=m
+CONFIG_IP_NF_FILTER=m
+CONFIG_IP_NF_TARGET_REJECT=m
+CONFIG_IP_NF_TARGET_SYNPROXY=m
+CONFIG_IP_NF_NAT=m
+CONFIG_IP_NF_TARGET_MASQUERADE=m
+CONFIG_IP_NF_TARGET_NETMAP=m
+CONFIG_IP_NF_TARGET_REDIRECT=m
+CONFIG_IP_NF_MANGLE=m
+CONFIG_IP_NF_TARGET_CLUSTERIP=m
+CONFIG_IP_NF_TARGET_ECN=m
+CONFIG_IP_NF_TARGET_TTL=m
+CONFIG_IP_NF_RAW=m
+CONFIG_IP_NF_SECURITY=m
+CONFIG_NFT_DUP_IPV6=m
+CONFIG_NFT_FIB_IPV6=m
+CONFIG_NF_FLOW_TABLE_IPV6=m
+CONFIG_IP6_NF_IPTABLES=m
+CONFIG_IP6_NF_MATCH_AH=m
+CONFIG_IP6_NF_MATCH_EUI64=m
+CONFIG_IP6_NF_MATCH_FRAG=m
+CONFIG_IP6_NF_MATCH_OPTS=m
+CONFIG_IP6_NF_MATCH_HL=m
+CONFIG_IP6_NF_MATCH_IPV6HEADER=m
+CONFIG_IP6_NF_MATCH_MH=m
+CONFIG_IP6_NF_MATCH_RPFILTER=m
+CONFIG_IP6_NF_MATCH_RT=m
+CONFIG_IP6_NF_MATCH_SRH=m
+CONFIG_IP6_NF_TARGET_HL=m
+CONFIG_IP6_NF_FILTER=m
+CONFIG_IP6_NF_TARGET_REJECT=m
+CONFIG_IP6_NF_TARGET_SYNPROXY=m
+CONFIG_IP6_NF_MANGLE=m
+CONFIG_IP6_NF_RAW=m
+CONFIG_IP6_NF_SECURITY=m
+CONFIG_IP6_NF_NAT=m
+CONFIG_IP6_NF_TARGET_MASQUERADE=m
+CONFIG_IP6_NF_TARGET_NPT=m
+CONFIG_NF_TABLES_BRIDGE=m
+CONFIG_NFT_BRIDGE_META=m
+CONFIG_NFT_BRIDGE_REJECT=m
+CONFIG_NF_LOG_BRIDGE=m
 CONFIG_BRIDGE=m
 CONFIG_BRIDGE_VLAN_FILTERING=y
 CONFIG_VLAN_8021Q=m
-- 
2.30.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
  2021-02-03 11:34 [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Ivan Jelincic
@ 2021-02-03 11:34 ` Ivan Jelincic
  2021-02-04  6:56   ` Tony Lindgren
  2021-02-05 13:18 ` [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Grygorii Strashko
  1 sibling, 1 reply; 13+ messages in thread
From: Ivan Jelincic @ 2021-02-03 11:34 UTC (permalink / raw)
  To: linux-omap; +Cc: Tony Lindgren, Ivan Jelincic, linux-arm-kernel

Update omap2plus_defconfig for options that have been dropped:

- SIMPLE_PM_BUS no longer selected.
- MICREL_PHY no longer selected.

Signed-off-by: Ivan Jelincic <parazyd@dyne.org>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: parazyd <parazyd@dyne.org>
---
 arch/arm/configs/omap2plus_defconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index 9847502d2c97..ac13cab9f69d 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -286,7 +286,6 @@ CONFIG_PCI_EPF_TEST=m
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_OMAP_OCP2SCP=y
-CONFIG_SIMPLE_PM_BUS=y
 CONFIG_CONNECTOR=m
 CONFIG_MTD=y
 CONFIG_MTD_CMDLINE_PARTS=y
@@ -344,7 +343,6 @@ CONFIG_TI_CPSW_SWITCHDEV=y
 CONFIG_TI_CPTS=y
 # CONFIG_NET_VENDOR_VIA is not set
 # CONFIG_NET_VENDOR_WIZNET is not set
-CONFIG_MICREL_PHY=y
 CONFIG_AT803X_PHY=y
 CONFIG_SMSC_PHY=y
 CONFIG_DP83848_PHY=y
-- 
2.30.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
  2021-02-03 11:34 ` [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options Ivan Jelincic
@ 2021-02-04  6:56   ` Tony Lindgren
  2021-02-05 13:15     ` Grygorii Strashko
  0 siblings, 1 reply; 13+ messages in thread
From: Tony Lindgren @ 2021-02-04  6:56 UTC (permalink / raw)
  To: Ivan Jelincic; +Cc: linux-omap, linux-arm-kernel

* Ivan Jelincic <parazyd@dyne.org> [210203 13:35]:
> Update omap2plus_defconfig for options that have been dropped:
> 
> - SIMPLE_PM_BUS no longer selected.

Oh right, we now need to always select it. Will queue this for
fixes after the merge window. The other one I'll be queueing
for v5.13 as the merge window is about to open and I'll only
queue fixes for the next few weeks :)

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
  2021-02-04  6:56   ` Tony Lindgren
@ 2021-02-05 13:15     ` Grygorii Strashko
  2021-02-05 13:17       ` Ivan J.
  0 siblings, 1 reply; 13+ messages in thread
From: Grygorii Strashko @ 2021-02-05 13:15 UTC (permalink / raw)
  To: Tony Lindgren, Ivan Jelincic; +Cc: linux-omap, linux-arm-kernel



On 04/02/2021 08:56, Tony Lindgren wrote:
> * Ivan Jelincic <parazyd@dyne.org> [210203 13:35]:
>> Update omap2plus_defconfig for options that have been dropped:
>>
>> - SIMPLE_PM_BUS no longer selected.
> 
> Oh right, we now need to always select it. Will queue this for
> fixes after the merge window. The other one I'll be queueing
> for v5.13 as the merge window is about to open and I'll only
> queue fixes for the next few weeks :)

"- MICREL_PHY no longer selected."

I do not agree with above as MICREL_PHY is selected by KS8851, but on many boards there is no
explicit dependency from KS8851, but MICREL PHYs are in use.
So, I'd prefer to have it enabled explicitly in omap2plus_defconfig.

And not sure what exactly "no longer selected" means.

-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
  2021-02-05 13:15     ` Grygorii Strashko
@ 2021-02-05 13:17       ` Ivan J.
  2021-02-05 13:30         ` Tony Lindgren
  0 siblings, 1 reply; 13+ messages in thread
From: Ivan J. @ 2021-02-05 13:17 UTC (permalink / raw)
  To: Grygorii Strashko; +Cc: Tony Lindgren, linux-omap, linux-arm-kernel

On Fri, Feb 05, 2021 at 03:15:00PM +0200, Grygorii Strashko wrote:
> 
> 
> On 04/02/2021 08:56, Tony Lindgren wrote:
> > * Ivan Jelincic <parazyd@dyne.org> [210203 13:35]:
> > > Update omap2plus_defconfig for options that have been dropped:
> > > 
> > > - SIMPLE_PM_BUS no longer selected.
> > 
> > Oh right, we now need to always select it. Will queue this for
> > fixes after the merge window. The other one I'll be queueing
> > for v5.13 as the merge window is about to open and I'll only
> > queue fixes for the next few weeks :)
> 
> "- MICREL_PHY no longer selected."
> 
> I do not agree with above as MICREL_PHY is selected by KS8851, but on many boards there is no
> explicit dependency from KS8851, but MICREL PHYs are in use.
> So, I'd prefer to have it enabled explicitly in omap2plus_defconfig.
> 
> And not sure what exactly "no longer selected" means.

"no longer selected" means it went away after `make savedefconfig`.

Best regards,
Ivan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules.
  2021-02-03 11:34 [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Ivan Jelincic
  2021-02-03 11:34 ` [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options Ivan Jelincic
@ 2021-02-05 13:18 ` Grygorii Strashko
  2021-02-05 13:33   ` Tony Lindgren
  1 sibling, 1 reply; 13+ messages in thread
From: Grygorii Strashko @ 2021-02-05 13:18 UTC (permalink / raw)
  To: Ivan Jelincic, linux-omap; +Cc: Tony Lindgren, linux-arm-kernel

Hi Tony, Ivan

On 03/02/2021 13:34, Ivan Jelincic wrote:
> Enable the majority of the Netfilter components as loadable modules
> in the omap2plus_defconfig file.
> 
> Signed-off-by: Ivan Jelincic <parazyd@dyne.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: parazyd <parazyd@dyne.org>
> ---
>   arch/arm/configs/omap2plus_defconfig | 149 +++++++++++++++++++++++++++
>   1 file changed, 149 insertions(+)
> 
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index f250bf1cc022..9847502d2c97 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -87,6 +87,155 @@ CONFIG_IP_PNP_DHCP=y
>   CONFIG_IP_PNP_BOOTP=y
>   CONFIG_IP_PNP_RARP=y
>   CONFIG_NETFILTER=y
> +CONFIG_NF_CONNTRACK=m
> +CONFIG_NF_LOG_NETDEV=m
> +CONFIG_NF_CONNTRACK_ZONES=y
> +CONFIG_NF_CONNTRACK_EVENTS=y
> +CONFIG_NF_CONNTRACK_TIMEOUT=y
> +CONFIG_NF_CONNTRACK_TIMESTAMP=y
> +CONFIG_NF_CT_NETLINK=m

[..]

Do we really want to enable all these not TI specific configs?
The main purpose of omap2plus_defconfig is to enable TI specific HW and HW features and
config options required to tests/demonstrate these features - like support for some networking
HW offloads.


-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
  2021-02-05 13:17       ` Ivan J.
@ 2021-02-05 13:30         ` Tony Lindgren
  2021-02-05 14:25           ` Grygorii Strashko
  0 siblings, 1 reply; 13+ messages in thread
From: Tony Lindgren @ 2021-02-05 13:30 UTC (permalink / raw)
  To: Ivan J.; +Cc: linux-omap, Grygorii Strashko, linux-arm-kernel

* Ivan J. <parazyd@dyne.org> [210205 13:18]:
> On Fri, Feb 05, 2021 at 03:15:00PM +0200, Grygorii Strashko wrote:
> > 
> > 
> > On 04/02/2021 08:56, Tony Lindgren wrote:
> > > * Ivan Jelincic <parazyd@dyne.org> [210203 13:35]:
> > > > Update omap2plus_defconfig for options that have been dropped:
> > > > 
> > > > - SIMPLE_PM_BUS no longer selected.
> > > 
> > > Oh right, we now need to always select it. Will queue this for
> > > fixes after the merge window. The other one I'll be queueing
> > > for v5.13 as the merge window is about to open and I'll only
> > > queue fixes for the next few weeks :)
> > 
> > "- MICREL_PHY no longer selected."
> > 
> > I do not agree with above as MICREL_PHY is selected by KS8851, but on many boards there is no
> > explicit dependency from KS8851, but MICREL PHYs are in use.
> > So, I'd prefer to have it enabled explicitly in omap2plus_defconfig.
> > 
> > And not sure what exactly "no longer selected" means.
> 
> "no longer selected" means it went away after `make savedefconfig`.

Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig
for the other cases that do not use KS8851?

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules.
  2021-02-05 13:18 ` [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Grygorii Strashko
@ 2021-02-05 13:33   ` Tony Lindgren
  2021-02-05 14:01     ` Grygorii Strashko
  0 siblings, 1 reply; 13+ messages in thread
From: Tony Lindgren @ 2021-02-05 13:33 UTC (permalink / raw)
  To: Grygorii Strashko; +Cc: linux-omap, Ivan Jelincic, linux-arm-kernel

* Grygorii Strashko <grygorii.strashko@ti.com> [210205 13:18]:
> On 03/02/2021 13:34, Ivan Jelincic wrote:
> > Enable the majority of the Netfilter components as loadable modules
> > in the omap2plus_defconfig file.
...
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index f250bf1cc022..9847502d2c97 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -87,6 +87,155 @@ CONFIG_IP_PNP_DHCP=y
> >   CONFIG_IP_PNP_BOOTP=y
> >   CONFIG_IP_PNP_RARP=y
> >   CONFIG_NETFILTER=y
> > +CONFIG_NF_CONNTRACK=m
> > +CONFIG_NF_LOG_NETDEV=m
> > +CONFIG_NF_CONNTRACK_ZONES=y
> > +CONFIG_NF_CONNTRACK_EVENTS=y
> > +CONFIG_NF_CONNTRACK_TIMEOUT=y
> > +CONFIG_NF_CONNTRACK_TIMESTAMP=y
> > +CONFIG_NF_CT_NETLINK=m
> 
> [..]
> 
> Do we really want to enable all these not TI specific configs?
> The main purpose of omap2plus_defconfig is to enable TI specific HW and HW features and
> config options required to tests/demonstrate these features - like support for some networking
> HW offloads.

Well these are loadable modules. And I'd like to have omap2plus_defconfig
and multi_v7_defconfig usable as a base config for distros to use.

For built-in options I agree. We should only enable absolute minimum
for built-in optoins as otherwise things get even more bloated.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules.
  2021-02-05 13:33   ` Tony Lindgren
@ 2021-02-05 14:01     ` Grygorii Strashko
  0 siblings, 0 replies; 13+ messages in thread
From: Grygorii Strashko @ 2021-02-05 14:01 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap, Ivan Jelincic, linux-arm-kernel



On 05/02/2021 15:33, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [210205 13:18]:
>> On 03/02/2021 13:34, Ivan Jelincic wrote:
>>> Enable the majority of the Netfilter components as loadable modules
>>> in the omap2plus_defconfig file.
> ...
>>> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
>>> index f250bf1cc022..9847502d2c97 100644
>>> --- a/arch/arm/configs/omap2plus_defconfig
>>> +++ b/arch/arm/configs/omap2plus_defconfig
>>> @@ -87,6 +87,155 @@ CONFIG_IP_PNP_DHCP=y
>>>    CONFIG_IP_PNP_BOOTP=y
>>>    CONFIG_IP_PNP_RARP=y
>>>    CONFIG_NETFILTER=y
>>> +CONFIG_NF_CONNTRACK=m
>>> +CONFIG_NF_LOG_NETDEV=m
>>> +CONFIG_NF_CONNTRACK_ZONES=y
>>> +CONFIG_NF_CONNTRACK_EVENTS=y
>>> +CONFIG_NF_CONNTRACK_TIMEOUT=y
>>> +CONFIG_NF_CONNTRACK_TIMESTAMP=y
>>> +CONFIG_NF_CT_NETLINK=m
>>
>> [..]
>>
>> Do we really want to enable all these not TI specific configs?
>> The main purpose of omap2plus_defconfig is to enable TI specific HW and HW features and
>> config options required to tests/demonstrate these features - like support for some networking
>> HW offloads.
> 
> Well these are loadable modules. And I'd like to have omap2plus_defconfig
> and multi_v7_defconfig usable as a base config for distros to use.
> 
> For built-in options I agree. We should only enable absolute minimum
> for built-in optoins as otherwise things get even more bloated.

Ok. Up to you.

-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
  2021-02-05 13:30         ` Tony Lindgren
@ 2021-02-05 14:25           ` Grygorii Strashko
  2021-02-05 14:46             ` Tony Lindgren
  0 siblings, 1 reply; 13+ messages in thread
From: Grygorii Strashko @ 2021-02-05 14:25 UTC (permalink / raw)
  To: Tony Lindgren, Ivan J.; +Cc: linux-omap, linux-arm-kernel

Hi Tony,

On 05/02/2021 15:30, Tony Lindgren wrote:
> * Ivan J. <parazyd@dyne.org> [210205 13:18]:
>> On Fri, Feb 05, 2021 at 03:15:00PM +0200, Grygorii Strashko wrote:
>>>
>>>
>>> On 04/02/2021 08:56, Tony Lindgren wrote:
>>>> * Ivan Jelincic <parazyd@dyne.org> [210203 13:35]:
>>>>> Update omap2plus_defconfig for options that have been dropped:
>>>>>
>>>>> - SIMPLE_PM_BUS no longer selected.
>>>>
>>>> Oh right, we now need to always select it. Will queue this for
>>>> fixes after the merge window. The other one I'll be queueing
>>>> for v5.13 as the merge window is about to open and I'll only
>>>> queue fixes for the next few weeks :)
>>>
>>> "- MICREL_PHY no longer selected."
>>>
>>> I do not agree with above as MICREL_PHY is selected by KS8851, but on many boards there is no
>>> explicit dependency from KS8851, but MICREL PHYs are in use.
>>> So, I'd prefer to have it enabled explicitly in omap2plus_defconfig.
>>>
>>> And not sure what exactly "no longer selected" means.
>>
>> "no longer selected" means it went away after `make savedefconfig`.
> 
> Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig
> for the other cases that do not use KS8851?

The KS8851 config was added like 10years ago and is used on some omap4 platforms,
it does select MICREL_PHY.

 From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851.

The omap2plus_defconfig is also used as base for custom configs and first thing people are doing -
remove not needed options. As result, removal of KS8851 plus this patch will immediately
cause MICREL_PHY=n and so breakage on existing and custom platforms.

I do not see how it can be resolved by using Kconfig changes within much-omap2.

So, sry, but NACK for this patch as it is.

if some Kconfig dependencies need to be sorted out - probably the best way might be
to get rid of select MICREL_PHY in KS8851/KS8851_MLL.

-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
  2021-02-05 14:25           ` Grygorii Strashko
@ 2021-02-05 14:46             ` Tony Lindgren
  2021-02-05 15:04               ` Grygorii Strashko
  0 siblings, 1 reply; 13+ messages in thread
From: Tony Lindgren @ 2021-02-05 14:46 UTC (permalink / raw)
  To: Grygorii Strashko; +Cc: linux-omap, Ivan J., linux-arm-kernel

* Grygorii Strashko <grygorii.strashko@ti.com> [210205 14:25]:
> On 05/02/2021 15:30, Tony Lindgren wrote:
> > Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig
> > for the other cases that do not use KS8851?
> 
> The KS8851 config was added like 10years ago and is used on some omap4 platforms,
> it does select MICREL_PHY.
> 
> From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851.
> 
> The omap2plus_defconfig is also used as base for custom configs and first thing people are doing -
> remove not needed options. As result, removal of KS8851 plus this patch will immediately
> cause MICREL_PHY=n and so breakage on existing and custom platforms.
> 
> I do not see how it can be resolved by using Kconfig changes within much-omap2.
> 
> So, sry, but NACK for this patch as it is.

We can wait on this patch no problem while we figure this out.
But certainly we need to fix things so make savedefconfig
produces valid configs that don't need to be manually edited.

> if some Kconfig dependencies need to be sorted out - probably the best way might be
> to get rid of select MICREL_PHY in KS8851/KS8851_MLL.

That will potentially break things too as the configs now expect
it to be selected :) Looks like that got changed with commit
f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in
Kconfig").

So why can't we do similar patches to select MICREL_PHY for
the other non-ks8851 configurations in drivers/net/ethernet
Kconfig files as needed?

Regards,

Tony


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
  2021-02-05 14:46             ` Tony Lindgren
@ 2021-02-05 15:04               ` Grygorii Strashko
  2021-02-06  7:23                 ` Tony Lindgren
  0 siblings, 1 reply; 13+ messages in thread
From: Grygorii Strashko @ 2021-02-05 15:04 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap, Ivan J., linux-arm-kernel



On 05/02/2021 16:46, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [210205 14:25]:
>> On 05/02/2021 15:30, Tony Lindgren wrote:
>>> Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig
>>> for the other cases that do not use KS8851?
>>
>> The KS8851 config was added like 10years ago and is used on some omap4 platforms,
>> it does select MICREL_PHY.
>>
>>  From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851.
>>
>> The omap2plus_defconfig is also used as base for custom configs and first thing people are doing -
>> remove not needed options. As result, removal of KS8851 plus this patch will immediately
>> cause MICREL_PHY=n and so breakage on existing and custom platforms.
>>
>> I do not see how it can be resolved by using Kconfig changes within much-omap2.
>>
>> So, sry, but NACK for this patch as it is.
> 
> We can wait on this patch no problem while we figure this out.
> But certainly we need to fix things so make savedefconfig
> produces valid configs that don't need to be manually edited.
> 
>> if some Kconfig dependencies need to be sorted out - probably the best way might be
>> to get rid of select MICREL_PHY in KS8851/KS8851_MLL.
> 
> That will potentially break things too as the configs now expect
> it to be selected :) Looks like that got changed with commit
> f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in
> Kconfig").

Yah. It's really has to be "depends on".

> 
> So why can't we do similar patches to select MICREL_PHY for
> the other non-ks8851 configurations in drivers/net/ethernet
> Kconfig files as needed?

because there is no dependency between Ethernet controller (CPSW) and
Ethernet PHY - any MII capable PHY can be used with CPSW.

-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
  2021-02-05 15:04               ` Grygorii Strashko
@ 2021-02-06  7:23                 ` Tony Lindgren
  0 siblings, 0 replies; 13+ messages in thread
From: Tony Lindgren @ 2021-02-06  7:23 UTC (permalink / raw)
  To: Grygorii Strashko; +Cc: linux-omap, Ivan J., linux-arm-kernel

* Grygorii Strashko <grygorii.strashko@ti.com> [210205 15:04]:
> On 05/02/2021 16:46, Tony Lindgren wrote:
> > That will potentially break things too as the configs now expect
> > it to be selected :) Looks like that got changed with commit
> > f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in
> > Kconfig").
> 
> Yah. It's really has to be "depends on".

Yeah that's almost always better than select for sure.

> > So why can't we do similar patches to select MICREL_PHY for
> > the other non-ks8851 configurations in drivers/net/ethernet
> > Kconfig files as needed?
> 
> because there is no dependency between Ethernet controller (CPSW) and
> Ethernet PHY - any MII capable PHY can be used with CPSW.

OK thanks for the info.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, back to index

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 11:34 [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Ivan Jelincic
2021-02-03 11:34 ` [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options Ivan Jelincic
2021-02-04  6:56   ` Tony Lindgren
2021-02-05 13:15     ` Grygorii Strashko
2021-02-05 13:17       ` Ivan J.
2021-02-05 13:30         ` Tony Lindgren
2021-02-05 14:25           ` Grygorii Strashko
2021-02-05 14:46             ` Tony Lindgren
2021-02-05 15:04               ` Grygorii Strashko
2021-02-06  7:23                 ` Tony Lindgren
2021-02-05 13:18 ` [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Grygorii Strashko
2021-02-05 13:33   ` Tony Lindgren
2021-02-05 14:01     ` Grygorii Strashko

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git