From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83130C433E6 for ; Wed, 3 Feb 2021 16:13:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2880964E31 for ; Wed, 3 Feb 2021 16:13:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2880964E31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7j04V3OXmCJQp2k2cbQbng1l+N2HPfpI8DoJA+uy3CM=; b=uF/+CtHHpFG6b4tTX2zEeTC0o ++BuNUPFgMkQge4Kxna/6gyrzf20iT3+7k52pGC0owJh5YyOr1+5GIKK7xbP+zdfjZLLzuaLpykAk RDLjjUytTP5z15JM0VKQKa6H7BKmTEMLtrQRRzxf4LxIHEK6Y9ugNa075CSWLexuD85gzvCZWuHGS baMfh3HoeGI+HQrmbiczbvE2H789xpREa1VLXC7MeeFTxpEgqOQciyyfWee1pdW9dFMA6EGhXKnGb cJu/1KTw7+CASHzJXVDIPsIF9jG06SGAIB/n7hnYbi/PNSIIxCVf3CQXbycjH7ZDN15qB2T2O4Iyv lgLMiMypA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7Kl4-00084L-1G; Wed, 03 Feb 2021 16:11:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7Kl1-00083W-2P for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 16:11:56 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 690FD64F7C; Wed, 3 Feb 2021 16:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612368713; bh=7199PDpVTlqOjnCdGa1C2okl1sOKmVDKqDkYKIiqhaY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FuYblYiB5DXGGToKuosdQ/gmxLGmdtzvKntyOdRlqdN9qhhWUAJE3kHa1bOGTmwEQ eL22cLZgiqYFp8YZ3pXeNnElHV48a5UgvsULX6qQ/CuwARYwT47Wo3OGbf4Ek/AGPi I4ohHWcS3JCZPpjDxIlDKePYxucDjQOocD904+jEK/wCPRvIObio8zUzXUIs663RgM FQKTWIjoMnJOVQTdYo+QNvPTnrdR65aYKZNvwGhPMT2QgBfubvcsxh2DXt+s4Tx08N HohfrVM09LweAR6hGFGzdhkee7ZJe5u6AQS46++V8sJY3Z3YefUQLyqyIaDIC18wsc nAnjbTO03hiYw== Date: Wed, 3 Feb 2021 16:11:47 +0000 From: Will Deacon To: Quentin Perret Subject: Re: [RFC PATCH v2 26/26] KVM: arm64: Wrap the host with a stage 2 Message-ID: <20210203161146.GJ18974@willie-the-truck> References: <20210108121524.656872-1-qperret@google.com> <20210108121524.656872-27-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210108121524.656872-27-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_111155_279286_A5D059B6 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, kernel-team@android.com, Suzuki K Poulose , android-kvm@google.com, Catalin Marinas , Fuad Tabba , linux-kernel@vger.kernel.org, Rob Herring , James Morse , linux-arm-kernel@lists.infradead.org, Marc Zyngier , David Brazdil , Frank Rowand , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 08, 2021 at 12:15:24PM +0000, Quentin Perret wrote: > When KVM runs in protected nVHE mode, make use of a stage 2 page-table > to give the hypervisor some control over the host memory accesses. At > the moment all memory aborts from the host will be instantly idmapped > RWX at stage 2 in a lazy fashion. Later patches will make use of that > infrastructure to implement access control restrictions to e.g. protect > guest memory from the host. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_cpufeature.h | 2 + > arch/arm64/kernel/image-vars.h | 3 + > arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 33 +++ > arch/arm64/kvm/hyp/nvhe/Makefile | 2 +- > arch/arm64/kvm/hyp/nvhe/hyp-init.S | 1 + > arch/arm64/kvm/hyp/nvhe/hyp-main.c | 6 + > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 191 ++++++++++++++++++ > arch/arm64/kvm/hyp/nvhe/setup.c | 6 + > arch/arm64/kvm/hyp/nvhe/switch.c | 7 +- > arch/arm64/kvm/hyp/nvhe/tlb.c | 4 +- > 10 files changed, 248 insertions(+), 7 deletions(-) > create mode 100644 arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > create mode 100644 arch/arm64/kvm/hyp/nvhe/mem_protect.c [...] > +void handle_host_mem_abort(struct kvm_cpu_context *host_ctxt) > +{ > + enum kvm_pgtable_prot prot; > + u64 far, hpfar, esr, ipa; > + int ret; > + > + esr = read_sysreg_el2(SYS_ESR); > + if (!__get_fault_info(esr, &far, &hpfar)) > + hyp_panic(); > + > + prot = KVM_PGTABLE_PROT_R | KVM_PGTABLE_PROT_W | KVM_PGTABLE_PROT_X; > + ipa = (hpfar & HPFAR_MASK) << 8; > + ret = host_stage2_map(ipa, PAGE_SIZE, prot); Can we try to put down a block mapping if the whole thing falls within memory? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel