From: Krzysztof Kozlowski <krzk@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@puri.sm, devicetree@vger.kernel.org,
shawnguo@kernel.org, Angus Ainslie <angus@akkea.ca>,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] arm64: dts: librem5: protect some partitions of the nor-flash
Date: Mon, 8 Feb 2021 15:09:43 +0100 [thread overview]
Message-ID: <20210208140943.6dewq4b3dmaxh7ia@kozik-lap> (raw)
In-Reply-To: <20210208131527.24463-5-martin.kepplinger@puri.sm>
On Mon, Feb 08, 2021 at 02:15:26PM +0100, Martin Kepplinger wrote:
> From: Angus Ainslie <angus@akkea.ca>
>
> These sections should be read only as they contain important data.
>
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> .../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index c2bbbdeb93e3..9867e2a50008 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -258,6 +258,22 @@
> compatible = "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <1000000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
One empty line here.
> + partition@0x00000000 {
Wrong unit names. Compile dtses with W=1.
> + label = "protected0";
> + reg = <0x00000000 0x00030000>;
Get rid of leading 0000 - it makes it less readable.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-08 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 13:15 [PATCH 0/5] arm64: dts: librem5 phone and devkit dts and config updates Martin Kepplinger
2021-02-08 13:15 ` [PATCH 1/5] arm64: dts: imx8mq-librem5-devkit: Drop buck3 startup-ramp-delay Martin Kepplinger
2021-02-08 13:15 ` [PATCH 2/5] arm64: dts: librem5: Drop assigned-clocks from SAI2 Martin Kepplinger
2021-02-08 13:15 ` [PATCH 3/5] arm64: defconfig: Enable devfreq support for i.MX8MQ Martin Kepplinger
2021-02-08 14:05 ` Krzysztof Kozlowski
2021-02-08 13:15 ` [PATCH 4/5] arm64: dts: librem5: protect some partitions of the nor-flash Martin Kepplinger
2021-02-08 14:09 ` Krzysztof Kozlowski [this message]
2021-02-08 13:15 ` [PATCH 5/5] arm64: dts: imx8mq-librem5-r2: set nearlevel to 120 Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208140943.6dewq4b3dmaxh7ia@kozik-lap \
--to=krzk@kernel.org \
--cc=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).