From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA7AC433E0 for ; Mon, 8 Feb 2021 18:22:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EF4B64E84 for ; Mon, 8 Feb 2021 18:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EF4B64E84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2A2PTnLsHP+DiHtPyIj/q0vpmpoSI0+Bw/0HfIvHrNU=; b=RrS4BhcyPeQeflicTWRaIWeo/ 4ehaVVYbYlj4KgQj4P7NpSPjp/II5VOn4F388cjuvRkM0jP/6VpUav4obeDGZtyCwkcX7n2dEGi5W AsV9ZucMXO692aB1kZHkgPUUprB5k6qoFf6SFZfV1GOjtGqXHork6FOYzD9bhFpuBuLc/TNsvhM6R T6tyVWBsOPiDN7J3GR726Eqm3eqaKrtliBV6V9mUfJP9W+UWcYomVPO1yFT7s657O2w/goqypLty1 LV+ZmKx6Xp3O13Tbr7q+n2rzTZ0ogQHF/3RrqSCrrmTxkzKOCulyNKSkl0iOx8NR1Zd8d/fG8J3Ow BtZQmw1fQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9BA1-00053d-GQ; Mon, 08 Feb 2021 18:21:21 +0000 Received: from mail-oi1-f179.google.com ([209.85.167.179]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9B9x-000532-Nk for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 18:21:19 +0000 Received: by mail-oi1-f179.google.com with SMTP id k25so16567365oik.13 for ; Mon, 08 Feb 2021 10:21:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yT8WnppJbVZfpbRjwXZRaLF1Kx8p3ocolq2G8S6zsHQ=; b=Voo/46mE5g+bDZR3n7hgGQB4K3L/245xH4AzhiuBDQthefr0XSqgoV1Hq8Vrix+bHs EipCr4gUH3TqU78hhlBQWEp9x/RrhV0Aes8ZFKB4unVks5mZ4GyOr1oRgrQOAuTUcx0S yR3KOC9eaaTYJC6DOr6QhrzqCvSv/YtKDgEctlGE7CjTUSVE+i0uVXSfYAK+E1LxJUqU QzyvTJTvCxxFyr4nyAFP/5JlOtifDg4R5uB+QW/LvzWba55aXq0Ia0V2NdMFKeeGr44q vEVgA1Lw05F5IrlzdNWItbGF2Xt54UEgAQATqP2E6r7mMM+sFQjLaxoclTOPx53OM+JU JGoQ== X-Gm-Message-State: AOAM532Upr5npqClpsW0e5hAjSKM8mh67LNebD/bGO+NbYloJKMZShEE mtXk5ub/4YS6MGMtNSmZxw== X-Google-Smtp-Source: ABdhPJwMxPAwvhYn2SwOTD+njytvlMJrKMT+ayLz33Qtlqx3xzg9IIeYMv/25js4iJn5OgGH++eDSg== X-Received: by 2002:aca:5e84:: with SMTP id s126mr12263oib.175.1612808476055; Mon, 08 Feb 2021 10:21:16 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a22sm3845267otp.53.2021.02.08.10.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 10:21:14 -0800 (PST) Received: (nullmailer pid 1653616 invoked by uid 1000); Mon, 08 Feb 2021 18:21:13 -0000 Date: Mon, 8 Feb 2021 12:21:13 -0600 From: Rob Herring To: Leo Li Subject: Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema Message-ID: <20210208182113.GA1648694@robh.at.kernel.org> References: <20210205234734.3397-1-leoyang.li@nxp.com> <20210205234734.3397-4-leoyang.li@nxp.com> <1612803322.544738.1522086.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_132118_720736_FD8B2E9F X-CRM114-Status: GOOD ( 20.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Krzysztof Kozlowski , Oleksij Rempel , Shawn Guo , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 05:07:14PM +0000, Leo Li wrote: > > > > -----Original Message----- > > From: Rob Herring > > Sent: Monday, February 8, 2021 10:55 AM > > To: Leo Li > > Cc: linux-arm-kernel@lists.infradead.org; Oleksij Rempel > privat.de>; Rob Herring ; Krzysztof Kozlowski > > ; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; Shawn Guo > > Subject: Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to > > yaml schema > > > > On Fri, 05 Feb 2021 17:47:22 -0600, Li Yang wrote: > > > Convert the txt binding to yaml format and add description. Also > > > updated the recommended node name to ifc-bus to align with the > > > simple-bus node name requirements. > > > > > > Signed-off-by: Li Yang > > > --- > > > .../bindings/memory-controllers/fsl/ifc.txt | 82 ---------- > > > .../bindings/memory-controllers/fsl/ifc.yaml | 140 > > > ++++++++++++++++++ > > > 2 files changed, 140 insertions(+), 82 deletions(-) delete mode > > > 100644 > > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > > > create mode 100644 > > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/memory- > > controllers/fsl/ifc.example.dts:36.27-49.19: Warning (simple_bus_reg): > > /example-0/soc/ifc-bus@ffe1e000/flash@0,0: simple-bus unit address > > format error, expected "0" > > Documentation/devicetree/bindings/memory- > > controllers/fsl/ifc.example.dts:51.27-64.19: Warning (simple_bus_reg): > > /example-0/soc/ifc-bus@ffe1e000/flash@1,0: simple-bus unit address > > format error, expected "100000000" > > Documentation/devicetree/bindings/memory- > > controllers/fsl/ifc.example.dts:66.26-71.19: Warning (simple_bus_reg): > > /example-0/soc/ifc-bus@ffe1e000/cpld@3,0: simple-bus unit address format > > error, expected "300000000" > > Hi Rob, > > I saw these warnings, but cannot find a good solution to it. The > first cell in the address is the Chip select, while the second cell > in the address is the address offset within the chip select. It > would confusing to combine the two cells of different purposes into > a single address as suggested by the warning. Can we allow the > multi-cell address in the node name? Drop 'simple-bus'. It's not a simple bus. You have registers that presumably have some configuration needed. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel