From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CB6C433E0 for ; Tue, 9 Feb 2021 09:23:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83EE464DA1 for ; Tue, 9 Feb 2021 09:23:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83EE464DA1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WnlXmo3rCwjp8UOir3xV3X4exEX1M0eQtdvyZXTd2CM=; b=080smWJs3tgEKCT1ts6POkPAM y7CAgbszlTLxpgFR+A3niuqinYjKXW6A/vfOLvci6Y/yiASOq8gL7xEoiX92PT7rfpbirGr3VGQDP ESotEq/DNYTAkUSrCVec/UIKkbKUQcPMaDkCaM0kntoyFEO8EhcXQ3y4AvSBsP76WAMgdXoY3uSgN 0kYfg+RQofY5r8K76KFaHqFqncZC3icjS9IL0t8Wa/DgpOw/yL/IXPg4gI4e8NzdyUkAyFVBa5KE0 Il0HV5wGmOEcoUF6+8KlBga/15U2ktPFrULOxG0R4QVoSErVLuplItODb2bUqVvvjdDd0nwOWNjCE ksMM2oh4g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9PDY-0004PT-AG; Tue, 09 Feb 2021 09:21:56 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9PDU-0004On-Ko for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 09:21:53 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9PDR-0004Hh-Eq; Tue, 09 Feb 2021 10:21:49 +0100 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1l9PDQ-0006Ps-Rl; Tue, 09 Feb 2021 10:21:48 +0100 Date: Tue, 9 Feb 2021 10:21:48 +0100 From: Oleksij Rempel To: Fabio Estevam Subject: Re: [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings Message-ID: <20210209092148.77dliclrtv6gbe4h@pengutronix.de> References: <20210208142123.587551-1-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208142123.587551-1-festevam@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:20:51 up 68 days, 23:27, 44 users, load average: 0.19, 0.09, 0.09 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_042152_740782_D130973E X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, david@protonic.nl Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 11:21:23AM -0300, Fabio Estevam wrote: > Remove the unnecessary #address-cells/#size-cells and rename the node > names to fix the following W=1 dtc warnings: > > arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button@20: node has a unit name, but no reg or ranges property > arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button@21: node has a unit name, but no reg or ranges property > arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > Signed-off-by: Fabio Estevam Reviewed-by: Oleksij Rempel Thank you! > --- > arch/arm/boot/dts/imx6dl-plybas.dts | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts > index 333c306aa946..e6e9721ceea2 100644 > --- a/arch/arm/boot/dts/imx6dl-plybas.dts > +++ b/arch/arm/boot/dts/imx6dl-plybas.dts > @@ -19,17 +19,15 @@ chosen { > > gpio_keys { > compatible = "gpio-keys"; > - #address-cells = <1>; > - #size-cells = <0>; > autorepeat; > > - button@20 { > + start-button { > label = "START"; > linux,code = <31>; > gpios = <&gpio5 8 GPIO_ACTIVE_LOW>; > }; > > - button@21 { > + clean-button { > label = "CLEAN"; > linux,code = <46>; > gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel