From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 856D6C433E0 for ; Thu, 11 Feb 2021 22:15:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4034164E32 for ; Thu, 11 Feb 2021 22:15:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4034164E32 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:From:Subject:To: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wa9IGicBeqJzJmnUVxTiLeZlnYOzeibClyoubYG8uZ0=; b=DFSH+XCwkEUeUouwYLKUddP/q DR32QUo0dXeUmWaBb9+T1uluVqE6ApxPWcbDL+ya8ylYC4+3Q8MUs3DkumpYW9EkWh/OKmX5pbA7w mp6f0gKdVixWa+45S9+Dr6ThN35UcPwqaEfa9aT+YqJ25A9P/YR/flYXOamWdC6C5r0su/E5OHBsk Ahc6Ay3WcUt4C19L0VI1xxntitANy+sUsbmX5PJPUBYHtDbtAC2UJ44yOy2WAJn/m+0bXJufK/Isa fsAJlmGGaHLS0gG5dreOmGoQaOJiiqrrHgOlK2kTNaCZmu2EXVGEZmjJ0emd7rnlMLhe6Y73LcmBo XC9SS3ywQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAKDO-000448-Sx; Thu, 11 Feb 2021 22:13:34 +0000 Received: from shards.monkeyblade.net ([23.128.96.9] helo=mail.monkeyblade.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAKDL-00043r-Qv for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 22:13:32 +0000 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id A218B4D2ADD0C; Thu, 11 Feb 2021 14:13:29 -0800 (PST) Date: Thu, 11 Feb 2021 14:13:07 -0800 (PST) Message-Id: <20210211.141307.764092492929918552.davem@davemloft.net> To: nobuhiro1.iwamatsu@toshiba.co.jp Subject: Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver From: David Miller In-Reply-To: <20210210162954.3955785-3-nobuhiro1.iwamatsu@toshiba.co.jp> References: <20210210162954.3955785-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210210162954.3955785-3-nobuhiro1.iwamatsu@toshiba.co.jp> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Thu, 11 Feb 2021 14:13:30 -0800 (PST) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_171331_977694_A2BA6A54 X-CRM114-Status: UNSURE ( 8.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: joabreu@synopsys.com, punit1.agrawal@toshiba.co.jp, alexandre.torgue@st.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, peppe.cavallaro@st.com, kuba@kernel.org, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nobuhiro Iwamatsu Date: Thu, 11 Feb 2021 01:29:52 +0900 > +static int visconti_eth_init_hw(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat) > +{ > + struct visconti_eth *dwmac; > + unsigned int reg_val, clk_sel_val; Please use reverse christmas tree ordering for local variable declarations. > +static int visconti_eth_clock_probe(struct platform_device *pdev, > + struct plat_stmmacenet_data *plat_dat) > +{ > + int err; > + struct visconti_eth *dwmac; Likewise. > +static int visconti_eth_clock_remove(struct platform_device *pdev) > +{ > + struct net_device *ndev = platform_get_drvdata(pdev); > + struct stmmac_priv *priv = netdev_priv(ndev); > + struct visconti_eth *dwmac = get_stmmac_bsp_priv(&pdev->dev); Likewise. Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel