From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D99C433E0 for ; Thu, 11 Feb 2021 13:31:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2076E64E7A for ; Thu, 11 Feb 2021 13:31:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2076E64E7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+n8wA3wG8viMB4g9LihII6vgvPTF93R1KqLzZ0AOr7A=; b=c28XHZMufdWXAj5zuDlkCDTqJ vwV+g0jUY1ch0+n4pSkTgmktT2S30O3ywKur9/iDrzC8Ke/Fy6zKwevmvx3FHK+dzyBSDfvpie2ZC RI7nY0UyN0WyMYp66cmYMFCdXYM8Joz3YmXCdCnrW+dT1dweAfOOf++4zjZPuQdCE94ji9ky25MA6 lNavRg1R8jEmUe1aCKs8jS+fJqxjrSbNYz1khRIqBPV+Ct+QaskBfhZYObCLVSQbSbp8KJ/TPJapV vLKme6xe0X6iiNXH4+Z99A8xktFivS1klO8KBgnxCmRw2GHuEpUZ4ZRy8LurrEy348vRwa39jRtmc srD/63tcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAC2e-00056E-Dc; Thu, 11 Feb 2021 13:29:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAC2c-00055D-0k for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 13:29:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=b6o4aDZrMqqadRFFl5hXLDZ9uNJ0V1uHD3B0a1g67QA=; b=sQGdtXmcj/fpQLIDNuwVr2e7q D6QOXwqSINqDuPtvitlBPfmt2u5LPYJ2ITDGtgy0XCMjPLQJrozQSYhFEAWVKTcVgc39oX6BTiY4U CwBCBu4FgH6JlIHbybbDvTl3IYt8qtoy/nPvkV27c/hQhpen7BhP2EzSyX76DYOSofdS6xZnsi4Oj xn1BefN2dAGgrB0Jnz80PkujScNWj/SWPW460Ks21MwX1ep/OfvOnnAUG5fUiFlF+H+BZmjnja7z+ nRSE8XFGXg9pCEm1r7Jkqni07+AvzwsGfTDe5YoLxeGKGwqQqtWinSYdIOx+MVPE+FXFDNNitp26O h0vlWOHsQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42050) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAC2U-0006DE-3k; Thu, 11 Feb 2021 13:29:46 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lAC2S-00068K-Nn; Thu, 11 Feb 2021 13:29:44 +0000 Date: Thu, 11 Feb 2021 13:29:44 +0000 From: Russell King - ARM Linux admin To: Stefan Chulski Subject: Re: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold Message-ID: <20210211132944.GJ1463@shell.armlinux.org.uk> References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-9-git-send-email-stefanc@marvell.com> <20210211125009.GF1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_082954_078927_3819C56A X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "andrew@lunn.ch" , Yan Markman , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , "atenart@kernel.org" , "linux-kernel@vger.kernel.org" , Nadav Haklai , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "thomas.petazzoni@bootlin.com" , "kuba@kernel.org" , "mw@semihalf.com" , "davem@davemloft.net" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 11, 2021 at 01:02:14PM +0000, Stefan Chulski wrote: > > On Thu, Feb 11, 2021 at 12:48:55PM +0200, stefanc@marvell.com wrote: > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > index 761f745..8b4073c 100644 > > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > @@ -1133,14 +1133,19 @@ static inline void > > > mvpp2_qvec_interrupt_disable(struct mvpp2_queue_vector *qvec) static > > > void mvpp2_interrupts_mask(void *arg) { > > > struct mvpp2_port *port = arg; > > > + int cpu = smp_processor_id(); > > > + u32 thread; > > > > > > /* If the thread isn't used, don't do anything */ > > > - if (smp_processor_id() > port->priv->nthreads) > > > + if (cpu > port->priv->nthreads) > > > return; > > > > What happened to a patch fixing this? Did I miss it? Was it submitted > > independently to the net tree? > > Some reviewers asked to remove this from the series. I would send it as separate patch to net. It is not a regression, and although it is a fix, as you explained when I first raised it, it isn't a condition that can be reached due to: priv->nthreads = min_t(unsigned int, num_present_cpus(), MVPP2_MAX_THREADS); and I don't think we support a dynamic present CPU mask on any platform that is currently supported by this driver. If we did, then it would be possible for the off-by-one issue to be triggered. No matter what, it should happen _before_ this patch set is merged. Trying to do it afterwards guarantees more pain if stable trees decide they want to backport the fix. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel