From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 144EFC433DB for ; Mon, 15 Feb 2021 15:21:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE65C64DA8 for ; Mon, 15 Feb 2021 15:21:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE65C64DA8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=toshiba.co.jp Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bp3sDapq3BtY5uo0Phx/WLnK7zcQ7pmHZiJkGmgcOm0=; b=sA9IriKa3pJEiLlLld+8gvKmZ cYkvruERZokew6mKr/YG4HwwQqTXsezuGgyoRzGvS8Cq6lBjosnQdFZ26hpn/u8nNIXSavkxw3p9w 20FCZhEZVXRuF3oJDINJ8TvF4rv39+yJgSQwMkzThEJGVDMKPaYFwoDJYIfVu3HiEfZUxSwb6YPce 3nPGT2C4PKmII6HDuk6hcPDo54ibQdzFgHjFgiBxsoMRdbYef+j+4heTfyJOO9J876+E0mWAjcep8 KcnDcSRKu82B9f9oG1Ub+3cequGhf61UXu8Uhc9g3jB/e5KaCV4tyHY6b1z1i9k2FY6sazBy4YBoK /wJTNBeCw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBffq-0000fJ-D4; Mon, 15 Feb 2021 15:20:30 +0000 Received: from mo-csw1115.securemx.jp ([210.130.202.157] helo=mo-csw.securemx.jp) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBffn-0000em-8v for linux-arm-kernel@lists.infradead.org; Mon, 15 Feb 2021 15:20:28 +0000 Received: by mo-csw.securemx.jp (mx-mo-csw1115) id 11FFKG6n024333; Tue, 16 Feb 2021 00:20:16 +0900 X-Iguazu-Qid: 2wGqn5DuWuqX2Ss3iz X-Iguazu-QSIG: v=2; s=0; t=1613402415; q=2wGqn5DuWuqX2Ss3iz; m=/wKFgwyBTwVVVznr0ILCXsnu0TO+86riP91KaZy3nkg= Received: from imx2.toshiba.co.jp (imx2.toshiba.co.jp [106.186.93.51]) by relay.securemx.jp (mx-mr1113) id 11FFKDcG038195; Tue, 16 Feb 2021 00:20:14 +0900 Received: from enc01.toshiba.co.jp ([106.186.93.100]) by imx2.toshiba.co.jp with ESMTP id 11FFKD2G008102; Tue, 16 Feb 2021 00:20:13 +0900 (JST) Received: from hop001.toshiba.co.jp ([133.199.164.63]) by enc01.toshiba.co.jp with ESMTP id 11FFKCeJ017228; Tue, 16 Feb 2021 00:20:13 +0900 Date: Tue, 16 Feb 2021 00:20:11 +0900 From: Nobuhiro Iwamatsu To: Arnd Bergmann Subject: Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver X-TSB-HOP: ON Message-ID: <20210215152011.5q7eudtfzn7afmfi@toshiba.co.jp> References: <20210215050655.2532-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210215050655.2532-3-nobuhiro1.iwamatsu@toshiba.co.jp> <20210215072809.n3r5rdswookzri6j@toshiba.co.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210215_102027_726770_381A6632 X-CRM114-Status: GOOD ( 26.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , punit1.agrawal@toshiba.co.jp, Alexandre Torgue , Leon Romanovsky , DTML , Networking , "linux-kernel@vger.kernel.org" , Rob Herring , Giuseppe Cavallaro , Jakub Kicinski , yuji2.ishikawa@toshiba.co.jp, "David S . Miller" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Feb 15, 2021 at 01:19:18PM +0100, Arnd Bergmann wrote: > On Mon, Feb 15, 2021 at 10:23 AM Leon Romanovsky wrote: > > On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > > > > > > Sorry, I sent the wrong patchset that didn't fix this point out. > > > > > > > I asked it before, but never received an answer. > > > > > > I have received your point out and have sent an email with the content > > > to remove this line. But it may not have arrived yet... > > > > > > > Why did you use "def_bool y" and not "default y"? Isn't it supposed to be > > > > "depends on STMMAC_ETH"? And probably it shouldn't be set as a default as "y". > > > > > > > > > > The reason why "def_bool y" was set is that the wrong fix was left when > > > debugging. Also, I don't think it is necessary to set "default y". > > > This is also incorrect because it says "bool" Toshiba Visconti DWMAC > > > support "". I change it to trustate in the new patch. > > > > > > And this driver is enabled when STMMAC_PLATFORM was Y. And STMMAC_PLATFORM > > > depends on STMMAC_ETH. > > > So I understand that STMMAC_ETH does not need to be dependents. Is this > > > understanding wrong? > > > > This is correct understanding, just need to clean other entries in that > > Kconfig that depends on STMMAC_ETH. > > 'tristate' with no default sounds right. I see that some platforms have a > default according to the platform, which also makes sense but isn't > required. What I would suggest though is a dependency on the platform, > to make it easier to disable the front-end based on which platforms > are enabled. This would end up as > > config DWMAC_VISCONTI > tristate "Toshiba Visconti DWMAC support" > depends on ARCH_VISCONTI || COMPILE_TEST > depends on OF && COMMON_CLK # only add this line if it's > required for compilation > default ARCH_VISCONTI > The fix at hand is the same as your suggestion. Thank you for your comment. > Arnd > Best regards, Nobuhiro _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel