From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_ALL,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C60C6C433E0 for ; Tue, 16 Feb 2021 18:39:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82AF664E28 for ; Tue, 16 Feb 2021 18:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82AF664E28 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B4aI6FV7cR3M7GKOSBeUPK8EmQ0vjjwcsAiQl8eUMJQ=; b=ZR2+8mpA2F7ifEA25DzEEP7O5 cyKxNnth1khJwJ9Y5DwDnjtErKEJPp+m+45KY7wgR44sndoynT3lvnqe4DcTsqD6eIEl8e65yN9gS 4enw6ZLXpJXCbR+D65aOm/Sz6KqqmTG0UPhw43a8OLP2udg26xC6tycxqZe9Rs++kISaM3ZGe/0kb qjwAavjnvCFgY93JvB2HovHMLK84pjK4yZvyTFnXmteEdWDpSERCe3gyrp0SLXjFKMcsTY7KmWk6Q ISJeXKOccSwKy7KQK+O4K7pT6gZDJnG9ljkwLlJAHSut1P4LocictUPJYAP2rBQ7JxBNtZixvENjq /VgI5UchQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lC5El-0001jU-MI; Tue, 16 Feb 2021 18:38:15 +0000 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lC5Ej-0001iZ-6j for linux-arm-kernel@lists.infradead.org; Tue, 16 Feb 2021 18:38:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1613500693; x=1645036693; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LAtb7q8KeF6V0S8qBZ40P6liWm7mLq7atnaYX/bcDfc=; b=OWlx5EqCv++R12PP4oSWKlI1ejN1Mefxm8D+l2v4mFDp7PfEG7Nv8hzq X514UgQ0Kq3ZpMcjtwyOVNSeXeZPty/TvBWrTGEMyfKfFBw+MunQAUcwN wrokdRlxjdogjYXijIPjEod9MIKDYN2zk/Mffr0gvJuUAqKR6oyzi+6GX E=; X-IronPort-AV: E=Sophos;i="5.81,184,1610409600"; d="scan'208";a="88167432" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1d-37fd6b3d.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 16 Feb 2021 18:38:11 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-1d-37fd6b3d.us-east-1.amazon.com (Postfix) with ESMTPS id E4398281E99; Tue, 16 Feb 2021 18:38:09 +0000 (UTC) Received: from EX13D13UWB002.ant.amazon.com (10.43.161.21) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 16 Feb 2021 18:38:09 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D13UWB002.ant.amazon.com (10.43.161.21) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 16 Feb 2021 18:38:09 +0000 Received: from dev-dsk-shaoyi-2b-c0ca772a.us-west-2.amazon.com (172.22.152.76) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 16 Feb 2021 18:38:08 +0000 Received: by dev-dsk-shaoyi-2b-c0ca772a.us-west-2.amazon.com (Postfix, from userid 13116433) id 1A94445897; Tue, 16 Feb 2021 18:38:08 +0000 (UTC) Date: Tue, 16 Feb 2021 18:38:08 +0000 From: Shaoying Xu To: , Subject: Re: [PATCH] arm64 module: set plt* section addresses to 0x0 Message-ID: <20210216183808.GA24095@amazon.com> References: <20210216183234.GA23876@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210216183234.GA23876@amazon.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210216_133813_352788_5A380361 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: benh@amazon.com, fllinden@amazon.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shaoyi@amazon.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org So sorry about the double send because I forgot to cc the lists. Please just ignore the first one. Thank you! On Tue, Feb 16, 2021 at 06:32:34PM +0000, Shaoying Xu wrote: > These plt* and .text.ftrace_trampoline sections specified for arm64 have > non-zero addressses. Non-zero section addresses in a relocatable ELF would > confuse GDB when it tries to compute the section offsets and it ends up > printing wrong symbol addresses. Therefore, set them to zero, which mirrors > the change in commit 5d8591bc0fba ("module: set ksymtab/kcrctab* section > addresses to 0x0"). > > Reported-by: Frank van der Linden > Signed-off-by: Shaoying Xu > Cc: stable@vger.kernel.org > --- > arch/arm64/include/asm/module.lds.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/include/asm/module.lds.h b/arch/arm64/include/asm/module.lds.h > index 691f15af788e..810045628c66 100644 > --- a/arch/arm64/include/asm/module.lds.h > +++ b/arch/arm64/include/asm/module.lds.h > @@ -1,7 +1,7 @@ > #ifdef CONFIG_ARM64_MODULE_PLTS > SECTIONS { > - .plt (NOLOAD) : { BYTE(0) } > - .init.plt (NOLOAD) : { BYTE(0) } > - .text.ftrace_trampoline (NOLOAD) : { BYTE(0) } > + .plt 0 (NOLOAD) : { BYTE(0) } > + .init.plt 0 (NOLOAD) : { BYTE(0) } > + .text.ftrace_trampoline 0 (NOLOAD) : { BYTE(0) } > } > #endif > -- > 2.16.6 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel