From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D658CC433E0 for ; Wed, 17 Feb 2021 04:23:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CE2564DF3 for ; Wed, 17 Feb 2021 04:23:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CE2564DF3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sholland.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LPeRmg6NYRON8EVqgfxHrs+GdERDhQ4xAdEdrjd7ugg=; b=neOVy3N0axAcTHtqhOkRnfAKD 6a0X2THPTpWSKizvhpYshTZuv3+BCP2TJLlJlHol9JAJyfKGYMJtD1O0LA6JRvESlnCjQ9UdbUgS4 tjeijbYDZx5PY+mj0VzHB6ENpS17ExlUpBJJPwp1baatHAmtBXVmyAvYbkQeMj2vG38Tq5A0iFnuY sUKGya1cjObLgndeJTOnUEoSzZEvMf0zZjFVESkqC8q7ENT1Sb19oLTjOgAfLWLhZ4oDeaxgvcipN ymxazeInFpumtWhAV+Iei+LIHyv3BdtVfy2g5xafO+4+aCmqj1BZ7UmBpudV0Q1BOd+MmPBc8B1hi 0qXl74PjA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCEKD-00045Y-4U; Wed, 17 Feb 2021 04:20:29 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCEJy-00041d-Ag for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2021 04:20:16 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 70600580379; Tue, 16 Feb 2021 23:20:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 16 Feb 2021 23:20:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=OhQXn3RW7Fq5W eW0YK8stGZwIJtakGlXtoagEETPVuo=; b=qoE60RQqZ21sHfSUKGIC/fJqsB9c5 JLsjRbftMIjxgXG/ts3LQ/1pJhcXTQVh69mrprhXt+86Tb7/AmPZmxYP3tyW/42d sV0iTbePstr5lTOZrxy0hTCdL/oaqqJ7eTWAdwZYtwzQaJtnnQFKkBghFEzM9dyy blbONK0FFXcJ2OFRUax16yzOKXZQQ7wZ64rGotg2WUrL3LnaXvM9HqjSpQH7teq6 YV+lAupP4qLLhgUE1+f6+hAMBCcH2jtwxKAGIdqz/1RiR1dLZ5aDfagRaspUclIl fMkJww20JBBG788xf3KlaKKyTLuwzJMCdo+mCRRp6E7ZfrDVhJN5GdgTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=OhQXn3RW7Fq5WeW0YK8stGZwIJtakGlXtoagEETPVuo=; b=iIrmR/ut BXb1/NPJptHndtb32v18Z6QbJWQzkTmsE0VqqVviJv4b3EChctquJx33xboJ3shK A87AV+HWXEJill+eSuOKi75C54MHXedpqRvCE2BHhC+vB2+ZdeOeQC8FbRj47lVc qtYHQo88LckJfu47l7ZprYGeQB+56oEzU9p2M20DX4yX4Ta/DexZhk1oqhnx+yS4 SOG5c7gF2o2NYQBAewfCX4ROfHjLIg+wltx6s79AmObKlQCK757DV8FFs5x73fi9 byobBoWbhpAsp4e9TL4sNqzNmLWMylOqIH/ZOREIMMzRidl1ANn0Q/nijnCj//aG 8FjfjBpwgVIJEQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjedugdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepufgrmhhuvghl ucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecuggftrf grthhtvghrnhepudfhjeefvdfhgfefheetgffhieeigfefhefgvddvveefgeejheejvdfg jeehueeinecukfhppeejtddrudefhedrudegkedrudehudenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmuhgvlhesshhhohhllhgrnhgu rdhorhhg X-ME-Proxy: Received: from titanium.stl.sholland.net (70-135-148-151.lightspeed.stlsmo.sbcglobal.net [70.135.148.151]) by mail.messagingengine.com (Postfix) with ESMTPA id 692C024005D; Tue, 16 Feb 2021 23:20:09 -0500 (EST) From: Samuel Holland To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Corentin Labbe Subject: [PATCH net-next v2 4/5] net: stmmac: dwmac-sun8i: Minor probe function cleanup Date: Tue, 16 Feb 2021 22:20:05 -0600 Message-Id: <20210217042006.54559-5-samuel@sholland.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210217042006.54559-1-samuel@sholland.org> References: <20210217042006.54559-1-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210216_232014_445159_2AEF6F9B X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , Samuel Holland , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Adjust the spacing and use an explicit "return 0" in the success path to make the function easier to parse. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index b61f442ed3033..a3d333b652836 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -1229,6 +1229,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) ndev = dev_get_drvdata(&pdev->dev); priv = netdev_priv(ndev); + /* The mux must be registered after parent MDIO * so after stmmac_dvr_probe() */ @@ -1247,7 +1248,8 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) goto dwmac_remove; } - return ret; + return 0; + dwmac_mux: reset_control_put(gmac->rst_ephy); clk_put(gmac->ephy_clk); -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel