linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/5] arm64: dts: librem5 phone and devkit dts and config updates
@ 2021-02-17 11:19 Martin Kepplinger
  2021-02-17 11:19 ` [PATCH v2 1/5] arm64: dts: imx8mq-librem5-devkit: Drop buck3 startup-ramp-delay Martin Kepplinger
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Martin Kepplinger @ 2021-02-17 11:19 UTC (permalink / raw)
  To: robh, shawnguo, festevam
  Cc: devicetree, kernel, Martin Kepplinger, linux-kernel, krzk,
	linux-imx, kernel, linux-arm-kernel

Small updates to Purism hardware in order to maintain support.

revision history
----------------
v2: (thank you, Krzysztof)
 * fix flash partition DT syntax
 * add one reviewed tag

v1:
https://lore.kernel.org/linux-arm-kernel/20210208131527.24463-1-martin.kepplinger@puri.sm/T/#t

Angus Ainslie (1):
  arm64: dts: librem5: protect some partitions of the nor-flash

Guido Günther (3):
  arm64: dts: imx8mq-librem5-devkit: Drop buck3 startup-ramp-delay
  arm64: dts: librem5: Drop assigned-clocks from SAI2
  arm64: defconfig: Enable devfreq support for i.MX8MQ

Martin Kepplinger (1):
  arm64: dts: imx8mq-librem5-r2: set nearlevel to 120

 .../dts/freescale/imx8mq-librem5-devkit.dts    |  1 -
 .../boot/dts/freescale/imx8mq-librem5-r2.dts   |  2 +-
 .../boot/dts/freescale/imx8mq-librem5.dtsi     | 18 ++++++++++++++++--
 arch/arm64/configs/defconfig                   |  2 ++
 4 files changed, 19 insertions(+), 4 deletions(-)

-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 1/5] arm64: dts: imx8mq-librem5-devkit: Drop buck3 startup-ramp-delay
  2021-02-17 11:19 [PATCH v2 0/5] arm64: dts: librem5 phone and devkit dts and config updates Martin Kepplinger
@ 2021-02-17 11:19 ` Martin Kepplinger
  2021-02-17 11:19 ` [PATCH v2 2/5] arm64: dts: librem5: Drop assigned-clocks from SAI2 Martin Kepplinger
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Martin Kepplinger @ 2021-02-17 11:19 UTC (permalink / raw)
  To: robh, shawnguo, festevam
  Cc: devicetree, kernel, Martin Kepplinger, Guido Günther,
	linux-kernel, krzk, linux-imx, kernel, linux-arm-kernel

From: Guido Günther <agx@sigxcpu.org>

The PMIC driver now sets appropriate default delays.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index dd217a0760e9..88508890063f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -315,7 +315,6 @@
 				regulator-min-microvolt = <700000>;
 				regulator-max-microvolt = <1300000>;
 				regulator-boot-on;
-				regulator-enable-ramp-delay = <200>;
 				rohm,dvs-run-voltage = <900000>;
 			};
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 2/5] arm64: dts: librem5: Drop assigned-clocks from SAI2
  2021-02-17 11:19 [PATCH v2 0/5] arm64: dts: librem5 phone and devkit dts and config updates Martin Kepplinger
  2021-02-17 11:19 ` [PATCH v2 1/5] arm64: dts: imx8mq-librem5-devkit: Drop buck3 startup-ramp-delay Martin Kepplinger
@ 2021-02-17 11:19 ` Martin Kepplinger
  2021-02-17 11:19 ` [PATCH v2 3/5] arm64: defconfig: Enable devfreq support for i.MX8MQ Martin Kepplinger
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Martin Kepplinger @ 2021-02-17 11:19 UTC (permalink / raw)
  To: robh, shawnguo, festevam
  Cc: devicetree, kernel, Martin Kepplinger, Guido Günther,
	linux-kernel, krzk, linux-imx, kernel, linux-arm-kernel

From: Guido Günther <agx@sigxcpu.org>

IMX8MQ_AUDIO_PLL1 and IMX8MQ_AUDIO_PLL2 are setup to the same rates
right on the clock controller.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 06a4799b6aeb..c2bbbdeb93e3 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1051,8 +1051,6 @@
 	assigned-clocks = <&clk IMX8MQ_CLK_SAI2>;
 	assigned-clock-parents = <&clk IMX8MQ_AUDIO_PLL1_OUT>;
 	assigned-clock-rates = <24576000>;
-	assigned-clocks = <&clk IMX8MQ_AUDIO_PLL1>, <&clk IMX8MQ_AUDIO_PLL2>;
-	assigned-clock-rates = <786432000>, <722534400>;
 	status = "okay";
 };
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 3/5] arm64: defconfig: Enable devfreq support for i.MX8MQ
  2021-02-17 11:19 [PATCH v2 0/5] arm64: dts: librem5 phone and devkit dts and config updates Martin Kepplinger
  2021-02-17 11:19 ` [PATCH v2 1/5] arm64: dts: imx8mq-librem5-devkit: Drop buck3 startup-ramp-delay Martin Kepplinger
  2021-02-17 11:19 ` [PATCH v2 2/5] arm64: dts: librem5: Drop assigned-clocks from SAI2 Martin Kepplinger
@ 2021-02-17 11:19 ` Martin Kepplinger
  2021-02-17 11:19 ` [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash Martin Kepplinger
  2021-02-17 11:19 ` [PATCH v2 5/5] arm64: dts: imx8mq-librem5-r2: set nearlevel to 120 Martin Kepplinger
  4 siblings, 0 replies; 7+ messages in thread
From: Martin Kepplinger @ 2021-02-17 11:19 UTC (permalink / raw)
  To: robh, shawnguo, festevam
  Cc: devicetree, kernel, Martin Kepplinger, Guido Günther,
	linux-kernel, krzk, linux-imx, kernel, linux-arm-kernel

From: Guido Günther <agx@sigxcpu.org>

This is needed to make DRAM frequency scaling via devfreq as used
on the Librem 5 and Librem 5 Devkit.

With the interconnect support enabled we now need imx devfreq on top
to make this work.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d612f633b771..e9f3e47933d5 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1022,6 +1022,8 @@ CONFIG_ARCH_TEGRA_186_SOC=y
 CONFIG_ARCH_TEGRA_194_SOC=y
 CONFIG_ARCH_TEGRA_234_SOC=y
 CONFIG_TI_SCI_PM_DOMAINS=y
+CONFIG_ARM_IMX_BUS_DEVFREQ=m
+CONFIG_ARM_IMX8M_DDRC_DEVFREQ=m
 CONFIG_EXTCON_PTN5150=m
 CONFIG_EXTCON_USB_GPIO=y
 CONFIG_EXTCON_USBC_CROS_EC=y
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash
  2021-02-17 11:19 [PATCH v2 0/5] arm64: dts: librem5 phone and devkit dts and config updates Martin Kepplinger
                   ` (2 preceding siblings ...)
  2021-02-17 11:19 ` [PATCH v2 3/5] arm64: defconfig: Enable devfreq support for i.MX8MQ Martin Kepplinger
@ 2021-02-17 11:19 ` Martin Kepplinger
  2021-02-17 11:52   ` Krzysztof Kozlowski
  2021-02-17 11:19 ` [PATCH v2 5/5] arm64: dts: imx8mq-librem5-r2: set nearlevel to 120 Martin Kepplinger
  4 siblings, 1 reply; 7+ messages in thread
From: Martin Kepplinger @ 2021-02-17 11:19 UTC (permalink / raw)
  To: robh, shawnguo, festevam
  Cc: devicetree, kernel, Martin Kepplinger, Angus Ainslie,
	linux-kernel, krzk, linux-imx, kernel, linux-arm-kernel

From: Angus Ainslie <angus@akkea.ca>

These sections should be read only as they contain important data.

Signed-off-by: Angus Ainslie <angus@akkea.ca>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 .../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index c2bbbdeb93e3..3c0462f81b3a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -258,6 +258,22 @@
 		compatible = "jedec,spi-nor";
 		reg = <0>;
 		spi-max-frequency = <1000000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		partition@0 {
+			label = "protected0";
+			reg = <0x00000000 0x00030000>;
+			read-only;
+		};
+		partition@30000 {
+			label = "protected1";
+			reg = <0x00030000 0x00010000>;
+			read-only;
+		};
+		partition@40000 {
+			label = "rw";
+			reg = <0x00040000 0x001C0000>;
+		};
 	};
 };
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 5/5] arm64: dts: imx8mq-librem5-r2: set nearlevel to 120
  2021-02-17 11:19 [PATCH v2 0/5] arm64: dts: librem5 phone and devkit dts and config updates Martin Kepplinger
                   ` (3 preceding siblings ...)
  2021-02-17 11:19 ` [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash Martin Kepplinger
@ 2021-02-17 11:19 ` Martin Kepplinger
  4 siblings, 0 replies; 7+ messages in thread
From: Martin Kepplinger @ 2021-02-17 11:19 UTC (permalink / raw)
  To: robh, shawnguo, festevam
  Cc: devicetree, kernel, Martin Kepplinger, linux-kernel, krzk,
	linux-imx, kernel, linux-arm-kernel

On Birch I can never reach 220 and hence the display would never
turn off. Tests suggest 120 to be a good threshold value for all Birch
devices.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
index d77fc5df3f06..73bd431cbd6a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
@@ -25,5 +25,5 @@
 };
 
 &proximity {
-	proximity-near-level = <220>;
+	proximity-near-level = <120>;
 };
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash
  2021-02-17 11:19 ` [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash Martin Kepplinger
@ 2021-02-17 11:52   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-17 11:52 UTC (permalink / raw)
  To: Martin Kepplinger
  Cc: robh, kernel, devicetree, festevam, Angus Ainslie, linux-kernel,
	linux-imx, kernel, shawnguo, linux-arm-kernel

On Wed, Feb 17, 2021 at 12:19:43PM +0100, Martin Kepplinger wrote:
> From: Angus Ainslie <angus@akkea.ca>
> 
> These sections should be read only as they contain important data.
> 
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  .../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index c2bbbdeb93e3..3c0462f81b3a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -258,6 +258,22 @@
>  		compatible = "jedec,spi-nor";
>  		reg = <0>;
>  		spi-max-frequency = <1000000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;

Still a line break here is needed.

> +		partition@0 {
> +			label = "protected0";
> +			reg = <0x00000000 0x00030000>;
> +			read-only;
> +		};
> +		partition@30000 {
> +			label = "protected1";
> +			reg = <0x00030000 0x00010000>;

Drop the leading 0 in address and size. I saw some DTS using it but it's
not the common format. All nodes don't lead with 0 so why partitions are
different?

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-02-17 11:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-17 11:19 [PATCH v2 0/5] arm64: dts: librem5 phone and devkit dts and config updates Martin Kepplinger
2021-02-17 11:19 ` [PATCH v2 1/5] arm64: dts: imx8mq-librem5-devkit: Drop buck3 startup-ramp-delay Martin Kepplinger
2021-02-17 11:19 ` [PATCH v2 2/5] arm64: dts: librem5: Drop assigned-clocks from SAI2 Martin Kepplinger
2021-02-17 11:19 ` [PATCH v2 3/5] arm64: defconfig: Enable devfreq support for i.MX8MQ Martin Kepplinger
2021-02-17 11:19 ` [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash Martin Kepplinger
2021-02-17 11:52   ` Krzysztof Kozlowski
2021-02-17 11:19 ` [PATCH v2 5/5] arm64: dts: imx8mq-librem5-r2: set nearlevel to 120 Martin Kepplinger

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox