From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C3BC433DB for ; Wed, 17 Feb 2021 11:43:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1B5564E02 for ; Wed, 17 Feb 2021 11:43:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1B5564E02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ir4UphwAui5fQnn4Zd4IIbxM/EnPKXoT5ggqRw76rMM=; b=IEoMIxK7+eD10bP+QsIgKwJUY r5gcTpse/UOxyz83TvFjSjCKGQb+LjC/1RlUaGSLI5k6ujnGYjoZ+t9n1TyDxzFGPFGsLwJ9ighG3 Hg8XZjfSUIwtCJ1CYIAL7EdBXIx1h/VjfbD+Rr6uDfKrDlrABSqzv5BTRAqr0LhrnOcp2TaTBq2Wl uHrTV1g2mqStXcyTfGXcfSTI29CSnMWaEW0a2RUPdKqDv0LUwKhflhMpuOHAaiAwGwJeWjj8iiz2y W0nwxKbU/GL+ReKGtBxnLzofghQsJsff937Vk0kR8dnxXxv9xt1vbijq5ddvaK/i0GXIyepXCiPB/ 3dVd0aegw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCLC9-0003UK-LU; Wed, 17 Feb 2021 11:40:37 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCLC5-0003Tu-B3 for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2021 11:40:35 +0000 Received: by mail-pf1-x42d.google.com with SMTP id x136so8250263pfc.2 for ; Wed, 17 Feb 2021 03:40:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=11pGVD0nzA2DAiJ7cWPXp9I44T8zR661lI4xstwokb8=; b=nN3POMtqLZQF8/79uB0ZdenvqJkcov6oKL3+Yaukuqsj3U0pi+rmZsW6D/unqNXCP0 4Xdu9O8wIAQpxqis6OuGqhr9RyyW/HWKYqZvwuPiAvJH+AHoGjRTDzciOgrTwWOkCoUF XT+TnNXJQBqDJCNrAYWI7L4mVB0cgLerE8aevwJe0wxiKZjvQsNBpi12uHi1aFyY+LEN 9HAfWZMhSvePdMxjTbgmHXF0qK740ZMRl8hnxQotc2GLAzMrDYRs03JAFseq1X4pOtbd lNCp3VQMft6/UqDuzuWT4qnPLMsSrIfq3lbn5vOqg/MtC5jv83XFjcuEW3ygFDMyvUoR IK9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=11pGVD0nzA2DAiJ7cWPXp9I44T8zR661lI4xstwokb8=; b=tk/puSuNBnj+lgnR+mhtZnXUDNdY1fKz5XJzofA8LhmKw2oTaMLU+0t71FqC7myzFE FocXGaNUxPiw0kPyEHIvhqR0p/5XBxEPJXLqqQX6rIwvUwfjtBLJIb3YSm6BA+kB+tG6 FiLKY7Q0ks2BJI6oK4layG+5K642gqFFMFZhZGhkrbgOM2hWejFSHNcHJ7TiRZ9eXbQF FlxsFKLJWluP/Gd1mANTUiHrJCuhgoixaHtMDENQuBZU6GvkKSFRUBwW6FE3XlO+lYa8 g+s3jRlPrsdEsbGC5DBQHPpuJBd+MyFReQrKZDqIZw8Rq1FHPWWcLeUMzQsMWg/7pn0o joxw== X-Gm-Message-State: AOAM5323RlvrmwE9O224NtwmckMXhD1iWT7/MVR293uQw0FkLP4UimzV LgftrMwLVvIBYzn0WULGTr+x2A== X-Google-Smtp-Source: ABdhPJzr4uJe4QkljUPFWlLqLXnOjixB1cwYPo3cq1LNkxSXQbV/GK5ae2xqgQx6gdCFQbeMSp90cQ== X-Received: by 2002:a62:6585:0:b029:1b9:d8d9:1af2 with SMTP id z127-20020a6265850000b02901b9d8d91af2mr23638713pfb.17.1613562030391; Wed, 17 Feb 2021 03:40:30 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id h124sm2331354pfe.216.2021.02.17.03.40.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Feb 2021 03:40:29 -0800 (PST) Date: Wed, 17 Feb 2021 17:10:27 +0530 From: Viresh Kumar To: Ionela Voinescu Subject: Re: [PATCH V3 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback Message-ID: <20210217114027.ashqh67hrfk4hwib@vireshk-i7> References: <20210203114521.GA6380@arm.com> <20210205091424.3od3tme3f7mh7ebp@vireshk-i7> <20210217002422.GA17422@arm.com> <20210217042558.o4anjdkayzgqny55@vireshk-i7> <20210217113011.GA22176@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210217113011.GA22176@arm.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210217_064033_423029_EB2AD486 X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vincent Guittot , linux-pm@vger.kernel.org, Catalin Marinas , Rafael Wysocki , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Sudeep Holla , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17-02-21, 11:30, Ionela Voinescu wrote: > The problem is not topology_scale_freq_invariant() but whether a scale > factor is set for some CPUs. > > Scenario (test system above): > - "AMUs" are only supported for [1-2], > - cpufreq_supports_freq_invariance() -> false > > What should happen: > - topology_scale_freq_invariant() -> false (passed) > - all CPUs should have their freq_scale unmodified (1024) - (failed) > because only 2 out of 6 CPUs have a method of setting a scale factor > > What does happen: > - arch_set_freq_tick() -> topology_set_freq_tick() will set a scale > factor for [1-2] based on AMUs. This should not happen. We will end > up with invariant signals for bigs and signals that are not freq > invariant for littles. Another case. cpufreq is included as a module and AMU is implemented partially. - first time cpufreq driver is inserted, we set up everything and freq_scale gets updated on ticks. - remove cpufreq driver, we are back in same situation. We can't control it that way.. Or we add another call layer in middle before the tick-handler gets called for AMU, which will check if we are fully invariant or not ? -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel