linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@puri.sm, devicetree@vger.kernel.org,
	festevam@gmail.com, Angus Ainslie <angus@akkea.ca>,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, shawnguo@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash
Date: Wed, 17 Feb 2021 12:52:48 +0100	[thread overview]
Message-ID: <20210217115248.7t5b64jorzfzbd7h@kozik-lap> (raw)
In-Reply-To: <20210217111944.1416-5-martin.kepplinger@puri.sm>

On Wed, Feb 17, 2021 at 12:19:43PM +0100, Martin Kepplinger wrote:
> From: Angus Ainslie <angus@akkea.ca>
> 
> These sections should be read only as they contain important data.
> 
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  .../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index c2bbbdeb93e3..3c0462f81b3a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -258,6 +258,22 @@
>  		compatible = "jedec,spi-nor";
>  		reg = <0>;
>  		spi-max-frequency = <1000000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;

Still a line break here is needed.

> +		partition@0 {
> +			label = "protected0";
> +			reg = <0x00000000 0x00030000>;
> +			read-only;
> +		};
> +		partition@30000 {
> +			label = "protected1";
> +			reg = <0x00030000 0x00010000>;

Drop the leading 0 in address and size. I saw some DTS using it but it's
not the common format. All nodes don't lead with 0 so why partitions are
different?

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-17 11:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 11:19 [PATCH v2 0/5] arm64: dts: librem5 phone and devkit dts and config updates Martin Kepplinger
2021-02-17 11:19 ` [PATCH v2 1/5] arm64: dts: imx8mq-librem5-devkit: Drop buck3 startup-ramp-delay Martin Kepplinger
2021-02-17 11:19 ` [PATCH v2 2/5] arm64: dts: librem5: Drop assigned-clocks from SAI2 Martin Kepplinger
2021-02-17 11:19 ` [PATCH v2 3/5] arm64: defconfig: Enable devfreq support for i.MX8MQ Martin Kepplinger
2021-02-17 11:19 ` [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash Martin Kepplinger
2021-02-17 11:52   ` Krzysztof Kozlowski [this message]
2021-02-17 11:19 ` [PATCH v2 5/5] arm64: dts: imx8mq-librem5-r2: set nearlevel to 120 Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210217115248.7t5b64jorzfzbd7h@kozik-lap \
    --to=krzk@kernel.org \
    --cc=angus@akkea.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --subject='Re: [PATCH v2 4/5] arm64: dts: librem5: protect some partitions of the nor-flash' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox