From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36496C433DB for ; Wed, 17 Feb 2021 11:59:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4A5464E04 for ; Wed, 17 Feb 2021 11:59:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4A5464E04 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O7hhiEKAGlT+im+RQ+YjcXnj3RN7Ohdtw4ScrKa6LoQ=; b=1MJ2r2meRAiWGnRiUX2sLCC44 CZokSTCEjwLyNkv4PjSr+yyLGZmRkT9OnkWG2ySdNyv4wX8n+9hSvAqpb3U7Hj+RDzTHh1+eTNgha mrSSKyBnCWqVql+LBCdSw/C8qPHVuQy7aKwm7IBOwenSVm43XhxV46mMQhLnbvZBlhlZ63Upcuhcs mj+iTmdYUGYDgIZ0VCHtS1/mBg0SPmITkgYC9H2cMFytNOa5by1Yyobb5DO2wEGtxELWdDt40hkT4 6o1uNn+qC65UEQrFbGXLz4FMntR7dYrQMyL/zEY9U/6aBBYDsnzhxudw+BMm/bUNQ1m/hT3unMJov rTRGd53oA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCLTJ-0007yc-AA; Wed, 17 Feb 2021 11:58:21 +0000 Received: from mail-ej1-f41.google.com ([209.85.218.41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCLTG-0007xc-3q for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2021 11:58:19 +0000 Received: by mail-ej1-f41.google.com with SMTP id g5so18122019ejt.2 for ; Wed, 17 Feb 2021 03:58:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=erCIbWwHyy0kxKaSupmXnRMAfJfKXIaVx29x2jmxgNw=; b=Q+7vuPcWpWtm6fa6UQlDdoYXfRtwR64HJOxOJHgS9NdT6w7bZHUV95JbiV3DoiZtBf JmumL3lqlk26TiQXS2f5xIj0chQky6zHi8UsgL40VspGca5LayuT7+8KmB9AN0GukADK dVTyWgHxBk1XVfoi5aFQc4j96IaXniYRu2jLfj3nQ0oGofo9q0HBrEeQPV2myOVLK1TN zuWyJrdYq3o1u4V6eyjiiz8p2mC386ri8Lv2iyP8XtyeVnoowFt/mUdLKb9GECpEMwlK gaWDsPZUjFurVUYw/fCFFrLZDExTvSNE0JC9UbrUKTRxxm3ckCVByjgSPPkGMXfV9Tz9 tmPQ== X-Gm-Message-State: AOAM5308YjGWiFs71LyQOr6BcPK/AudavKK1gbSQiJ/Wl6Sp8CAc6+WD GlhG+nN5YIxsd5kyqRIGC98= X-Google-Smtp-Source: ABdhPJxQtSvc107eIURtn03bp6/fSuo9tLZn/i1hvJr22pX/Rgb49D3j+cNh4OWwLnH4FEkpi2HSGA== X-Received: by 2002:a17:906:654d:: with SMTP id u13mr24389656ejn.299.1613563096453; Wed, 17 Feb 2021 03:58:16 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id a1sm1018963edj.6.2021.02.17.03.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 03:58:15 -0800 (PST) Date: Wed, 17 Feb 2021 12:58:14 +0100 From: Krzysztof Kozlowski To: Adrien Grassein Subject: Re: [PATCH 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip Message-ID: <20210217115814.zfwhd5fwb2ibygt3@kozik-lap> References: <20210215231943.36910-1-adrien.grassein@gmail.com> <20210215231943.36910-2-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210215231943.36910-2-adrien.grassein@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210217_065818_188169_40E7C6D3 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, will@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, catalin.marinas@arm.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 16, 2021 at 12:19:36AM +0100, Adrien Grassein wrote: > Add usdhc3 description which corresponds to the wifi/bt chip > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > index c0c384d76147..bf20a40bcda0 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > @@ -9,6 +9,18 @@ > / { > model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > + > + reg_wlan_vmmc: regulator-wlan-vmmc { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_reg_wlan_vmmc>; > + regulator-name = "reg_wlan_vmmc"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + startup-delay-us = <70000>; That's quite a startup time... and it happens is the same as in bindings example. Do you really need it or it was just copied? I actually don't mind it, just poking at various things. :) > + }; > }; > > &A53_0 { > @@ -206,6 +218,19 @@ &usdhc2 { > status = "okay"; > }; > > +/* wlan */ > +&usdhc3 { > + bus-width = <4>; > + sdhci-caps-mask = <0x2 0x0>; > + non-removable; > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc3>; > + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; > + vmmc-supply = <®_wlan_vmmc>; What about vqmmc? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel